From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com)
Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28])
 by groups.io with SMTP; Mon, 15 Jul 2019 18:39:50 -0700
Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id 8565FC036744;
	Tue, 16 Jul 2019 01:39:49 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-33.ams2.redhat.com [10.36.116.33])
	by smtp.corp.redhat.com (Postfix) with ESMTP id E0BB05D968;
	Tue, 16 Jul 2019 01:39:47 +0000 (UTC)
Subject: Re: [PATCH 2/6] edksetup.sh: Use $SCRIPTNAME consistently instead of 'edksetup.sh'
To: Rebecca Cran <rebecca@bsdio.com>, devel@edk2.groups.io,
 bob.c.feng@intel.com, liming.gao@intel.com, leif.lindholm@linaro.org,
 michael.d.kinney@intel.com, afish@apple.com
References: <20190715222516.53254-1-rebecca@bsdio.com>
 <20190715222516.53254-2-rebecca@bsdio.com>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <7926bb4f-7a51-239d-f224-63189e3cb9ca@redhat.com>
Date: Tue, 16 Jul 2019 03:39:47 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20190715222516.53254-2-rebecca@bsdio.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Tue, 16 Jul 2019 01:39:49 +0000 (UTC)
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 07/16/19 00:25, Rebecca Cran wrote:
> Signed-off-by: Rebecca Cran <rebecca@bsdio.com>
> ---
>  edksetup.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/edksetup.sh b/edksetup.sh
> index ab58fe4a6e..752e47e7cb 100755
> --- a/edksetup.sh
> +++ b/edksetup.sh
> @@ -49,11 +49,11 @@ function SetWorkspace()
>      return 0
>    fi
>  
> -  if [ ! ${BASH_SOURCE[0]} -ef ./edksetup.sh ] && [ -z "$PACKAGES_PATH" ]
> +  if [ ! ${BASH_SOURCE[0]} -ef ./$SCRIPTNAME ] && [ -z "$PACKAGES_PATH" ]
>    then
>      echo Run this script from the base of your tree.  For example:
>      echo "  cd /Path/To/Edk/Root"
> -    echo "  . edksetup.sh"
> +    echo "  . $SCRIPTNAME"
>      return 1
>    fi
>  
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>