From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [207.211.31.81]) by mx.groups.io with SMTP id smtpd.web12.8261.1579511471122235497 for ; Mon, 20 Jan 2020 01:11:11 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=f6wm+ND2; spf=pass (domain: redhat.com, ip: 207.211.31.81, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1579511470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hpt6TbFlxJUTow8OtvU6MEDGligvOuJHOaNlKzG4KgU=; b=f6wm+ND22k/Te2rTEXENhGkeyghYCoTIB3dxeM3byRWWvrQBwcPibGbtnw79G6nI245m1k FG1TMGfoJnkpZpVNtzpy8ECPxG3lOmVWZJVTGq0949jzwE4evNVOG4WGLpJuOdqujO6BRm vO8e8rwaMdaJ3/JkTuaVr/eZie8oSos= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-421-5zvSxWh_Pf6ylVW3is9BtQ-1; Mon, 20 Jan 2020 04:11:08 -0500 Received: by mail-wm1-f69.google.com with SMTP id y125so4140657wmg.1 for ; Mon, 20 Jan 2020 01:11:08 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=TOaMVYly/VddEIUPT6kPT6rHjFiqi+I0C9fXdK4tAx4=; b=pDwZQVjVSOpijJoEDhOkrZCGhd/S6UC76ZfY5uI6BDAVHzajbNBIgfbmcg3ecrHIBB AAdtBuj4ybc8HjPk3wUnjuYvGd2SaK5tDoUO9RqlmLJy9h0YkBE4VEIeJLTOaEYTmXZw //ghIdufkSdfAdXvWt9T0HjtJ/8j2uwdQgimM8KK6zCkIIYG7tXVEqSwdeC6NWIgnt4V LCKLSrR7xohlw4bvWgCV9UawdbREkrCIMiSYPbYMo+TgovLb3VGDDvq9XDPCEimxsOK5 y//ALNdkDTNCLDsAEc6VbzikL1HyH3QU9xzj3IwLlMrL8+3H+DZKqtu2kZZg3o1c4dB+ EZaA== X-Gm-Message-State: APjAAAW65CHLL4kHr6Hx8Z9uUH6Ywx0rJz+iuhDQjkYeW6N1oGcjVlXM bfnssiyFvZviHG5lmNly/5UcdTPITin2Exd+xFFeBvGpL5mRDOv8HhhfH0OdiPg0FcM+R517EF3 e1/pnt4/mmWN7yg== X-Received: by 2002:adf:8541:: with SMTP id 59mr17127238wrh.307.1579511466780; Mon, 20 Jan 2020 01:11:06 -0800 (PST) X-Google-Smtp-Source: APXvYqzNVhqB2yk294qW4fzF0SoRn00q142FStvATI+7eNRK9WdY2m1Metb7TjlncXOmslk/0J58VA== X-Received: by 2002:adf:8541:: with SMTP id 59mr17127203wrh.307.1579511466461; Mon, 20 Jan 2020 01:11:06 -0800 (PST) Return-Path: Received: from [192.168.1.35] (113.red-83-57-172.dynamicip.rima-tde.net. [83.57.172.113]) by smtp.gmail.com with ESMTPSA id o4sm46471568wrw.97.2020.01.20.01.11.05 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2020 01:11:05 -0800 (PST) Subject: Re: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and LF characters in subject length To: "Feng, Bob C" , "devel@edk2.groups.io" Cc: "Gao, Liming" , "Justen, Jordan L" , "Zhu, Yonghong" , "Gao, Zhichao" References: <20200102121656.29572-1-philmd@redhat.com> <08650203BA1BD64D8AD9B6D5D74A85D1615A09AE@SHSMSX104.ccr.corp.intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: <79341b5f-e604-4455-d812-4617ff403a72@redhat.com> Date: Mon, 20 Jan 2020 10:11:04 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <08650203BA1BD64D8AD9B6D5D74A85D1615A09AE@SHSMSX104.ccr.corp.intel.com> X-MC-Unique: 5zvSxWh_Pf6ylVW3is9BtQ-1 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Liming, On 1/9/20 6:35 AM, Feng, Bob C wrote: > Reviewed-by: Bob Feng Is the Review-by tag from Bob enough to get this patch merged? Thanks, Phil. >=20 > -----Original Message----- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Ph= ilippe Mathieu-Daud=C3=A9 > Sent: Thursday, January 2, 2020 8:17 PM > To: devel@edk2.groups.io > Cc: Philippe Mathieu-Daude ; Gao, Liming ; Justen, Jordan L ; Zhu, Yonghong ; Gao, Zhichao > Subject: [edk2-devel] [PATCH v2] BaseTools/PatchCheck.py: Ignore CR and = LF characters in subject length >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D113 >=20 > Strip the trailing characters before checking the subject line is less t= han 72 characters. >=20 > Fixes: e61406708c83f > Cc: Liming Gao > Cc: Jordan Justen > Reviewed-by: Jordan Justen > Signed-off-by: Philippe Mathieu-Daude > --- > Cc: Yonghong Zhu > Cc: Zhichao Gao > v2: Use rstrip() (Jordan Justen) > v1: https://edk2.groups.io/g/devel/message/52425 > --- > BaseTools/Scripts/PatchCheck.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/BaseTools/Scripts/PatchCheck.py b/BaseTools/Scripts/PatchCh= eck.py index 2a4e6f603e79..9668025798da 100755 > --- a/BaseTools/Scripts/PatchCheck.py > +++ b/BaseTools/Scripts/PatchCheck.py > @@ -196,7 +196,7 @@ class CommitMessageCheck: > self.error('Empty commit message!') > return > =20 > - if count >=3D 1 and len(lines[0]) >=3D 72: > + if count >=3D 1 and len(lines[0].rstrip()) >=3D 72: > self.error('First line of commit message (subject line) ' = + > 'is too long.') > =20 > -- > 2.21.0 >=20 >=20 >=20 >=20