From: "Pete Batard" <pete@akeo.ie>
To: Andrei Warkentin <andrey.warkentin@gmail.com>, devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, philmd@redhat.com
Subject: Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again.
Date: Thu, 19 Nov 2020 17:14:40 +0000 [thread overview]
Message-ID: <7947adcb-e711-f52e-087a-096f52d40686@akeo.ie> (raw)
In-Reply-To: <20201119000145.1234-1-andrey.warkentin@gmail.com>
For reference, this breakage was introduced with edk2 commit
https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a
(MdeModulePkg: Connect VariablePolicy business logic to VariableServices).
It'll probably be worth adding a reference to it in the commit message
during integration.
With this:
On 2020.11.19 00:01, Andrei Warkentin wrote:
> Add VariablePolicyLib and its dependency.
>
> Testing: Pi 4 boot.
>
> Signed-off-by: Andrei Warkentin <andrey.warkentin@gmail.com>
> ---
> Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++
> Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++
> 2 files changed, 6 insertions(+)
>
> diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc
> index 325d7bdb..9408138d 100644
> --- a/Platform/RaspberryPi/RPi3/RPi3.dsc
> +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc
> @@ -169,6 +169,8 @@
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
> !endif
> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>
> [LibraryClasses.common.SEC]
> @@ -218,6 +220,7 @@
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
> + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
> diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc
> index c994f56d..4e5a36ed 100644
> --- a/Platform/RaspberryPi/RPi4/RPi4.dsc
> +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc
> @@ -169,6 +169,8 @@
> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf
> !endif
> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf
> + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf
> + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf
> GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf
>
> #
> @@ -226,6 +228,7 @@
> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
> EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf
> ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf
> + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf
>
> !if $(SECURE_BOOT_ENABLE) == TRUE
> BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf
>
Reviewed-by: Pete Batard <pete@akeo.ie>
next prev parent reply other threads:[~2020-11-19 17:14 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-19 0:01 [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again Andrei Warkentin
2020-11-19 17:14 ` Pete Batard [this message]
2020-11-19 17:28 ` Philippe Mathieu-Daudé
2020-11-19 17:33 ` Pete Batard
2020-11-19 19:53 ` [edk2-devel] " Andrei Warkentin
2020-11-20 7:20 ` 回复: " gaoliming
2020-11-20 15:09 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7947adcb-e711-f52e-087a-096f52d40686@akeo.ie \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox