From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f67.google.com (mail-wm1-f67.google.com [209.85.128.67]) by mx.groups.io with SMTP id smtpd.web10.12348.1605806084067682827 for ; Thu, 19 Nov 2020 09:14:44 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@akeo-ie.20150623.gappssmtp.com header.s=20150623 header.b=16LKha08; spf=pass (domain: akeo.ie, ip: 209.85.128.67, mailfrom: pete@akeo.ie) Received: by mail-wm1-f67.google.com with SMTP id h21so7441841wmb.2 for ; Thu, 19 Nov 2020 09:14:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=akeo-ie.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Bl4orBGquqVLmAR7HMQWbr0HXT5EzEqHGB3RTXfitWU=; b=16LKha08AQ/XWgbjAmP6AFhKs1pYN6jtkeimi65m2JazqSpsLOWPTyVo2/KH8bolCO OXrQ7fpch2rheyMrQvhZpYeJvpxGvKrOUCPoTF7ypIHibKMonBZHHW3l4xD5Zc4ar4IK o82hjDX1HdJLe7DgWoAPZ0HEi1TkSHxDzwy4bV0l/0RM2vKhvn7Y620hpfzY46ZCnZAo XYcOlmfNFuC4LHJ3g6zUNrkLA4ffdiDvYQynSLjJNazcIL3nPoMCO0vAzq061zOeuGht 8HHNiQRjBqi/WsEWmzCY5jKLQJorcA/HwL97Ts5GLMrGnJ9KhbhES/ASQOZbF2n1jzit zWwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Bl4orBGquqVLmAR7HMQWbr0HXT5EzEqHGB3RTXfitWU=; b=tiR62X2Ok2411XE5+S56hhZis8yq4oSpZ/ZqXa0eTZwKCUxj6eCFw82oxrAsIll3Ut SnDKQqOMH4dK1Uw3b86UFqEnx7r9/SE21Y3k/DVAuZxkn1C83Rjd6U/rrTt61+JzhC8Z 1/8kEntel1mU8fNZ90/tfOB5JW+Q99Ht/bY1uiQVqTv33bibh2G46MvpFkDnsWsex+xm P2VXmqDmBtimGOq3L0dxa9RiNaOmHvUIcZPPIItrOMJJwQUxu3v7kFbv5firfKC+0jNl lPo3SkfeqyG9lZ3+A7JfcAxmV6bkwRmFOqNlAnIMt/S5BGQ8rq2dyHiOWbkB4/F4yFdJ 8PGA== X-Gm-Message-State: AOAM532sNU8LJv8EDLxyEFxm4sSj6y4ZKiCDeg7rXIfqIP+af0rh/Xyo 6HRJrh+z+/XJUT3INBb6DPvTgA== X-Google-Smtp-Source: ABdhPJx6KKRCOdScdCmu+BKHKF1u4cP+1doSjY2uLaLMAeQ9y/f/s52Q6IKNqsnOpgyn33rzcNF3jA== X-Received: by 2002:a1c:7418:: with SMTP id p24mr5528462wmc.36.1605806082508; Thu, 19 Nov 2020 09:14:42 -0800 (PST) Return-Path: Received: from [10.0.0.122] ([84.203.82.97]) by smtp.googlemail.com with ESMTPSA id e6sm771771wme.27.2020.11.19.09.14.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Nov 2020 09:14:41 -0800 (PST) Subject: Re: [edk2-platforms][PATCH 1/1] RaspberryPi: get RPi4 and RPi3 building again. To: Andrei Warkentin , devel@edk2.groups.io Cc: ard.biesheuvel@arm.com, leif@nuviainc.com, philmd@redhat.com References: <20201119000145.1234-1-andrey.warkentin@gmail.com> From: "Pete Batard" Message-ID: <7947adcb-e711-f52e-087a-096f52d40686@akeo.ie> Date: Thu, 19 Nov 2020 17:14:40 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201119000145.1234-1-andrey.warkentin@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit For reference, this breakage was introduced with edk2 commit https://github.com/tianocore/edk2/commit/b6490426e3208de7d6cbd756276a02e4329cd85a (MdeModulePkg: Connect VariablePolicy business logic to VariableServices). It'll probably be worth adding a reference to it in the commit message during integration. With this: On 2020.11.19 00:01, Andrei Warkentin wrote: > Add VariablePolicyLib and its dependency. > > Testing: Pi 4 boot. > > Signed-off-by: Andrei Warkentin > --- > Platform/RaspberryPi/RPi3/RPi3.dsc | 3 +++ > Platform/RaspberryPi/RPi4/RPi4.dsc | 3 +++ > 2 files changed, 6 insertions(+) > > diff --git a/Platform/RaspberryPi/RPi3/RPi3.dsc b/Platform/RaspberryPi/RPi3/RPi3.dsc > index 325d7bdb..9408138d 100644 > --- a/Platform/RaspberryPi/RPi3/RPi3.dsc > +++ b/Platform/RaspberryPi/RPi3/RPi3.dsc > @@ -169,6 +169,8 @@ > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf > > [LibraryClasses.common.SEC] > @@ -218,6 +220,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > diff --git a/Platform/RaspberryPi/RPi4/RPi4.dsc b/Platform/RaspberryPi/RPi4/RPi4.dsc > index c994f56d..4e5a36ed 100644 > --- a/Platform/RaspberryPi/RPi4/RPi4.dsc > +++ b/Platform/RaspberryPi/RPi4/RPi4.dsc > @@ -169,6 +169,8 @@ > AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf > !endif > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLib.inf > + VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/VariablePolicyHelperLib.inf > GpioLib|Silicon/Broadcom/Bcm283x/Library/GpioLib/GpioLib.inf > > # > @@ -226,6 +228,7 @@ > CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > EfiResetSystemLib|Platform/RaspberryPi/Library/ResetLib/ResetLib.inf > ArmSmcLib|ArmPkg/Library/ArmSmcLib/ArmSmcLib.inf > + VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLibRuntimeDxe.inf > > !if $(SECURE_BOOT_ENABLE) == TRUE > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/RuntimeCryptLib.inf > Reviewed-by: Pete Batard