From: "PierreGondois" <pierre.gondois@arm.com>
To: Sami Mujawar <sami.mujawar@arm.com>, devel@edk2.groups.io
Cc: ardb+tianocore@kernel.org, quic_llindhol@quicinc.com,
michael.d.kinney@intel.com, gaoliming@byosoft.com.cn,
zhiguang.liu@intel.com, zhichao.gao@intel.com,
Anshuman.Khandual@arm.com, Matteo.Carlini@arm.com,
Akanksha.Jain2@arm.com, Sibel.Allinson@arm.com,
jeshuas@nvidia.com, nd@arm.com
Subject: Re: [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support
Date: Fri, 22 Sep 2023 16:50:58 +0200 [thread overview]
Message-ID: <794c2b6e-2ab8-30ff-ec43-7cf281fe8968@arm.com> (raw)
In-Reply-To: <20230922143516.4764-1-sami.mujawar@arm.com>
Hi Sami,
Thanks for the update:
Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
Regards,
Pierre
On 9/22/23 16:35, Sami Mujawar wrote:
> This patch series provides the following updates:
> - The patches 1 & 2 add the new fields introduced
> in MADT (APIC table) by ACPI 6.5 and the patch
> 7/11 updates the Acpiview MADT parser accordingly.
> - The patches 3, 4 & 5 adds TRBE support to the MADT
> table generator in DynamicTablesPkg.
> - Patch 6/11 updates the FADT ACPI revision to 6.5.
> - The patches 8, 9 & 10 add support to generate ETE
> device nodes.
> - The 3rd last last patch series fixes a bug wherein
> the CPC token was incorrectly referenced.
> - The last 2 patches in the series introduce helper
> functions to detect if TRBE and ETE features are
> supported.
>
> Updates from v2 patch series:
> - Updated patch 5 to removed superfluous initialisation
> of TRBE interrupt field for ACPI 6.4.
> - Patch 12/13 introduces a helper function in ArmLib to
> detect if TRBE is supported.
> - Patch 13/13 introduces a helper function in ArmLib to
> detect if ETE is supported.
>
> Updates from v1 patch series:
> - Fixed issue with setting TRBE interrupt in patch 5/11.
>
> The changes can be seen at:
> https://github.com/samimujawar/edk2/tree/2620_ete_dev_fvp_v3
>
> Sami Mujawar (13):
> MdePkg: MADT: Add Online capable flag in GICC
> MdePkg: MADT: Add TRBE interrupt to GICC
> DynamicTablesPkg: Add TRBE interrupt to GICC object
> DynamicTablesPkg: Add TRBE interrupt to GICC object parser
> DynamicTablesPkg: Update MADT generator for ACPI 6.5
> DynamicTablesPkg: Update FADT generator to ACPI 6.5
> ShellPkg: Acpiview: Update MADT parser for TRBE interrupt
> DynamicTablesPkg: Add an ET info object to Arm namespace
> DynamicTablesPkg: Add an ET info object parser
> DynamicTablesPkg: Add ETE device to CPU node in AML
> DynamicTablesPkg: Fix referencing of CPC token
> ArmPkg/ArmLib: Add ArmHasTrbe () helper function
> ArmPkg/ArmLib: Add ArmHasEte () helper function
>
> ArmPkg/Include/Chipset/AArch64.h | 4 +
> ArmPkg/Include/Library/ArmLib.h | 25 +++
> ArmPkg/Library/ArmLib/AArch64/AArch64Lib.c | 31 ++++
> DynamicTablesPkg/Include/ArmNameSpaceObjects.h | 32 +++-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 108 +++++------
> DynamicTablesPkg/Library/Acpi/Arm/AcpiMadtLibArm/MadtGenerator.c | 79 ++++----
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.c | 188 +++++++++++++++++++-
> DynamicTablesPkg/Library/Acpi/Arm/AcpiSsdtCpuTopologyLibArm/SsdtCpuTopologyGenerator.h | 11 +-
> DynamicTablesPkg/Library/Common/TableHelperLib/ConfigurationManagerObjectParser.c | 11 +-
> MdePkg/Include/IndustryStandard/Acpi65.h | 4 +-
> ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Madt/MadtParser.c | 48 ++++-
> 11 files changed, 442 insertions(+), 99 deletions(-)
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109012): https://edk2.groups.io/g/devel/message/109012
Mute This Topic: https://groups.io/mt/101522262/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-
next prev parent reply other threads:[~2023-09-22 14:51 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-22 14:35 [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 01/13] MdePkg: MADT: Add Online capable flag in GICC Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 02/13] MdePkg: MADT: Add TRBE interrupt to GICC Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 03/13] DynamicTablesPkg: Add TRBE interrupt to GICC object Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 04/13] DynamicTablesPkg: Add TRBE interrupt to GICC object parser Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 05/13] DynamicTablesPkg: Update MADT generator for ACPI 6.5 Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 06/13] DynamicTablesPkg: Update FADT generator to " Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 07/13] ShellPkg: Acpiview: Update MADT parser for TRBE interrupt Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 08/13] DynamicTablesPkg: Add an ET info object to Arm namespace Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 09/13] DynamicTablesPkg: Add an ET info object parser Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 10/13] DynamicTablesPkg: Add ETE device to CPU node in AML Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 11/13] DynamicTablesPkg: Fix referencing of CPC token Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 12/13] ArmPkg/ArmLib: Add ArmHasTrbe () helper function Sami Mujawar
2023-09-22 14:35 ` [edk2-devel] [PATCH v3 13/13] ArmPkg/ArmLib: Add ArmHasEte " Sami Mujawar
2023-09-22 14:50 ` PierreGondois [this message]
2023-10-23 15:30 ` [edk2-devel] [PATCH v3 00/11] Update MADT for ACPI 6.5, and add TRBE & ETE support Jeshua Smith via groups.io
2023-10-24 8:43 ` Sami Mujawar
2023-10-26 9:08 ` Gao, Zhichao
2023-10-30 14:16 ` Sami Mujawar
2023-09-22 16:19 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=794c2b6e-2ab8-30ff-ec43-7cf281fe8968@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox