From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6FF487803CC for ; Thu, 5 Sep 2024 01:03:03 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=mD6LEDeIWLzApZJbmQdh0nT558YREN6fu9ctnztoD1w=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1725498183; v=1; x=1725757381; b=rzSq3Xwan2rWYGef6ZzXfw60dvMF65LMVZS9Qvt3PX71nHY7Ijs0zHUuYlPzFEd5N8amZ7HG AoBAo7W0B9TQZ3sTgbPgHWiJCjVGqnoQpbZmW7U1J5UoSCGOVfZdUDv5URiVEbuay/6UBJhWZCo vjHV14atfEPTvpykck56zPQSsWLT/qgVFyjY04SspjYAl8OpGiwZ9m26UFF2KoWH0DUQzAG7KUv gxMcZ/ccHhERGMtgbrUVrgniaqhyccmVW0LwTqIqpThVr9haS/4MqJ6eq1PdwjF0ILQAwcZHUBR hr7frZJaXs04Tzzls9JbSI2ceHfZ1m/bxrA3oIX0tI55w== X-Received: by 127.0.0.2 with SMTP id ViTzYY7687511xSHOz7vD05S; Wed, 04 Sep 2024 18:03:01 -0700 X-Received: from fhigh8-smtp.messagingengine.com (fhigh8-smtp.messagingengine.com [103.168.172.159]) by mx.groups.io with SMTP id smtpd.web11.650.1725498180621118186 for ; Wed, 04 Sep 2024 18:03:00 -0700 X-Received: from phl-compute-03.internal (phl-compute-03.phl.internal [10.202.2.43]) by mailfhigh.phl.internal (Postfix) with ESMTP id C179011401B0; Wed, 4 Sep 2024 21:02:59 -0400 (EDT) X-Received: from phl-mailfrontend-02 ([10.202.2.163]) by phl-compute-03.internal (MEProxy); Wed, 04 Sep 2024 21:02:59 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudehkedggedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdggtfgfnhhsuhgsshgtrhhisggvpdfu rfetoffkrfgpnffqhgenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnh htshculddquddttddmnegoufhushhpvggtthffohhmrghinhculdegledmnecujfgurhep kfffgggfuffvvehfhfgjtgfgsehtjeertddtvdejnecuhfhrohhmpeftvggsvggttggruc evrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrghtthgvrhhn pedufeekvddtheelvdejveefvdetheetfeefveefleehjeekueevteevveeujeegffenuc ffohhmrghinhepthhirghnohgtohhrvgdrohhrghdpghhithhhuhgsrdgtohhmpdhrvggr ughmvgdrmhgupdhgihhthhhusgdrihhopdhgrhhouhhpshdrihhonecuvehluhhsthgvrh fuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprhgvsggvtggtrgessghsughi ohdrtghomhdpnhgspghrtghpthhtohepfedpmhhouggvpehsmhhtphhouhhtpdhrtghpth htohepnhdrjhgrhigrphhrrghkrghshhesihhnthgvlhdrtghomhdprhgtphhtthhopegu vghvvghlsegvughkvddrghhrohhuphhsrdhiohdprhgtphhtthhopehmihgthhgrvghlrd gurdhkihhnnhgvhiesihhnthgvlhdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 4 Sep 2024 21:02:59 -0400 (EDT) Message-ID: <797a4f24-de91-4623-b600-fe4eb9de9baf@bsdio.com> Date: Wed, 4 Sep 2024 19:02:47 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-libc Patch 1/1] edk2-libc: Move to github pull request workflow To: Jayaprakash N , devel@edk2.groups.io Cc: Michael D Kinney References: <20240904152147.1424-1-n.jayaprakash@intel.com> <20240904152147.1424-2-n.jayaprakash@intel.com> From: "Rebecca Cran" In-Reply-To: <20240904152147.1424-2-n.jayaprakash@intel.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 04 Sep 2024 18:03:00 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 5jeJ4w3TdpYZHvU9s9q62UPMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=rzSq3Xwa; dmarc=none; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Reviewed-by: Rebecca Cran --=20 Rebecca On 9/4/24 9:20 AM, Jayaprakash N wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D4840 > > Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS > and CONTRIBUTORS.md. The latter file contains mappings from name to > email address and GitHub usernames, which will help people who want > to email maintainers instead of using GitHub. > > Add .github/workflows/AssignReviewers.yml which adds reviewers to a > Pull Request based on the content of the CODEOWNERS file. > > Cc: Rebecca Cran > Cc: Michael D Kinney > Cc: Jayaprakash N > Signed-off-by: Jayaprakash N > --- > .github/workflows/AssignReviewers.yaml | 34 ++++++++++++ > CODEOWNERS | 21 ++++++++ > CONTRIBUTORS.md | 13 +++++ > Maintainers.txt | 71 -------------------------- > 4 files changed, 68 insertions(+), 71 deletions(-) > create mode 100644 .github/workflows/AssignReviewers.yaml > create mode 100644 CODEOWNERS > create mode 100644 CONTRIBUTORS.md > delete mode 100644 Maintainers.txt > > diff --git a/.github/workflows/AssignReviewers.yaml b/.github/workflows/A= ssignReviewers.yaml > new file mode 100644 > index 0000000..4d0779e > --- /dev/null > +++ b/.github/workflows/AssignReviewers.yaml > @@ -0,0 +1,34 @@ > +## @file > +# Assign reviewers from a REVIEWERS file using CODEOWNERS syntax > +# > +# Copyright (c) 2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +name: Assign reviewers from a REVIEWERS file using CODEOWNERS syntax > + > +on: > + pull_request_target: > + types: [opened, synchronize, reopened, ready_for_review] > + branches: > + - master > + > +jobs: > + assign_reviewers: > + if: github.event.pull_request.draft =3D=3D false > + runs-on: ubuntu-latest > + permissions: > + pull-requests: write > + steps: > + - name: Generate Token > + id: generate-token > + uses: actions/create-github-app-token@v1 > + with: > + app-id: ${{ secrets.TIANOCORE_ASSIGN_REVIEWERS_APPLICATION_ID = }} > + private-key: ${{ secrets.TIANOCORE_ASSIGN_REVIEWERS_APPLICATIO= N_PRIVATE_KEY }} > + - name: Checkout Pull Request Target > + uses: actions/checkout@v2 > + - name: Assign Reviewers > + uses: mdkinney/github-action-assign-reviewers@main > + with: > + token: ${{ steps.generate-token.outputs.token }} > \ No newline at end of file > diff --git a/CODEOWNERS b/CODEOWNERS > new file mode 100644 > index 0000000..f171244 > --- /dev/null > +++ b/CODEOWNERS > @@ -0,0 +1,21 @@ > +## @file > +# This file contains the code owners of edk2-libc repo > +# > +# Copyright (c) 2024, Intel Corporation. All rights reserved.
> +# SPDX-License-Identifier: BSD-2-Clause-Patent > +## > + > +# This file contains the list of maintainers (i.e. people who own the > +# areas and can commit changes) for various parts of edk2-libc. > + > +# EDK II Platforms maintainers > +# =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D > + > +* @mdkinney @bcran @jpshivakavi > + > +# AppPkg owners > +AppPkg/** @mdkinney @jpshivakavi @bcran > + > +# StdLib and StdLibPrivateInternalFiles owners > +StdLib/** @mdkinney @jpshivakavi @bcran > +StdLibPrivateInternalFiles/** @mdkinney @jpshivakavi @bcran > diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md > new file mode 100644 > index 0000000..5173898 > --- /dev/null > +++ b/CONTRIBUTORS.md > @@ -0,0 +1,13 @@ > +EDK II Libc Maintainers and Reviewers > +=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > + > +This file is intended to provide an easy way to look up people's names a= nd email addresses given their GitHub usernames from the CODEOWNERS / REVIE= WERS files. > + > +Since it's an extra file to remember to update when changing maintainers= or reviewers, it will likely become out-of-sync with CODEOWNERS and/or REV= IEWERS over time and need an occasional refresh. > + > + > +| Name | e-mail address | Githubusername = | > +|----------------------|-------------------------------|----------------= ---------------------------------| > +| Rebecca Cran | rebecca@bsdio.com | [@bcran](https:= //github.com/bcran) | > +| Michael D Kinney | michael.d.kinney@intel.com | [@mdkinney](htt= ps://github.com/mdkinney) | > +| Jayaprakash Nevara | n.jayaprakash@intel.com | [@jpshivakavi](= https://github.com/jpshivakavi) | > diff --git a/Maintainers.txt b/Maintainers.txt > deleted file mode 100644 > index 8a98987..0000000 > --- a/Maintainers.txt > +++ /dev/null > @@ -1,71 +0,0 @@ > -EDK II LIBC Project Maintainers > -=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D > - > -This file provides information about the primary maintainers for the EDK= II LIBC > -Project. This repository was exported from the edk2 repository and depe= nds > -on the edk2 repository. The following are the links to the edk2 reposit= ory: > - > - https://github.com/tianocore/edk2 > - https://github.com/tianocore/edk2/blob/master/Readme.md > - https://github.com/tianocore/edk2/blob/master/Maintainers.txt > - > -In general, you should not privately email the maintainer. You should > -email the edk2-devel list, and Cc the package maintainers and > -reviewers. > - > -If the package maintainer wants to hand over the role to other people, > -the package maintainer should send the patch to update Maintainers.txt > -with new maintainer, and the new maintainer should follow up with > -an Acked-by or a Reviewed-by. > - > -Descriptions of section entries: > - > - L: Mailing list that is relevant to this area (default is edk2-devel) > - Patches and questions should be sent to the email list. > - M: Package Maintainer: Cc address for patches and questions. Responsib= le > - for reviewing and pushing package changes to source control. > - R: Package Reviewer: Cc address for patches and questions. Reviewers h= elp > - maintainers review code, but don't have push access. A designated P= ackage > - Reviewer is reasonably familiar with the Package (or some modules > - thereof), and/or provides testing or regression testing for the Pac= kage > - (or some modules thereof), in certain platforms and environments. > - W: Web-page with status/info > - T: SCM tree type and location. Type is one of: git, svn. > - S: Status, one of the following: > - Supported: Someone is actually paid to look after this. > - Maintained: Someone actually looks after it. > - Odd Fixes: It has a maintainer but they don't have time to do > - much other than throw the odd patch in. See below. > - Orphan: No current maintainer [but maybe you could take the > - role as you write your new code]. > - Obsolete: Old code. Something tagged obsolete generally means > - it has been replaced by a better system and you > - should be using that. > - > -EDK II LIBC Project > -------------------- > -W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II > -L: https://edk2.groups.io/g/devel > -T: git - https://github.com/tianocore/edk2-libc.git > - > -Responsible Disclosure, Reporting Security Issues > -------------------------------------------------- > -TBD > - > -EDK II Releases: > ----------------- > -TBD > - > -EDK II Packages: > ----------------- > -AppPkg > -W: https://github.com/tianocore/tianocore.github.io/wiki/AppPkg > -M: Rebecca Cran > -M: Michael D Kinney > -M: Jayaprakash N > - > -StdLib, StdLibPrivateInternalFiles > -W: https://github.com/tianocore/tianocore.github.io/wiki/StdLib > -M: Rebecca Cran > -M: Michael D Kinney > -M: Jayaprakash N -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120510): https://edk2.groups.io/g/devel/message/120510 Mute This Topic: https://groups.io/mt/108267102/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-