public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description
       [not found] <cover.1703749992.git.junfengx.guan@intel.com>
@ 2023-12-28  7:53 ` Junfeng Guan
  2024-01-10  6:18   ` 回复: " gaoliming via groups.io
  0 siblings, 1 reply; 4+ messages in thread
From: Junfeng Guan @ 2023-12-28  7:53 UTC (permalink / raw)
  To: devel; +Cc: Michael D Kinney, Liming Gao, Zhiguang Liu, Yi Li

Refer to Uefi spec 2.10 section 11.10.2, update the return value
for EFI_DRIVER_HEALTH_PROTOCOL.GetHealthStatus.

Signed-off-by: Junfeng Guan <junfengx.guan@intel.com>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
Cc: Liming Gao <gaoliming@byosoft.com.cn>
Cc: Zhiguang Liu <zhiguang.liu@intel.com>
Cc: Yi Li <yi1.li@intel.com>
---
 MdePkg/Include/Protocol/DriverHealth.h | 32 +++++++-------------------
 1 file changed, 8 insertions(+), 24 deletions(-)

diff --git a/MdePkg/Include/Protocol/DriverHealth.h b/MdePkg/Include/Protocol/DriverHealth.h
index 9de025434ef3..9e1bd903f4be 100644
--- a/MdePkg/Include/Protocol/DriverHealth.h
+++ b/MdePkg/Include/Protocol/DriverHealth.h
@@ -137,35 +137,19 @@ EFI_STATUS
                               will only be returned with a HealthStatus value of
                               EfiDriverHealthStatusConfigurationRequired.
 
-  @retval EFI_SUCCESS           ControllerHandle is NULL, and all the controllers
-                                managed by this driver specified by This have a health
-                                status of EfiDriverHealthStatusHealthy with no warning
-                                messages to be returned.  The ChildHandle, HealthStatus,
-                                MessageList, and FormList parameters are ignored.
-
-  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one or more of the
-                                controllers managed by this driver specified by This
-                                do not have a health status of EfiDriverHealthStatusHealthy.
-                                The ChildHandle, HealthStatus, MessageList, and
-                                FormList parameters are ignored.
-
-  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one or more of the
-                                controllers managed by this driver specified by This
-                                have one or more warning and/or error messages.
-                                The ChildHandle, HealthStatus, MessageList, and
-                                FormList parameters are ignored.
-
-  @retval EFI_SUCCESS           ControllerHandle is not NULL and the health status
-                                of the controller specified by ControllerHandle and
-                                ChildHandle was returned in HealthStatus.  A list
-                                of warning and error messages may be optionally
-                                returned in MessageList, and a list of HII Forms
-                                may be optionally returned in FormList.
+  @retval EFI_SUCCESS           The health status of the controller specified by
+                                ControllerHandle and ChildHandle was returned in HealthStatus.
+                                A list of warning and error messages may be optionally
+                                returned in MessageList, and an HII Form may be optionally
+                                specified by FormHiiHandle.
 
   @retval EFI_UNSUPPORTED       ControllerHandle is not NULL, and the controller
                                 specified by ControllerHandle and ChildHandle is not
                                 currently being managed by the driver specified by This.
 
+  @retval EFI_UNSUPPORTED       ControllerHandle is NULL and there are no devices being
+                                managed by the driver.
+
   @retval EFI_INVALID_PARAMETER HealthStatus is NULL.
 
   @retval EFI_OUT_OF_RESOURCES  MessageList is not NULL, and there are not enough
-- 
2.26.2.windows.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112943): https://edk2.groups.io/g/devel/message/112943
Mute This Topic: https://groups.io/mt/103397828/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply related	[flat|nested] 4+ messages in thread

* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description
  2023-12-28  7:53 ` [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description Junfeng Guan
@ 2024-01-10  6:18   ` gaoliming via groups.io
  2024-01-11  1:14     ` Junfeng Guan
  0 siblings, 1 reply; 4+ messages in thread
From: gaoliming via groups.io @ 2024-01-10  6:18 UTC (permalink / raw)
  To: devel, junfengx.guan
  Cc: 'Michael D Kinney', 'Zhiguang Liu',
	'Yi Li'

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan
> 发送时间: 2023年12月28日 15:54
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi Li
> <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function
> description
> 
> Refer to Uefi spec 2.10 section 11.10.2, update the return value
> for EFI_DRIVER_HEALTH_PROTOCOL.GetHealthStatus.
> 
> Signed-off-by: Junfeng Guan <junfengx.guan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/DriverHealth.h | 32 +++++++-------------------
>  1 file changed, 8 insertions(+), 24 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/DriverHealth.h
> b/MdePkg/Include/Protocol/DriverHealth.h
> index 9de025434ef3..9e1bd903f4be 100644
> --- a/MdePkg/Include/Protocol/DriverHealth.h
> +++ b/MdePkg/Include/Protocol/DriverHealth.h
> @@ -137,35 +137,19 @@ EFI_STATUS
>                                will only be returned with a
> HealthStatus value of
> 
> EfiDriverHealthStatusConfigurationRequired.
> 
> -  @retval EFI_SUCCESS           ControllerHandle is NULL, and all the
> controllers
> -                                managed by this driver specified by
> This have a health
> -                                status of
> EfiDriverHealthStatusHealthy with no warning
> -                                messages to be returned.  The
> ChildHandle, HealthStatus,
> -                                MessageList, and FormList
> parameters are ignored.
> -
> -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one or
> more of the
> -                                controllers managed by this driver
> specified by This
> -                                do not have a health status of
> EfiDriverHealthStatusHealthy.
> -                                The ChildHandle, HealthStatus,
> MessageList, and
> -                                FormList parameters are ignored.
> -
> -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one or
> more of the
> -                                controllers managed by this driver
> specified by This
> -                                have one or more warning and/or
> error messages.
> -                                The ChildHandle, HealthStatus,
> MessageList, and
> -                                FormList parameters are ignored.
> -
> -  @retval EFI_SUCCESS           ControllerHandle is not NULL and the
> health status
> -                                of the controller specified by
> ControllerHandle and
> -                                ChildHandle was returned in
> HealthStatus.  A list
> -                                of warning and error messages may
> be optionally
> -                                returned in MessageList, and a list of
> HII Forms
> -                                may be optionally returned in
> FormList.
> +  @retval EFI_SUCCESS           The health status of the controller
> specified by
> +                                ControllerHandle and ChildHandle
> was returned in HealthStatus.
> +                                A list of warning and error messages
> may be optionally
> +                                returned in MessageList, and an HII
> Form may be optionally
> +                                specified by FormHiiHandle.
> 
>    @retval EFI_UNSUPPORTED       ControllerHandle is not NULL, and
> the controller
>                                  specified by ControllerHandle and
> ChildHandle is not
>                                  currently being managed by the
> driver specified by This.
> 
> +  @retval EFI_UNSUPPORTED       ControllerHandle is NULL and there
> are no devices being
> +                                managed by the driver.
> +
>    @retval EFI_INVALID_PARAMETER HealthStatus is NULL.
> 
>    @retval EFI_OUT_OF_RESOURCES  MessageList is not NULL, and there
> are not enough
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113515): https://edk2.groups.io/g/devel/message/113515
Mute This Topic: https://groups.io/mt/103636712/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description
  2024-01-10  6:18   ` 回复: " gaoliming via groups.io
@ 2024-01-11  1:14     ` Junfeng Guan
  2024-01-11  2:20       ` 回复: " gaoliming via groups.io
  0 siblings, 1 reply; 4+ messages in thread
From: Junfeng Guan @ 2024-01-11  1:14 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io
  Cc: Kinney, Michael D, Liu, Zhiguang, Li, Yi1

Hi Liming,
   Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5248
   Could you help push it?

B.R.
Junfeng
-----Original Message-----
From: gaoliming <gaoliming@byosoft.com.cn> 
Sent: Wednesday, January 10, 2024 2:19 PM
To: devel@edk2.groups.io; Guan, JunfengX <junfengx.guan@intel.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description

Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>

> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan
> 发送时间: 2023年12月28日 15:54
> 收件人: devel@edk2.groups.io
> 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao 
> <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi 
> Li <yi1.li@intel.com>
> 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function 
> description
> 
> Refer to Uefi spec 2.10 section 11.10.2, update the return value for 
> EFI_DRIVER_HEALTH_PROTOCOL.GetHealthStatus.
> 
> Signed-off-by: Junfeng Guan <junfengx.guan@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> Cc: Yi Li <yi1.li@intel.com>
> ---
>  MdePkg/Include/Protocol/DriverHealth.h | 32 
> +++++++-------------------
>  1 file changed, 8 insertions(+), 24 deletions(-)
> 
> diff --git a/MdePkg/Include/Protocol/DriverHealth.h
> b/MdePkg/Include/Protocol/DriverHealth.h
> index 9de025434ef3..9e1bd903f4be 100644
> --- a/MdePkg/Include/Protocol/DriverHealth.h
> +++ b/MdePkg/Include/Protocol/DriverHealth.h
> @@ -137,35 +137,19 @@ EFI_STATUS
>                                will only be returned with a 
> HealthStatus value of
> 
> EfiDriverHealthStatusConfigurationRequired.
> 
> -  @retval EFI_SUCCESS           ControllerHandle is NULL, and all the
> controllers
> -                                managed by this driver specified by
> This have a health
> -                                status of
> EfiDriverHealthStatusHealthy with no warning
> -                                messages to be returned.  The
> ChildHandle, HealthStatus,
> -                                MessageList, and FormList
> parameters are ignored.
> -
> -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one or
> more of the
> -                                controllers managed by this driver
> specified by This
> -                                do not have a health status of
> EfiDriverHealthStatusHealthy.
> -                                The ChildHandle, HealthStatus,
> MessageList, and
> -                                FormList parameters are ignored.
> -
> -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one or
> more of the
> -                                controllers managed by this driver
> specified by This
> -                                have one or more warning and/or
> error messages.
> -                                The ChildHandle, HealthStatus,
> MessageList, and
> -                                FormList parameters are ignored.
> -
> -  @retval EFI_SUCCESS           ControllerHandle is not NULL and the
> health status
> -                                of the controller specified by
> ControllerHandle and
> -                                ChildHandle was returned in
> HealthStatus.  A list
> -                                of warning and error messages may
> be optionally
> -                                returned in MessageList, and a list of
> HII Forms
> -                                may be optionally returned in
> FormList.
> +  @retval EFI_SUCCESS           The health status of the controller
> specified by
> +                                ControllerHandle and ChildHandle
> was returned in HealthStatus.
> +                                A list of warning and error messages
> may be optionally
> +                                returned in MessageList, and an HII
> Form may be optionally
> +                                specified by FormHiiHandle.
> 
>    @retval EFI_UNSUPPORTED       ControllerHandle is not NULL, and
> the controller
>                                  specified by ControllerHandle and 
> ChildHandle is not
>                                  currently being managed by the driver 
> specified by This.
> 
> +  @retval EFI_UNSUPPORTED       ControllerHandle is NULL and there
> are no devices being
> +                                managed by the driver.
> +
>    @retval EFI_INVALID_PARAMETER HealthStatus is NULL.
> 
>    @retval EFI_OUT_OF_RESOURCES  MessageList is not NULL, and there 
> are not enough
> --
> 2.26.2.windows.1
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113565): https://edk2.groups.io/g/devel/message/113565
Mute This Topic: https://groups.io/mt/103654442/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

* 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description
  2024-01-11  1:14     ` Junfeng Guan
@ 2024-01-11  2:20       ` gaoliming via groups.io
  0 siblings, 0 replies; 4+ messages in thread
From: gaoliming via groups.io @ 2024-01-11  2:20 UTC (permalink / raw)
  To: devel, junfengx.guan
  Cc: 'Kinney, Michael D', 'Liu, Zhiguang',
	'Li, Yi1'

Junfeng:
  I add push label for this PR.

Thanks
Liming
> -----邮件原件-----
> 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng Guan
> 发送时间: 2024年1月11日 9:14
> 收件人: Gao, Liming <gaoliming@byosoft.com.cn>; devel@edk2.groups.io
> 抄送: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> 主题: Re: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus
> function description
> 
> Hi Liming,
>    Thanks! I created a PR: https://github.com/tianocore/edk2/pull/5248
>    Could you help push it?
> 
> B.R.
> Junfeng
> -----Original Message-----
> From: gaoliming <gaoliming@byosoft.com.cn>
> Sent: Wednesday, January 10, 2024 2:19 PM
> To: devel@edk2.groups.io; Guan, JunfengX <junfengx.guan@intel.com>
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Liu, Zhiguang
> <zhiguang.liu@intel.com>; Li, Yi1 <yi1.li@intel.com>
> Subject: 回复: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus
> function description
> 
> Reviewed-by: Liming Gao <gaoliming@byosoft.com.cn>
> 
> > -----邮件原件-----
> > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Junfeng
> Guan
> > 发送时间: 2023年12月28日 15:54
> > 收件人: devel@edk2.groups.io
> > 抄送: Michael D Kinney <michael.d.kinney@intel.com>; Liming Gao
> > <gaoliming@byosoft.com.cn>; Zhiguang Liu <zhiguang.liu@intel.com>; Yi
> > Li <yi1.li@intel.com>
> > 主题: [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function
> > description
> >
> > Refer to Uefi spec 2.10 section 11.10.2, update the return value for
> > EFI_DRIVER_HEALTH_PROTOCOL.GetHealthStatus.
> >
> > Signed-off-by: Junfeng Guan <junfengx.guan@intel.com>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > Cc: Liming Gao <gaoliming@byosoft.com.cn>
> > Cc: Zhiguang Liu <zhiguang.liu@intel.com>
> > Cc: Yi Li <yi1.li@intel.com>
> > ---
> >  MdePkg/Include/Protocol/DriverHealth.h | 32
> > +++++++-------------------
> >  1 file changed, 8 insertions(+), 24 deletions(-)
> >
> > diff --git a/MdePkg/Include/Protocol/DriverHealth.h
> > b/MdePkg/Include/Protocol/DriverHealth.h
> > index 9de025434ef3..9e1bd903f4be 100644
> > --- a/MdePkg/Include/Protocol/DriverHealth.h
> > +++ b/MdePkg/Include/Protocol/DriverHealth.h
> > @@ -137,35 +137,19 @@ EFI_STATUS
> >                                will only be returned with a
> > HealthStatus value of
> >
> > EfiDriverHealthStatusConfigurationRequired.
> >
> > -  @retval EFI_SUCCESS           ControllerHandle is NULL, and all the
> > controllers
> > -                                managed by this driver specified by
> > This have a health
> > -                                status of
> > EfiDriverHealthStatusHealthy with no warning
> > -                                messages to be returned.  The
> > ChildHandle, HealthStatus,
> > -                                MessageList, and FormList
> > parameters are ignored.
> > -
> > -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one
> or
> > more of the
> > -                                controllers managed by this driver
> > specified by This
> > -                                do not have a health status of
> > EfiDriverHealthStatusHealthy.
> > -                                The ChildHandle, HealthStatus,
> > MessageList, and
> > -                                FormList parameters are ignored.
> > -
> > -  @retval EFI_DEVICE_ERROR      ControllerHandle is NULL, and one
> or
> > more of the
> > -                                controllers managed by this driver
> > specified by This
> > -                                have one or more warning and/or
> > error messages.
> > -                                The ChildHandle, HealthStatus,
> > MessageList, and
> > -                                FormList parameters are ignored.
> > -
> > -  @retval EFI_SUCCESS           ControllerHandle is not NULL and
> the
> > health status
> > -                                of the controller specified by
> > ControllerHandle and
> > -                                ChildHandle was returned in
> > HealthStatus.  A list
> > -                                of warning and error messages
> may
> > be optionally
> > -                                returned in MessageList, and a list
> of
> > HII Forms
> > -                                may be optionally returned in
> > FormList.
> > +  @retval EFI_SUCCESS           The health status of the controller
> > specified by
> > +                                ControllerHandle and ChildHandle
> > was returned in HealthStatus.
> > +                                A list of warning and error
> messages
> > may be optionally
> > +                                returned in MessageList, and an
> HII
> > Form may be optionally
> > +                                specified by FormHiiHandle.
> >
> >    @retval EFI_UNSUPPORTED       ControllerHandle is not NULL, and
> > the controller
> >                                  specified by ControllerHandle and
> > ChildHandle is not
> >                                  currently being managed by the
> driver
> > specified by This.
> >
> > +  @retval EFI_UNSUPPORTED       ControllerHandle is NULL and
> there
> > are no devices being
> > +                                managed by the driver.
> > +
> >    @retval EFI_INVALID_PARAMETER HealthStatus is NULL.
> >
> >    @retval EFI_OUT_OF_RESOURCES  MessageList is not NULL, and
> there
> > are not enough
> > --
> > 2.26.2.windows.1
> >
> >
> >
> >
> >
> 
> 
> 
> 
> 
> 
> 





-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#113573): https://edk2.groups.io/g/devel/message/113573
Mute This Topic: https://groups.io/mt/103655535/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2024-01-11  2:20 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <cover.1703749992.git.junfengx.guan@intel.com>
2023-12-28  7:53 ` [edk2-devel] [PATCH 1/1] MdePkg: Update GetHealthStatus function description Junfeng Guan
2024-01-10  6:18   ` 回复: " gaoliming via groups.io
2024-01-11  1:14     ` Junfeng Guan
2024-01-11  2:20       ` 回复: " gaoliming via groups.io

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox