Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList

["Laszlo Ersek" <lersek@redhat.com>]

On 08/27/19 02:45, Ni, Ray wrote:
> The consumers are in close source and won't be in open source in near future.
> But consumers depend on open source repo.

In my interpretation, this patch does not qualify as a bugfix (suitable
for merging during the hard feature freeze), and should be postponed to
the next development cycle.

Thanks
Laszlo

> 
>> -----Original Message-----
>> From: Kinney, Michael D
>> Sent: Monday, August 26, 2019 5:20 PM
>> To: Gao, Liming <liming.gao@intel.com>; Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io; Kinney, Michael D
>> <michael.d.kinney@intel.com>
>> Cc: afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek (lersek@redhat.com) <lersek@redhat.com>
>> Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type
>> EfiBluetoothSmpPeerAddressList
>>
>> Ray,
>>
>> Are there any components that need these new enum values?
>>
>> The patch looks very straightforward and is from the
>> UEFI Spec, so I think the risk is low.  But if consumers
>> will not show up until after the stable tag, perhaps this
>> should be one of the first patches after the stable tag.
>>
>> Thanks,
>>
>> Mike
>>
>>> -----Original Message-----
>>> From: Gao, Liming
>>> Sent: Monday, August 26, 2019 4:57 PM
>>> To: Ni, Ray <ray.ni@intel.com>; devel@edk2.groups.io
>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
>>> afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek
>>> (lersek@redhat.com) <lersek@redhat.com>
>>> Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908]
>>> MdePkg/BluetoothLeConfig.h: Add type
>>> EfiBluetoothSmpPeerAddressList
>>>
>>> Cc to all Stewards.
>>>
>>>> -----Original Message-----
>>>> From: Ni, Ray
>>>> Sent: Tuesday, August 27, 2019 2:20 AM
>>>> To: devel@edk2.groups.io; Ni, Ray <ray.ni@intel.com>
>>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
>>> Gao, Liming
>>>> <liming.gao@intel.com>
>>>> Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908]
>>>> MdePkg/BluetoothLeConfig.h: Add type
>>> EfiBluetoothSmpPeerAddressList
>>>>
>>>> I understand it's now in code freeze phase.
>>>> Just make a try to see whether this very clean/simple
>>> header file
>>>> change can be included in the stable tag.
>>>> Any platform that uses BLE stack can get benefit from
>>> this definition update.
>>>>
>>>>> -----Original Message-----
>>>>> From: devel@edk2.groups.io <devel@edk2.groups.io> On
>>> Behalf Of Ni,
>>>>> Ray
>>>>> Sent: Monday, August 26, 2019 11:16 AM
>>>>> To: devel@edk2.groups.io
>>>>> Cc: Kinney, Michael D <michael.d.kinney@intel.com>;
>>> Gao, Liming
>>>> <liming.gao@intel.com>
>>>>> Subject: [edk2-devel] [PATCH] [edk2-stable201908]
>>>> MdePkg/BluetoothLeConfig.h: Add type
>>> EfiBluetoothSmpPeerAddressList
>>>>>
>>>>> To support auto-connection,
>>> EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs
>>>> to
>>>>> add a new data type EfiBluetoothSmpPeerAddressList
>>> which associates
>>>>> with a list of Bluetooth per address connected
>>> before.
>>>>>
>>>>> This new data type was added in UEFI spec 2.7b.
>>>>>
>>>>> Signed-off-by: Ray Ni <ray.ni@intel.com>
>>>>> Cc: Michael D Kinney <michael.d.kinney@intel.com>
>>>>> Cc: Liming Gao <liming.gao@intel.com>
>>>>> ---
>>>>>  MdePkg/Include/Protocol/BluetoothLeConfig.h | 4 +++-
>>>>>  1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>> diff --git
>>> a/MdePkg/Include/Protocol/BluetoothLeConfig.h
>>>> b/MdePkg/Include/Protocol/BluetoothLeConfig.h
>>>>> index 8c0f881f85..8726a58b15 100644
>>>>> --- a/MdePkg/Include/Protocol/BluetoothLeConfig.h
>>>>> +++ b/MdePkg/Include/Protocol/BluetoothLeConfig.h
>>>>> @@ -2,7 +2,7 @@
>>>>>    EFI Bluetooth LE Config Protocol as defined in
>>> UEFI 2.7.
>>>>>    This protocol abstracts user interface
>>> configuration for BluetoothLe device.
>>>>>
>>>>> -  Copyright (c) 2017, Intel Corporation. All rights
>>> reserved.<BR>
>>>>> +  Copyright (c) 2017 - 2019, Intel Corporation. All
>>> rights
>>>>> + reserved.<BR>
>>>>>    SPDX-License-Identifier: BSD-2-Clause-Patent
>>>>>
>>>>>    @par Revision Reference:
>>>>> @@ -451,6 +451,8 @@ typedef enum {
>>>>>    EfiBluetoothSmpLocalCSRK, /* If Key hierarchy not
>>> supported */
>>>>>    EfiBluetoothSmpLocalSignCounter,
>>>>>    EfiBluetoothSmpLocalDIV,
>>>>> +  EfiBluetoothSmpPeerAddressList,
>>>>> +  EfiBluetoothSmpMax,
>>>>>  } EFI_BLUETOOTH_LE_SMP_DATA_TYPE;
>>>>>
>>>>>  /**
>>>>> --
>>>>> 2.21.0.windows.1
>>>>>
>>>>>
>>>>> 
>