From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 27 Aug 2019 05:47:57 -0700 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 96A7918C426D; Tue, 27 Aug 2019 12:47:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.80]) by smtp.corp.redhat.com (Postfix) with ESMTP id 148291001B30; Tue, 27 Aug 2019 12:47:54 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type EfiBluetoothSmpPeerAddressList To: "Ni, Ray" , "Kinney, Michael D" , "Gao, Liming" , "devel@edk2.groups.io" Cc: "afish@apple.com" , "leif.lindholm@linaro.org" References: <15BE8BCCADEA547C.18314@groups.io> <734D49CCEBEEF84792F5B80ED585239D5C29AD17@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4DC923@SHSMSX104.ccr.corp.intel.com> <734D49CCEBEEF84792F5B80ED585239D5C29CEF9@SHSMSX104.ccr.corp.intel.com> From: "Laszlo Ersek" Message-ID: <79924d2c-0185-a71c-ae92-bcad8437e5ce@redhat.com> Date: Tue, 27 Aug 2019 14:47:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C29CEF9@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.62]); Tue, 27 Aug 2019 12:47:56 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/27/19 02:45, Ni, Ray wrote: > The consumers are in close source and won't be in open source in near future. > But consumers depend on open source repo. In my interpretation, this patch does not qualify as a bugfix (suitable for merging during the hard feature freeze), and should be postponed to the next development cycle. Thanks Laszlo > >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Monday, August 26, 2019 5:20 PM >> To: Gao, Liming ; Ni, Ray ; devel@edk2.groups.io; Kinney, Michael D >> >> Cc: afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek (lersek@redhat.com) >> Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] MdePkg/BluetoothLeConfig.h: Add type >> EfiBluetoothSmpPeerAddressList >> >> Ray, >> >> Are there any components that need these new enum values? >> >> The patch looks very straightforward and is from the >> UEFI Spec, so I think the risk is low. But if consumers >> will not show up until after the stable tag, perhaps this >> should be one of the first patches after the stable tag. >> >> Thanks, >> >> Mike >> >>> -----Original Message----- >>> From: Gao, Liming >>> Sent: Monday, August 26, 2019 4:57 PM >>> To: Ni, Ray ; devel@edk2.groups.io >>> Cc: Kinney, Michael D ; >>> afish@apple.com; leif.lindholm@linaro.org; Laszlo Ersek >>> (lersek@redhat.com) >>> Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] >>> MdePkg/BluetoothLeConfig.h: Add type >>> EfiBluetoothSmpPeerAddressList >>> >>> Cc to all Stewards. >>> >>>> -----Original Message----- >>>> From: Ni, Ray >>>> Sent: Tuesday, August 27, 2019 2:20 AM >>>> To: devel@edk2.groups.io; Ni, Ray >>>> Cc: Kinney, Michael D ; >>> Gao, Liming >>>> >>>> Subject: RE: [edk2-devel] [PATCH] [edk2-stable201908] >>>> MdePkg/BluetoothLeConfig.h: Add type >>> EfiBluetoothSmpPeerAddressList >>>> >>>> I understand it's now in code freeze phase. >>>> Just make a try to see whether this very clean/simple >>> header file >>>> change can be included in the stable tag. >>>> Any platform that uses BLE stack can get benefit from >>> this definition update. >>>> >>>>> -----Original Message----- >>>>> From: devel@edk2.groups.io On >>> Behalf Of Ni, >>>>> Ray >>>>> Sent: Monday, August 26, 2019 11:16 AM >>>>> To: devel@edk2.groups.io >>>>> Cc: Kinney, Michael D ; >>> Gao, Liming >>>> >>>>> Subject: [edk2-devel] [PATCH] [edk2-stable201908] >>>> MdePkg/BluetoothLeConfig.h: Add type >>> EfiBluetoothSmpPeerAddressList >>>>> >>>>> To support auto-connection, >>> EFI_BLUETOOTH_LE_SMP_DATA_TYPE needs >>>> to >>>>> add a new data type EfiBluetoothSmpPeerAddressList >>> which associates >>>>> with a list of Bluetooth per address connected >>> before. >>>>> >>>>> This new data type was added in UEFI spec 2.7b. >>>>> >>>>> Signed-off-by: Ray Ni >>>>> Cc: Michael D Kinney >>>>> Cc: Liming Gao >>>>> --- >>>>> MdePkg/Include/Protocol/BluetoothLeConfig.h | 4 +++- >>>>> 1 file changed, 3 insertions(+), 1 deletion(-) >>>>> >>>>> diff --git >>> a/MdePkg/Include/Protocol/BluetoothLeConfig.h >>>> b/MdePkg/Include/Protocol/BluetoothLeConfig.h >>>>> index 8c0f881f85..8726a58b15 100644 >>>>> --- a/MdePkg/Include/Protocol/BluetoothLeConfig.h >>>>> +++ b/MdePkg/Include/Protocol/BluetoothLeConfig.h >>>>> @@ -2,7 +2,7 @@ >>>>> EFI Bluetooth LE Config Protocol as defined in >>> UEFI 2.7. >>>>> This protocol abstracts user interface >>> configuration for BluetoothLe device. >>>>> >>>>> - Copyright (c) 2017, Intel Corporation. All rights >>> reserved.
>>>>> + Copyright (c) 2017 - 2019, Intel Corporation. All >>> rights >>>>> + reserved.
>>>>> SPDX-License-Identifier: BSD-2-Clause-Patent >>>>> >>>>> @par Revision Reference: >>>>> @@ -451,6 +451,8 @@ typedef enum { >>>>> EfiBluetoothSmpLocalCSRK, /* If Key hierarchy not >>> supported */ >>>>> EfiBluetoothSmpLocalSignCounter, >>>>> EfiBluetoothSmpLocalDIV, >>>>> + EfiBluetoothSmpPeerAddressList, >>>>> + EfiBluetoothSmpMax, >>>>> } EFI_BLUETOOTH_LE_SMP_DATA_TYPE; >>>>> >>>>> /** >>>>> -- >>>>> 2.21.0.windows.1 >>>>> >>>>> >>>>> >