Re: [edk2-devel] [PATCH v6 1/5] MdePkg/Protocol/Hash: introduce GUID for SM3 digest algorithm

["Yao, Jiewen" <jiewen.yao@intel.com>]

hi imran 
Thank to create the new series. 

I apologize that I overlooked this mdepkg update. 
I checked uefi spec 2.8 and did not found this sm3 definition. 

So I think this extension is only for edkii, not uefi spec. Am I right ?

If so, mdepkg is not the best place. The reason is that mdepkg can only include industry standard, such as uefi, pi, acpi, smbios, etc. 

I recommend we put this sm3 definition to security pkg as edkii extension only. 

You may consider submit uefi ecr to add this to uefi spec at same time. But there is no hard dependency. 
If you are not sure how to do that, please drop me a mail and I can help you on that. 

Once sm3 is added in the next uefi spec, we may add sm3 to mdepkg at that time. 

thank you!
Yao, Jiewen


> 在 2019年7月13日，上午8:47，Imran Desai <imran.desai@intel.com> 写道：
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781
> GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6
> 
> EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR
> banks. This digest algorithm is part of the China Crypto algorithm suite.
> This integration has dependency on the openssl_1_1_1b integration into
> edk2.
> 
> This patch adds GUID for SM3 digest algorithm.
> 
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> 
> Signed-off-by: Imran Desai <imran.desai@intel.com>
> ---
> MdePkg/Include/Protocol/Hash.h | 5 +++++
> 1 file changed, 5 insertions(+)
> 
> diff --git a/MdePkg/Include/Protocol/Hash.h b/MdePkg/Include/Protocol/Hash.h
> index 931d7916ef1e..8abf1a4fa305 100644
> --- a/MdePkg/Include/Protocol/Hash.h
> +++ b/MdePkg/Include/Protocol/Hash.h
> @@ -48,6 +48,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent
>     0xcaa4381e, 0x750c, 0x4770, {0xb8, 0x70, 0x7a, 0x23, 0xb4, 0xe4, 0x21, 0x30 } \
>   }
> 
> +#define EFI_HASH_ALGORITHM_SM3_256_GUID \
> +  { \
> +    0x251C7818, 0x0DBF, 0xE619, { 0x7F, 0xC2, 0xD6, 0xAC, 0x43, 0x42, 0x7D, 0xA3 } \
> +  }
> +
> #define EFI_HASH_ALGORTIHM_MD5_GUID \
>   { \
>     0xaf7c79c, 0x65b5, 0x4319, {0xb0, 0xae, 0x44, 0xec, 0x48, 0x4e, 0x4a, 0xd7 } \
> -- 
> 2.17.0
> 
> 
> 
>