From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: jiewen.yao@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Sat, 13 Jul 2019 18:54:32 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 13 Jul 2019 18:54:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,488,1557212400"; d="scan'208";a="342057517" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga005.jf.intel.com with ESMTP; 13 Jul 2019 18:54:30 -0700 Received: from fmsmsx156.amr.corp.intel.com (10.18.116.74) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 13 Jul 2019 18:54:30 -0700 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx156.amr.corp.intel.com (10.18.116.74) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sat, 13 Jul 2019 18:54:29 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.3]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.134]) with mapi id 14.03.0439.000; Sun, 14 Jul 2019 09:54:27 +0800 From: "Yao, Jiewen" To: "devel@edk2.groups.io" , "Desai, Imran" CC: "Kinney, Michael D" , "Gao, Liming" Subject: Re: [edk2-devel] [PATCH v6 1/5] MdePkg/Protocol/Hash: introduce GUID for SM3 digest algorithm Thread-Topic: [edk2-devel] [PATCH v6 1/5] MdePkg/Protocol/Hash: introduce GUID for SM3 digest algorithm Thread-Index: AQHVORSC5Sk7s1oes0yBscKmw+iPYabJW/lu Date: Sun, 14 Jul 2019 01:54:26 +0000 Message-ID: <79A07966-5EDE-4CE0-9C8A-65430EAF05D3@intel.com> References: <20190713004701.78253-1-imran.desai@intel.com>,<20190713004701.78253-2-imran.desai@intel.com> In-Reply-To: <20190713004701.78253-2-imran.desai@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: MIME-Version: 1.0 Return-Path: jiewen.yao@intel.com Content-Language: zh-CN Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: quoted-printable hi imran=20 Thank to create the new series.=20 I apologize that I overlooked this mdepkg update.=20 I checked uefi spec 2.8 and did not found this sm3 definition.=20 So I think this extension is only for edkii, not uefi spec. Am I right ? If so, mdepkg is not the best place. The reason is that mdepkg can only in= clude industry standard, such as uefi, pi, acpi, smbios, etc.=20 I recommend we put this sm3 definition to security pkg as edkii extension = only.=20 You may consider submit uefi ecr to add this to uefi spec at same time. Bu= t there is no hard dependency.=20 If you are not sure how to do that, please drop me a mail and I can help y= ou on that.=20 Once sm3 is added in the next uefi spec, we may add sm3 to mdepkg at that = time.=20 thank you! Yao, Jiewen > =1B$B:_=1B(B 2019=1B$BG/=1B(B7=1B$B7n=1B(B13=1B$BF|!$>e8a=1B(B8:47=1B$B!= $=1B(BImran Desai =1B$B=20 > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1781 > GITHUB: https://github.com/idesai/edk2/tree/enable_sm3_measured_boot_v6 >=20 > EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 P= CR > banks. This digest algorithm is part of the China Crypto algorithm suite= . > This integration has dependency on the openssl_1_1_1b integration into > edk2. >=20 > This patch adds GUID for SM3 digest algorithm. >=20 > Cc: Michael D Kinney > Cc: Liming Gao >=20 > Signed-off-by: Imran Desai > --- > MdePkg/Include/Protocol/Hash.h | 5 +++++ > 1 file changed, 5 insertions(+) >=20 > diff --git a/MdePkg/Include/Protocol/Hash.h b/MdePkg/Include/Protocol/Ha= sh.h > index 931d7916ef1e..8abf1a4fa305 100644 > --- a/MdePkg/Include/Protocol/Hash.h > +++ b/MdePkg/Include/Protocol/Hash.h > @@ -48,6 +48,11 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > 0xcaa4381e, 0x750c, 0x4770, {0xb8, 0x70, 0x7a, 0x23, 0xb4, 0xe4, 0x2= 1, 0x30 } \ > } >=20 > +#define EFI_HASH_ALGORITHM_SM3_256_GUID \ > + { \ > + 0x251C7818, 0x0DBF, 0xE619, { 0x7F, 0xC2, 0xD6, 0xAC, 0x43, 0x42, 0= x7D, 0xA3 } \ > + } > + > #define EFI_HASH_ALGORTIHM_MD5_GUID \ > { \ > 0xaf7c79c, 0x65b5, 0x4319, {0xb0, 0xae, 0x44, 0xec, 0x48, 0x4e, 0x4a= , 0xd7 } \ > --=20 > 2.17.0 >=20 >=20 >=20 >=20