From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mx.groups.io with SMTP id smtpd.web09.1785.1571935158247166879 for ; Thu, 24 Oct 2019 09:39:18 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.100, mailfrom: sachin.agrawal@intel.com) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 24 Oct 2019 09:39:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.68,225,1569308400"; d="scan'208";a="281995091" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga001.jf.intel.com with ESMTP; 24 Oct 2019 09:39:17 -0700 Received: from orsmsx106.amr.corp.intel.com ([169.254.1.210]) by ORSMSX108.amr.corp.intel.com ([169.254.2.73]) with mapi id 14.03.0439.000; Thu, 24 Oct 2019 09:39:16 -0700 From: "Agrawal, Sachin" To: "Gao, Liming" , "devel@edk2.groups.io" CC: "Feng, Bob C" , "Lohr, Paul A" Subject: Re: [PATCH] Add support for FuSA ACM in FitGen tool Thread-Topic: [PATCH] Add support for FuSA ACM in FitGen tool Thread-Index: AQHVguaGbOiMb5ruSUe9FadAHdCM5qdbTVeAgA692mA= Date: Thu, 24 Oct 2019 16:39:16 +0000 Message-ID: <79C6EF6B5F50B3499DC017935C25A5BFA5B45C6F@ORSMSX106.amr.corp.intel.com> References: <4A89E2EF3DFEDB4C8BFDE51014F606A14E517084@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E517084@SHSMSX104.ccr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzI5NWEwNTYtOTJhNi00NjUyLWEzZWUtMmRkYjQ0YWM2MzkxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiN05TOWFkYkxDOTNPbVVsYlRHRDByM0YxYlFrcThqcEVabUk4eFNHbVFUZ09VZEtmbmtFcHoycFRZUnZLb3VZcyJ9 dlp-product: dlpe-windows dlp-version: 11.2.0.6 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I am working with FitGen specification owner to update the spec and include= FuSa ACM type entry and get it published. Thanks Sachin -----Original Message----- From: Gao, Liming=20 Sent: Monday, October 14, 2019 5:24 PM To: Agrawal, Sachin ; devel@edk2.groups.io Cc: Feng, Bob C Subject: RE: [PATCH] Add support for FuSA ACM in FitGen tool As you know, FitGen is used to generate firmware interface table. This tabl= e is defined in public specification. Can you let me whether this new entry is defined in the latest FitGen spec?= =20 Thanks Liming >-----Original Message----- >From: Agrawal, Sachin >Sent: Tuesday, October 15, 2019 7:24 AM >To: devel@edk2.groups.io >Cc: Agrawal, Sachin ; Feng, Bob C=20 >; Gao, Liming >Subject: [PATCH] Add support for FuSA ACM in FitGen tool > >REF https://bugzilla.tianocore.org/show_bug.cgi?id=3D2200 > >FitGen Tool is responsible for creating FIT table in UEFI BIOS. >A new FIT entry type (FIT Type 0x3) has been allocated for FuSa ACM. >FitGen tool is updated to add support for this FuSa ACM. > >Cc: Bob Feng >Cc: Liming Gao > >Signed-off-by: Sachin Agrawal >--- > Silicon/Intel/Tools/FitGen/FitGen.c | 82 >+++++++++++++++++++++++++++++++++++++ > 1 file changed, 82 insertions(+) > >diff --git a/Silicon/Intel/Tools/FitGen/FitGen.c >b/Silicon/Intel/Tools/FitGen/FitGen.c >index faf9880060..1ebce40505 100644 >--- a/Silicon/Intel/Tools/FitGen/FitGen.c >+++ b/Silicon/Intel/Tools/FitGen/FitGen.c >@@ -217,6 +217,7 @@ typedef struct { > #define FIT_TABLE_TYPE_HEADER 0 > #define FIT_TABLE_TYPE_MICROCODE 1 > #define FIT_TABLE_TYPE_STARTUP_ACM 2 >+#define FIT_TABLE_TYPE_FUSA_ACM 3 > #define FIT_TABLE_TYPE_BIOS_MODULE 7 > #define FIT_TABLE_TYPE_TPM_POLICY 8 > #define FIT_TABLE_TYPE_BIOS_POLICY 9 >@@ -246,6 +247,8 @@ typedef struct { > UINT32 FitHeaderVersion; > FIT_TABLE_CONTEXT_ENTRY StartupAcm; > UINT32 StartupAcmVersion; >+ FIT_TABLE_CONTEXT_ENTRY FusaAcm; >+ UINT32 FusaAcmVersion; > FIT_TABLE_CONTEXT_ENTRY BiosModule[MAX_BIOS_MODULE_ENTRY]; > UINT32 BiosModuleVersion; > FIT_TABLE_CONTEXT_ENTRY Microcode[MAX_MICROCODE_ENTRY]; >@@ -317,6 +320,7 @@ Returns: > "\t[-CLEAR]\n" > "\t[-I ]\n" > "\t[-S |]=20