From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120])
 by mx.groups.io with SMTP id smtpd.web10.2585.1587375673115366661
 for <devel@edk2.groups.io>;
 Mon, 20 Apr 2020 02:41:13 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=blqMWjXO;
 spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1587375672;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=JABPKDRhjlb4WbYYOi6+F4u0+aETwFsSWrFhKU4IvqE=;
	b=blqMWjXOHHodp/h8HcQivKP8XlOrrf3k/4DLR+dOgnVNX9UNj/J2BTfQFdJth1ZTrM/qxr
	ad6uN0tV+Rsxws9rTGJuXtVgSEHXrCkYVWl6STWrTiEGLmgh67RnB0AVQBBnye80OUtM97
	eLRGQF0iPCmL7yFNw0K+M/KMQZ3jhHg=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-7-B72_xNElO-iJeJOpsFbD-A-1; Mon, 20 Apr 2020 05:41:05 -0400
X-MC-Unique: B72_xNElO-iJeJOpsFbD-A-1
Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 7723A1902EC1;
	Mon, 20 Apr 2020 09:41:04 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-114-228.ams2.redhat.com [10.36.114.228])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 288041001DC0;
	Mon, 20 Apr 2020 09:41:02 +0000 (UTC)
Subject: Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Skip reading PlatformId on AMD processors.
To: Gary Lin <glin@suse.com>, devel@edk2.groups.io, leo.duran@amd.com
Cc: Eric Dong <eric.dong@intel.com>, Ray Ni <ray.ni@intel.com>
References: <1582988745-1189-1-git-send-email-leo.duran@amd.com>
 <1582988745-1189-2-git-send-email-leo.duran@amd.com>
 <20200417081447.GC26140@GaryWorkstation>
From: "Laszlo Ersek" <lersek@redhat.com>
Message-ID: <79c80320-8d0c-d99f-030a-2a9a0ba796be@redhat.com>
Date: Mon, 20 Apr 2020 11:41:02 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <20200417081447.GC26140@GaryWorkstation>
X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Language: en-US
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit

On 04/17/20 10:14, Gary Lin wrote:
> On Sat, Feb 29, 2020 at 09:05:45AM -0600, Leo Duran wrote:
>> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2556
>>
>> This patch uses CPUID signature check to skip reading the PlatformId MSR,
>> which is not implemented on AMD processors.
>>
>> The PlatformId is used for loading microcode patches, which is also not
>> supported and AMD-based platforms. To mitigate the PlatformId dependency,
>> PcdCpuMicrocodePatchAddress and PcdCpuMicrodePatchRegionSize must be set
>> to 0 (default value), in order to bypass microcode loading code paths.
>>
> I got an error report about the executable bit of MpLib.h while
> packaging ovmf. It turned out that this patch accidentally changed the
> file mode. It would be nice if the mode can be corrected.

Thanks for the report. I've filed
<https://bugzilla.tianocore.org/show_bug.cgi?id=2678> and assigned it to
Leo.

Leo, can you please submit the patch?

Thanks!
Laszlo