public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: "Marvin Häuser" <Marvin.Haeuser@outlook.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>,
	"jordan.l.justen@intel.com" <jordan.l.justen@intel.com>
Subject: Re: [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables.
Date: Thu, 3 Nov 2016 23:55:10 +0100	[thread overview]
Message-ID: <79c821b0-1b1e-e148-e0ae-ee55e83cee48@redhat.com> (raw)
In-Reply-To: <AM5PR0601MB25794FB82411C0C6AC2B0FF280A30@AM5PR0601MB2579.eurprd06.prod.outlook.com>

Hi Marvin,

On 11/03/16 20:18, Marvin Häuser wrote:
> Currently, the values of the page tables' address and size are
> hard-coded in the ResetVector. This patch replaces this with a PCD
> dependency for the NASM Reset Vector. The ASM Reset Vector remains
> using a hard-coded value due to the lack of C preprocessing.
> 
> Checks for the size have been added to alert the developer to rewrite
> the ASM according to the new size, if it has been changed.
> 
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Marvin Haeuser <Marvin.Haeuser@outlook.com>
> ---
>  OvmfPkg/ResetVector/Ia32/PageTables64.asm | 23 ++++++++++----------
>  OvmfPkg/ResetVector/ResetVector.inf       |  5 +++++
>  OvmfPkg/ResetVector/ResetVector.nasmb     |  7 ++++++
>  OvmfPkg/ResetVector/ResetVectorCode.asm   | 16 ++++++++++++++
>  4 files changed, 39 insertions(+), 12 deletions(-)

I'll soon send a modified / simplified version of your patch (keeping
your authorship and S-o-b in the first place of course). I find that
simpler than struggling with an explanation :) I hope you're fine with this.

Thanks!
Laszlo


  parent reply	other threads:[~2016-11-03 22:55 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <AM5PR0601MB25794FB82411C0C6AC2B0FF280A30@AM5PR0601MB2579.eurprd06.prod.outlook.com>
2016-11-03 20:59 ` [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables Jordan Justen
2016-11-03 21:46   ` Marvin Häuser
2016-11-03 22:55 ` Laszlo Ersek [this message]
2016-11-03 23:10   ` Jordan Justen
2016-11-03 23:19     ` Marvin Häuser
2016-11-03 23:43       ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79c821b0-1b1e-e148-e0ae-ee55e83cee48@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox