From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C1B1A81C4F for ; Thu, 3 Nov 2016 15:55:10 -0700 (PDT) Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E6993D953; Thu, 3 Nov 2016 22:55:12 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-178.phx2.redhat.com [10.3.116.178]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA3MtAig015420; Thu, 3 Nov 2016 18:55:11 -0400 To: =?UTF-8?Q?Marvin_H=c3=a4user?= References: Cc: "edk2-devel@lists.01.org" , "jordan.l.justen@intel.com" From: Laszlo Ersek Message-ID: <79c821b0-1b1e-e148-e0ae-ee55e83cee48@redhat.com> Date: Thu, 3 Nov 2016 23:55:10 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.68 on 10.5.11.24 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Thu, 03 Nov 2016 22:55:12 +0000 (UTC) Subject: Re: [PATCH v2] OvmfPkg/ResetVector: Depend on PCD values of the page tables. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 03 Nov 2016 22:55:10 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Hi Marvin, On 11/03/16 20:18, Marvin Häuser wrote: > Currently, the values of the page tables' address and size are > hard-coded in the ResetVector. This patch replaces this with a PCD > dependency for the NASM Reset Vector. The ASM Reset Vector remains > using a hard-coded value due to the lack of C preprocessing. > > Checks for the size have been added to alert the developer to rewrite > the ASM according to the new size, if it has been changed. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Marvin Haeuser > --- > OvmfPkg/ResetVector/Ia32/PageTables64.asm | 23 ++++++++++---------- > OvmfPkg/ResetVector/ResetVector.inf | 5 +++++ > OvmfPkg/ResetVector/ResetVector.nasmb | 7 ++++++ > OvmfPkg/ResetVector/ResetVectorCode.asm | 16 ++++++++++++++ > 4 files changed, 39 insertions(+), 12 deletions(-) I'll soon send a modified / simplified version of your patch (keeping your authorship and S-o-b in the first place of course). I find that simpler than struggling with an explanation :) I hope you're fine with this. Thanks! Laszlo