From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 68D63D81194 for ; Mon, 5 Feb 2024 07:39:23 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=D0xJvus8QIzfXXpHZF6Ubhb2jEKAXOSTVjXW2iWpTv8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20140610; t=1707118761; v=1; b=dTF1xkOixPcCIuXKpavWdmrUjR/1iyws1qgT7rZz7fNZlgklQ6v2LdtFjcCH3xpcs09ofQBQ j5uddHRcLEfMwxrQ8XuQpjJpWfo69F3A0tj929gqHuDjrMW6VHpZV0HLdSMuStk3PxnSxwbn1WL LIKv5IeaHdUVzE4oulKmEFw4= X-Received: by 127.0.0.2 with SMTP id DerPYY7687511xojCd1T6dRV; Sun, 04 Feb 2024 23:39:21 -0800 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.57967.1707118761283343912 for ; Sun, 04 Feb 2024 23:39:21 -0800 X-Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-140-YOj-TxkjMJO66wB99xpazQ-1; Mon, 05 Feb 2024 02:39:16 -0500 X-MC-Unique: YOj-TxkjMJO66wB99xpazQ-1 X-Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.rdu2.redhat.com [10.11.54.8]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id D82903CBD503; Mon, 5 Feb 2024 07:39:15 +0000 (UTC) X-Received: from [10.39.192.216] (unknown [10.39.192.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 38EA5C15E61; Mon, 5 Feb 2024 07:39:15 +0000 (UTC) Message-ID: <79d63859-1cae-0fe3-2e99-e482e3f88ea6@redhat.com> Date: Mon, 5 Feb 2024 08:39:14 +0100 MIME-Version: 1.0 Subject: Re: [edk2-devel] [PATCH V3 5/5] OvmfPkg: Align XenRealTimeClockLib function headers with return values To: devel@edk2.groups.io, suqiangx.ren@intel.com Cc: Ard Biesheuvel , Jiewen Yao References: From: "Laszlo Ersek" In-Reply-To: X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.8 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,lersek@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 6OpSrKOZew3VmibEJQWYy3OMx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=dTF1xkOi; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none) On 2/2/24 09:20, Ren, Suqiang wrote: > XenRealTimeClockLib is used to back the runtime services time functions, > so align the description of the function return values with the > defined values for these services as described in UEFI Spec 2.10. > > REF: UEFI spec 2.10 section 8 Services — Runtime Services > > Signed-off-by: Suqiang Ren > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Laszlo Ersek > --- > .../XenRealTimeClockLib/XenRealTimeClockLib.c | 22 +++++++++++++++---- > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c b/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c > index 30c258313135..6d7f452a7550 100644 > --- a/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c > +++ b/OvmfPkg/Library/XenRealTimeClockLib/XenRealTimeClockLib.c > @@ -80,6 +80,9 @@ EpochToEfiTime ( > @retval EFI_SUCCESS The operation completed successfully. > @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The time could not be retrieved due to hardware error. > + @retval EFI_UNSUPPORTED This call is not supported by this platform at the time the call is made. > + The platform should describe this runtime service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configuration table. > > **/ > EFI_STATUS > @@ -109,6 +112,9 @@ LibGetTime ( > @retval EFI_SUCCESS The operation completed successfully. > @retval EFI_INVALID_PARAMETER A time field is out of range. > @retval EFI_DEVICE_ERROR The time could not be set due to hardware error. > + @retval EFI_UNSUPPORTED This call is not supported by this platform at the time the call is made. > + The platform should describe this runtime service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configuration table. > > **/ > EFI_STATUS > @@ -128,9 +134,13 @@ LibSetTime ( > @param Time The current alarm setting. > > @retval EFI_SUCCESS The alarm settings were returned. > - @retval EFI_INVALID_PARAMETER Any parameter is NULL. > + @retval EFI_INVALID_PARAMETER Enabled is NULL. > + @retval EFI_INVALID_PARAMETER Pending is NULL. > + @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The wakeup time could not be retrieved due to a hardware error. > - @retval EFI_UNSUPPORTED A wakeup timer is not supported on this platform. > + @retval EFI_UNSUPPORTED This call is not supported by this platform at the time the call is made. > + The platform should describe this runtime service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configuration table. > > **/ > EFI_STATUS > @@ -152,9 +162,13 @@ LibGetWakeupTime ( > > @retval EFI_SUCCESS If Enable is TRUE, then the wakeup alarm was enabled. If > Enable is FALSE, then the wakeup alarm was disabled. > - @retval EFI_INVALID_PARAMETER A time field is out of range. > + @retval EFI_INVALID_PARAMETER Enabled is NULL. > + @retval EFI_INVALID_PARAMETER Pending is NULL. > + @retval EFI_INVALID_PARAMETER Time is NULL. > @retval EFI_DEVICE_ERROR The wakeup time could not be set due to a hardware error. > - @retval EFI_UNSUPPORTED A wakeup timer is not supported on this platform. > + @retval EFI_UNSUPPORTED This call is not supported by this platform at the time the call is made. > + The platform should describe this runtime service as unsupported at runtime > + via an EFI_RT_PROPERTIES_TABLE configuration table. > > **/ > EFI_STATUS Acked-by: Laszlo Ersek -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#115098): https://edk2.groups.io/g/devel/message/115098 Mute This Topic: https://groups.io/mt/104115882/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-