From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM02-DM3-obe.outbound.protection.outlook.com (NAM02-DM3-obe.outbound.protection.outlook.com [40.107.95.77]) by mx.groups.io with SMTP id smtpd.web09.9239.1631789986906106692 for ; Thu, 16 Sep 2021 03:59:47 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=MV5B7LkH; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.95.77, mailfrom: brijesh.singh@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=kJPAFqbR06biIKPMgcYoM4Ahr4OkaKUs3HuiOMUWiD09ipsyIhQv+62bv+rJfZK149d5reDlHqn2wQdGHRbC2JHWm8EUiT2WQabdleyCcYVY17WPyFoxaGusmP/RcyHBruM3+rhT/QTYLP+fBz2ZWb1RxcKu8YBb1EGcrG2cIJE+7DFzIsdmIX09CvF6LkLUUU52LXep8WNlo9eCZk2aHtdghr/g8i26+OVSx8mTEeJuJpDLsASSWIj2Ppy/3zLTPi4bj5QqHkzrjvXgwrqbA++kO+rHXT4sM3GNr/QO3g/N+9i3GT4vR5qpbROTGCSJaQpIHPo6KOAiMoRn8H3FEw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=7sDwZt3n19GfqX/KKJ6d5LqkYyRyRkADpl8J9KeUxJ8=; b=AOpT3r9oVYZHiU5VLyLU+Y8T9I2y0JhJqhs0+sEZt2kWdt72N5aqU/sl8lcqCKyYT3GKYqyQE2GNysEE/Q4ecK7j0UdilXjm09rYl8GQabdiBXqsSwJVb9RoAqKwWgexwMa1Pp/59rF/7UGpZDSR/lf4V4bIPqgxzZEUsYrSDPKhAXz/lD34qiri/47WonfxlMyAJKueXHj+BP/RbHabeRlN9h+lm+g0A5sO36nCtB5RUDhmcqRZY4UaCTaryB3I9+CjIoDjbaQhPevUAYG8qpuppgjqXHgZVnOPLvEVEN2JKjpVpU143HmLXPkXe/Doa7s7YHD1FBgnxx3X/7o42A== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=7sDwZt3n19GfqX/KKJ6d5LqkYyRyRkADpl8J9KeUxJ8=; b=MV5B7LkHj6h2YABQ94FQg2QRoSl5BRlc4bDmuXPQCao+/qc8veQeIDJ9b4tSW7qHB9HMZhB0UGWydVmfcuKQAKWM4H1Nc5h1UKK4135xEKjjNWa2FnZ1paR5t8Sbr95WsxitTyuyS4rF0L/8iFTKceKmdzhf8ThHs9DglJMdxKY= Authentication-Results: amd.com; dkim=none (message not signed) header.d=none;amd.com; dmarc=none action=none header.from=amd.com; Received: from SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) by SA0PR12MB4512.namprd12.prod.outlook.com (2603:10b6:806:71::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Thu, 16 Sep 2021 10:59:44 +0000 Received: from SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3]) by SN6PR12MB2718.namprd12.prod.outlook.com ([fe80::78b7:7336:d363:9be3%6]) with mapi id 15.20.4500.020; Thu, 16 Sep 2021 10:59:44 +0000 Subject: Re: [PATCH v7 11/31] OvmfPkg/PlatformPei: register GHCB gpa for the SEV-SNP guest To: Gerd Hoffmann Cc: devel@edk2.groups.io, James Bottomley , Min Xu , Jiewen Yao , Tom Lendacky , Jordan Justen , Ard Biesheuvel , Erdem Aktas , Michael Roth References: <20210913181941.23405-1-brijesh.singh@amd.com> <20210913181941.23405-12-brijesh.singh@amd.com> <20210916083325.ti3jvept54yywcsc@sirius.home.kraxel.org> From: "Brijesh Singh" Message-ID: <79dd6852-94dd-52a4-0182-c24276743d32@amd.com> Date: Thu, 16 Sep 2021 05:59:41 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 In-Reply-To: <20210916083325.ti3jvept54yywcsc@sirius.home.kraxel.org> X-ClientProxiedBy: SN4PR0401CA0003.namprd04.prod.outlook.com (2603:10b6:803:21::13) To SN6PR12MB2718.namprd12.prod.outlook.com (2603:10b6:805:6f::22) Return-Path: brijesh.singh@amd.com MIME-Version: 1.0 Received: from Brijeshs-MacBook-Pro.local (165.204.77.11) by SN4PR0401CA0003.namprd04.prod.outlook.com (2603:10b6:803:21::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Thu, 16 Sep 2021 10:59:43 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: ef930f83-02ae-4646-cf5e-08d979011779 X-MS-TrafficTypeDiagnostic: SA0PR12MB4512: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:751; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: sqBIyMKZ3Y9xEL3OY5IPm84CNrBGNgTWmC1zos1TN3lcb4CI1fPzp1L3wTJnsqRLICR3fygprb+99aN6BMDvMylMFqhMdzOz2QxEHeMZ8vTyoSo1N9TIZ2U0RvQZwlmCxnjmm4PMn+Oy6Ccr5eQl4AuZkcXMbWL5qTcIUcJYO0IoTmMZIZTow/XONGubFrQfw3Xgg9oKg4gTsh/RhQ6zWZ0E6MeAcmGAVWZm5zALiPt9STRFo18TCXuYb4hZpcMQZCLwueEvxYfafe1narNlgRUNBePeVDRmiKxgzrzXFBGl+qqcuocNrDB0Zj9CHk4VFUHJ9v2WGLpPmDsVRF8dF7Xim/Oo9z/PPVSkY5gYQv3sf5LA2prj0Dqef6ZE98/0sw8I60epdRt/Vlbjh2P1y5yHDvw8pvfyul37Lbdx0eDmHiTqAqTGZkWB1we5evoYKxugEYXTAu6GNrqnOXdJCaDI0OwT32wnMmI0y4iYfyUqUo5exA3tQLj/xe5S3ysNnVHHxSZzFZ+Ft2p2nqJqAAYJQ1Z0P4nHWjHpVRcvw3BGUk0uMdU75AZkmAYKgmNJr2Tkf3tsx0AG+W2xES35FUVmKNxzzEUN3br7nNa/n7tV3xksgorsNYBshwQYO0MWfdoafDkdM3ZAEkM4j9neDcPnqVimz8mWYgulcsSW6SVri7THY/JCoOk/VkHGQtuaBso9vXBysODRU2aARFjXxAY9odDsY/capEP1KAIBcofVGfvFuEQr+NK4vOszYid+hnoSHbZ4vIFjVtVS6ACk+ol93Y9bk3lnkYS737RG+faEO3OZHMoGbUtmSwCzHMHXbtPQ+a59g7hDAx4z1CvKDlGlS1HtEm9q6gT60a/du5s= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:SN6PR12MB2718.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(376002)(366004)(346002)(396003)(39860400002)(136003)(4326008)(31696002)(45080400002)(6512007)(8676002)(6486002)(478600001)(53546011)(6506007)(86362001)(66556008)(66946007)(66476007)(38350700002)(38100700002)(186003)(26005)(5660300002)(2906002)(44832011)(52116002)(966005)(4744005)(36756003)(31686004)(54906003)(316002)(6916009)(8936002)(2616005)(956004)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?QmpQeEZvbHdsZ3RVZnRNb0ZudWNOcHo0cExzU1BhdERKN1JIcmR1cllWSlFV?= =?utf-8?B?YlRyMFJwT3RhS3I5MGY0SVZXbGlpMC9VcXRvZ0l4bmlqckxITmcwTW5MTnFC?= =?utf-8?B?elVMT0lGTnB4Q2pQZklMSkdkemdIS3BPU1NVQnhBU1p4UXl0ZmtwSWxQL05i?= =?utf-8?B?N3d5cDJlOTUySjVDdndiOTIrWFo3Slp2T1ZsL0JhNW9MWWdsNUt4cTh2dE4w?= =?utf-8?B?MC9nRHBjNXZNdkZMYVBYNVFiYitxM1U2THdMZWN0bWxUVjJoN05lamlrV25J?= =?utf-8?B?Wng2dHJNR1FIL3dCUm9zZW54dVo0U2M5VnRwTGFVWWNoaTVzOE9uVmRCY05j?= =?utf-8?B?dGxWeGdLYW1aWVJMdUVxUklnVlFybUJ6WkcwMWZoZkR5SDlzVTF4TW1mNDJL?= =?utf-8?B?eWw4bUtadUR4VnlXb0doUTB6Z1RTUzB2ckkyWXFiNVk4a2dvNXQyVmlVUnJS?= =?utf-8?B?dXBaUjBJU3BYMXpPZGJUTXE0N3NhTGFJWlpnTjNmSytDS2ZiN2kwd1k4bzNl?= =?utf-8?B?Mnp2cS9BQzhnTUpJdGx6THdKOUdtYktSR0hNb0FRZWxQa000d1RvNzd0ekJP?= =?utf-8?B?UVB6TGFFVCtPRGRDZy9lWThqdVhQeldSL2c2U2JocldJY1ZCSm9pVXZhcjhQ?= =?utf-8?B?bFpIUWtqY04ra1JEbm9UWUxIYXZSQjlvaVlqTHFoV3pOcC91MGQrT2wwRTFy?= =?utf-8?B?UGhvc09LdjgrRWNtTVBvNVBUenB4QkJPdUhGbmlTVTJiblBxYlBIdUdqU3hh?= =?utf-8?B?OHlKbEUvWjFqQTY5dGoxTUp5S2J5SnhPK2w2ME5zTlVjOEdUZmdtdGN0b0xC?= =?utf-8?B?bG9WU24zd0lVOVBOdDRYSmlMaExEQUJ6Q1NyUGdJanBmU05qRDRXdlBOa0Ft?= =?utf-8?B?QlhtdmEzRnBRRWRPc3pnbThqZXdXUkJJRHlqejlPbDBEQ1hHa2dTUUU5L1A5?= =?utf-8?B?R3ZFZFIyOEJ5V2RSNWNVVTZoTG93ZEVWUUFDeVBDMG9sancrcjViOG1JelJw?= =?utf-8?B?N0k2Y3RSeFFVejlhYS9ETnRmWWpLdDZMcERQaEpJc0d3MUJCUzZiR0hYenE5?= =?utf-8?B?cGxnTSt1Vm0vZGZEVlVrOVpwZTNwZjF5akprTlp3VDNDSTR0T0Z5RjFRbC8y?= =?utf-8?B?aDNjMW9iNFFNVjVLTkN2SlE2OURRLzh4ZWF6TjBjUHRrTzV0UWZJQ2Y4MDdE?= =?utf-8?B?OWZhQVU1ajBTaWo5UTNJclNFOGdVN09zTkpFMXV0d0VyUEZNN0xWYW9HaGlX?= =?utf-8?B?OXBFQlJYNHVCaFVULzlDL3RVY1Y1Nk1VTys0Mjd6dC9WSUdRMFVHd2Z4VlAz?= =?utf-8?B?WkhXamxsdHdyRktSbjlGK2RteG9Mb2lBOGVFaDQrWS9qQlR1S1ZBQWZwSlhn?= =?utf-8?B?bUlCNlBTTU9mZkhJN0g4YWFFbWUrZ0xHVEhVdG9JRVhsRzltbE1YY016cVJQ?= =?utf-8?B?TEpaWXljdFJEemFHRVU1d0pQM2x3aWdjM1FTdjlZYVF2aGVYVVpkNFNtSThX?= =?utf-8?B?emJjS0RFZ0p1NnlFWFJZcmdCZnhLSGZ1anQxa3h5RmRPeU5CMWNlRG1xa1R4?= =?utf-8?B?d2pldEMrbExRMEE4dXdwSmU3eTRqOWYwUHlVZXRWSzhVOHFtWUMvNmkyS3Vw?= =?utf-8?B?UGY2SnVVeEM3ZzFJRks1MHExbFgvWW9WOVlhMXBuSFBBSnpHVFZVdGt6aEIx?= =?utf-8?B?NTRzMTQ0S3VjVWh6RmtNUUdkN2pvWjRYVFZ4amFiSDJaN0REd2VsWHhNYUp0?= =?utf-8?Q?o0vfYteQJh3UynCS17QaJ+/v105G3hV7V6NloDk?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: ef930f83-02ae-4646-cf5e-08d979011779 X-MS-Exchange-CrossTenant-AuthSource: SN6PR12MB2718.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Sep 2021 10:59:44.6452 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bnmUsR0PPtUlbLPB+C03aPAG6JjiNUpS9/z4zuqjNAeMuEQ1VpVm/he0k6KYjLY65914HDDoIjGJprnS9eT7Rw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA0PR12MB4512 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US On 9/16/21 3:33 AM, Gerd Hoffmann wrote: > On Mon, Sep 13, 2021 at 01:19:21PM -0500, Brijesh Singh wrote: >> BZ: https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3275&data=04%7C01%7Cbrijesh.singh%40amd.com%7C6495c28531da4bc30ce508d978ecab93%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637673780170202032%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=6AyBzL6AReYjbKGIrU%2FnaoPp6UGS09wQu%2FwONhcu9iA%3D&reserved=0 >> >> The SEV-SNP guest requires that GHCB GPA must be registered before using. >> See the GHCB specification section 2.3.2 for more details. > Already done in SEC phase (patch #9), why again in PEI? The SEC begins with a fixed GHCB page; During the PEI phase, we allocate and switch to new per-CPU GHCB page and thus need to registration for the new GHCB. Please see the commit 449a6e493418c337752b68e4f199bd2d7d39af9f. thanks