public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <quic_llindhol@quicinc.com>
To: "Chang, Abner" <Abner.Chang@amd.com>,
	"devel@edk2.groups.io" <devel@edk2.groups.io>,
	"nhi@os.amperecomputing.com" <nhi@os.amperecomputing.com>
Cc: "chuong@os.amperecomputing.com" <chuong@os.amperecomputing.com>,
	"rebecca@os.amperecomputing.com" <rebecca@os.amperecomputing.com>
Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support
Date: Wed, 7 Aug 2024 11:23:46 +0100	[thread overview]
Message-ID: <79e9a70e-ec9c-45c7-a797-36890a8e7fc9@quicinc.com> (raw)
In-Reply-To: <LV8PR12MB94525CB15B8F068C31DBEF00EAB82@LV8PR12MB9452.namprd12.prod.outlook.com>

Err, no we haven't.

Although we're in the process of doing that.

/
     Leif

On 2024-08-07 08:16, Chang, Abner wrote:
> [AMD Official Use Only - AMD Internal Distribution Only]
> 
> Hi Pham,
> We already move edk2-platforms review through GitHub PR. Could you please send the PR against edk2-platforms?
> 
> Thanks
> Abner
> 
>> -----Original Message-----
>> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Nhi Pham
>> via groups.io
>> Sent: Wednesday, August 7, 2024 2:47 PM
>> To: devel@edk2.groups.io
>> Cc: quic_llindhol@quicinc.com; chuong@os.amperecomputing.com;
>> rebecca@os.amperecomputing.com; nhi@os.amperecomputing.com
>> Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support
>>
>> Caution: This message originated from an External Source. Use proper caution
>> when opening attachments, clicking links, or responding.
>>
>>
>> This updates the I2C library and implements SMBUS PEI/DXE drivers to
>> support IPMI SSIF in the Mt. Jade platform.
>>
>> v2:
>> - Refine the changes of the DwI2cLib per Leif's comments and update the
>>    commit message accordingly.
>> - Remove the additional PCD PcdBmcSlaveAddr since it's is unused.
>>
>> NOTE: Regarding the controller/target terminology, the function
>> prototype and comment are derived from edk2/MdePkg. In this patch set, I
>> am trying to avoid misusing the terms in the implementation instead of
>> altering the function prototype and comment with the PPI and Protocol.
>>
>> Nhi Pham (5):
>>    AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation
>>    AmpereSiliconPkg: Define PCDs for SMBUS and BMC
>>    AmpereAltraPkg: Add SmbusHc PEI and DXE drivers
>>    JadePkg: Add PlatformBmcReadyLib to support BMC ready check
>>    Ampere/Jade: Enable IPMI SSIF
>>
>>   Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec                        |  15 +-
>>   Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc                        |  23 ++
>>   Platform/Ampere/JadePkg/Jade.dsc                                            |   2 +
>>   Platform/Ampere/JadePkg/Jade.fdf                                            |  17 ++
>>
>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
>> Lib.inf |  29 ++
>>   Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf                |
>> 43 +++
>>   Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf                |
>> 43 +++
>>   Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h
>> |  95 +++++++
>>   Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h                      |  11 +-
>>   Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c
>> |   6 +-
>>
>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
>> Lib.c   |  30 +++
>>   Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c
>> | 261 ++++++++++++++++++
>>   Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c                  |
>> 277 ++++++++++++++++++++
>>   Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c                  |
>> 263 +++++++++++++++++++
>>   Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c                   | 129
>> ++++++++-
>>   15 files changed, 1227 insertions(+), 17 deletions(-)
>>   create mode 100755
>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
>> Lib.inf
>>   create mode 100644
>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf
>>   create mode 100644
>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf
>>   create mode 100644
>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h
>>   create mode 100644
>> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady
>> Lib.c
>>   create mode 100644
>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c
>>   create mode 100644
>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c
>>   create mode 100644
>> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c
>>
>> --
>> 2.25.1
>>
>>
>>
>> 
>>
> 



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120271): https://edk2.groups.io/g/devel/message/120271
Mute This Topic: https://groups.io/mt/107765352/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-08-07 10:23 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-08-07  6:47 [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Nhi Pham via groups.io
2024-08-07  6:47 ` [edk2-devel] [edk2-platforms][PATCH v2 1/5] AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation Nhi Pham via groups.io
2024-08-07  6:47 ` [edk2-devel] [edk2-platforms][PATCH v2 2/5] AmpereSiliconPkg: Define PCDs for SMBUS and BMC Nhi Pham via groups.io
2024-08-07  6:47 ` [edk2-devel] [edk2-platforms][PATCH v2 3/5] AmpereAltraPkg: Add SmbusHc PEI and DXE drivers Nhi Pham via groups.io
2024-08-07  6:47 ` [edk2-devel] [edk2-platforms][PATCH v2 4/5] JadePkg: Add PlatformBmcReadyLib to support BMC ready check Nhi Pham via groups.io
2024-08-07  6:47 ` [edk2-devel] [edk2-platforms][PATCH v2 5/5] Ampere/Jade: Enable IPMI SSIF Nhi Pham via groups.io
2024-08-07  7:16 ` [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support Chang, Abner via groups.io
2024-08-07  7:35   ` Nhi Pham via groups.io
2024-08-09  2:44     ` Chang, Abner via groups.io
2024-08-09  3:05       ` Nhi Pham via groups.io
2024-08-09  4:34         ` Chang, Abner via groups.io
2024-08-07 10:23   ` Leif Lindholm [this message]
2024-08-07 10:45     ` Chang, Abner via groups.io
2024-08-07 10:56       ` Leif Lindholm
2024-08-07 10:59         ` Chang, Abner via groups.io
2024-08-08  3:06 ` Nhi Pham via groups.io
     [not found] ` <17E9A1ED2D454E7A.19172@groups.io>
2024-08-13  4:16   ` Nhi Pham via groups.io
2024-08-29  5:55 ` Chuong Tran
2024-08-29  7:11   ` Nhi Pham via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=79e9a70e-ec9c-45c7-a797-36890a8e7fc9@quicinc.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox