From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 4ED6E740041 for ; Wed, 7 Aug 2024 10:23:55 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=arv34dUmRfENO8HuFrfIjrsfyPlNb2/182ZUqEnhNI8=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:CC:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1723026234; v=1; b=g1KJEwyWnACMoqY2cVg1hdfsktxo5tQzlelcVp2l0X/pt8kPQGVyGTlHDongpDTxcEKM9wmm HQlxd5k42WjZBQ17msNqptaenKBmNOftIZxuLzsgcO/5NWvmjTsFgFvqjG5SV86cPqkm92h3JRT 8P00zuyG0ofxk4nB1DJoCGrlU2UCXuEgi4eMTxrerSR4ndcF2WZQ+mZZLUQ/7azUG1pBZoThMIQ ZKRIIc0Vb/JaPdyBe7+EnjKai7eXFZagTuZI4gv2TMLq+q6/vshfFneKM2yZ1REKHipHf4vOftE NO7FavexXOkBIP7mSBqfTEe2Pg7s5x14FcDVtRPWG3wRg== X-Received: by 127.0.0.2 with SMTP id vyLTYY7687511xTpRaw9gg8w; Wed, 07 Aug 2024 03:23:53 -0700 X-Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) by mx.groups.io with SMTP id smtpd.web10.30169.1723026232457685919 for ; Wed, 07 Aug 2024 03:23:52 -0700 X-Received: from pps.filterd (m0279862.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4778Ccul017145; Wed, 7 Aug 2024 10:23:51 GMT X-Received: from nasanppmta01.qualcomm.com (i-global254.qualcomm.com [199.106.103.254]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 40sdaea8se-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 07 Aug 2024 10:23:50 +0000 (GMT) X-Received: from nasanex01c.na.qualcomm.com (nasanex01c.na.qualcomm.com [10.45.79.139]) by NASANPPMTA01.qualcomm.com (8.17.1.19/8.17.1.19) with ESMTPS id 477ANoLA014670 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 7 Aug 2024 10:23:50 GMT X-Received: from [10.111.137.42] (10.80.80.8) by nasanex01c.na.qualcomm.com (10.45.79.139) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.9; Wed, 7 Aug 2024 03:23:48 -0700 Message-ID: <79e9a70e-ec9c-45c7-a797-36890a8e7fc9@quicinc.com> Date: Wed, 7 Aug 2024 11:23:46 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF support To: "Chang, Abner" , "devel@edk2.groups.io" , "nhi@os.amperecomputing.com" CC: "chuong@os.amperecomputing.com" , "rebecca@os.amperecomputing.com" References: <20240807064731.4049764-1-nhi@os.amperecomputing.com> From: "Leif Lindholm" In-Reply-To: X-Originating-IP: [10.80.80.8] X-ClientProxiedBy: nasanex01a.na.qualcomm.com (10.52.223.231) To nasanex01c.na.qualcomm.com (10.45.79.139) X-QCInternal: smtphost X-Proofpoint-ORIG-GUID: RnuWlWQdDyVNsYs3ouiryJUpUmV5pFm2 X-Proofpoint-GUID: RnuWlWQdDyVNsYs3ouiryJUpUmV5pFm2 Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 07 Aug 2024 03:23:52 -0700 Resent-From: quic_llindhol@quicinc.com Reply-To: devel@edk2.groups.io,quic_llindhol@quicinc.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: D54Sxw5w9haY7fITpFe4n1YMx7686176AA= Content-Language: en-GB Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=g1KJEwyW; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=quicinc.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io Err, no we haven't. Although we're in the process of doing that. / Leif On 2024-08-07 08:16, Chang, Abner wrote: > [AMD Official Use Only - AMD Internal Distribution Only] >=20 > Hi Pham, > We already move edk2-platforms review through GitHub PR. Could you please= send the PR against edk2-platforms? >=20 > Thanks > Abner >=20 >> -----Original Message----- >> From: devel@edk2.groups.io On Behalf Of Nhi Pham >> via groups.io >> Sent: Wednesday, August 7, 2024 2:47 PM >> To: devel@edk2.groups.io >> Cc: quic_llindhol@quicinc.com; chuong@os.amperecomputing.com; >> rebecca@os.amperecomputing.com; nhi@os.amperecomputing.com >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 0/5] Add IPMI SSIF suppo= rt >> >> Caution: This message originated from an External Source. Use proper cau= tion >> when opening attachments, clicking links, or responding. >> >> >> This updates the I2C library and implements SMBUS PEI/DXE drivers to >> support IPMI SSIF in the Mt. Jade platform. >> >> v2: >> - Refine the changes of the DwI2cLib per Leif's comments and update the >> commit message accordingly. >> - Remove the additional PCD PcdBmcSlaveAddr since it's is unused. >> >> NOTE: Regarding the controller/target terminology, the function >> prototype and comment are derived from edk2/MdePkg. In this patch set, I >> am trying to avoid misusing the terms in the implementation instead of >> altering the function prototype and comment with the PPI and Protocol. >> >> Nhi Pham (5): >> AmpereAltraPkg/DwI2cLib: Add support for SMBUS+PEC operation >> AmpereSiliconPkg: Define PCDs for SMBUS and BMC >> AmpereAltraPkg: Add SmbusHc PEI and DXE drivers >> JadePkg: Add PlatformBmcReadyLib to support BMC ready check >> Ampere/Jade: Enable IPMI SSIF >> >> Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec = | 15 +- >> Silicon/Ampere/AmpereAltraPkg/AmpereAltraPkg.dsc.inc = | 23 ++ >> Platform/Ampere/JadePkg/Jade.dsc = | 2 + >> Platform/Ampere/JadePkg/Jade.fdf = | 17 ++ >> >> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >> Lib.inf | 29 ++ >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf = | >> 43 +++ >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf = | >> 43 +++ >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h >> | 95 +++++++ >> Silicon/Ampere/AmpereAltraPkg/Include/Library/I2cLib.h = | 11 +- >> Platform/Ampere/JadePkg/Library/PCF85063RealTimeClockLib/PCF85063.c >> | 6 +- >> >> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >> Lib.c | 30 +++ >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c >> | 261 ++++++++++++++++++ >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c = | >> 277 ++++++++++++++++++++ >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c = | >> 263 +++++++++++++++++++ >> Silicon/Ampere/AmpereAltraPkg/Library/DwI2cLib/DwI2cLib.c = | 129 >> ++++++++- >> 15 files changed, 1227 insertions(+), 17 deletions(-) >> create mode 100755 >> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >> Lib.inf >> create mode 100644 >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.inf >> create mode 100644 >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.inf >> create mode 100644 >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.h >> create mode 100644 >> Platform/Ampere/JadePkg/Library/PlatformBmcReadyLib/PlatformBmcReady >> Lib.c >> create mode 100644 >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcCommon.c >> create mode 100644 >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcDxe.c >> create mode 100644 >> Silicon/Ampere/AmpereAltraPkg/Drivers/SmbusHc/SmbusHcPei.c >> >> -- >> 2.25.1 >> >> >> >>=20 >> >=20 -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#120271): https://edk2.groups.io/g/devel/message/120271 Mute This Topic: https://groups.io/mt/107765352/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-