From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.85.128.65, mailfrom: philmd@redhat.com) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Mon, 29 Apr 2019 05:28:57 -0700 Received: by mail-wm1-f65.google.com with SMTP id b10so462670wmj.4 for ; Mon, 29 Apr 2019 05:28:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=pno+deQlpQfHMn4BDMEq30I+K86A7ywuFAe95U1Xz3Q=; b=HpO0xfNWGhzfnHHAE5Mg51AZLTgXWRgBWzy+IokBqXHO3iR+/4tHgKqKsiZYPKSBeG GqlM1bMgfaEjr2uVdYmDAJxSj43raqPQb5sqWx2QlfCIWCMA9diynjs21Sh2Re74XaDP Taw4DZuj/MY3hbgPH4Ufll5MsskTDa9MDgIYygIyWw1hjQtLJ7yJ/Ij3+453WEOTp0UM n707eKm9mthJBBVZ0rMocAa6eVX/J296ce6tR2De8IawePqlZV2+Jf110/E3Flsx65l9 oWRih4VBxO5vQLuoHhtMomdE+ab2DwTajBk88/xqjfraQIBbOLFAAKuh9pYUZFr3Y9Bf EUrA== X-Gm-Message-State: APjAAAU8rAT1ryP28kvKka3URu/Pgzj34Y+47r1TawAVeiL7S9b5NDlg JIWfCiTjbcLa9LLzr8Tig4cPTw== X-Google-Smtp-Source: APXvYqxMUnXFz0TA4npT8f6SnDfiXvdQig8tNda1FZaDnMhy4ED+/4CYKltV9WZcHG4O2MSYDStayw== X-Received: by 2002:a7b:c844:: with SMTP id c4mr16900802wml.108.1556540935457; Mon, 29 Apr 2019 05:28:55 -0700 (PDT) Return-Path: Received: from [192.168.1.33] (193.red-88-21-103.staticip.rima-tde.net. [88.21.103.193]) by smtp.gmail.com with ESMTPSA id y197sm33521127wmd.34.2019.04.29.05.28.54 (version=TLS1_3 cipher=AEAD-AES128-GCM-SHA256 bits=128/128); Mon, 29 Apr 2019 05:28:54 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 08/16] OvmfPkg/EnrollDefaultKeys: remove unneeded EFIAPI call. conv. specifiers To: devel@edk2.groups.io, lersek@redhat.com Cc: Anthony Perard , Ard Biesheuvel , Jordan Justen , Julien Grall References: <20190427005328.27005-1-lersek@redhat.com> <20190427005328.27005-9-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: <79f66557-598f-c944-0273-c9bd6047ae99@redhat.com> Date: Mon, 29 Apr 2019 14:28:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190427005328.27005-9-lersek@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 4/27/19 2:53 AM, Laszlo Ersek wrote: > The GetExact(), GetSettings(), PrintSettings() functions are only called > from within "EnrollDefaultKeys.c", and none of them take variable > arguments. Drop their EFIAPI calling convention specifiers. > > Cc: Anthony Perard > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Julien Grall > Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=1747 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > index be0e4d8f8e96..671efef8d6ad 100644 > --- a/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > +++ b/OvmfPkg/EnrollDefaultKeys/EnrollDefaultKeys.c > @@ -806,17 +806,16 @@ Out: > VendorGuid, Status); > } > return Status; > } > > > STATIC > EFI_STATUS > -EFIAPI > GetExact ( > IN CHAR16 *VariableName, > IN EFI_GUID *VendorGuid, > OUT VOID *Data, > IN UINTN DataSize, > IN BOOLEAN AllowMissing > ) > { > @@ -850,17 +849,16 @@ typedef struct { > UINT8 SecureBoot; > UINT8 SecureBootEnable; > UINT8 CustomMode; > UINT8 VendorKeys; > } SETTINGS; > > STATIC > EFI_STATUS > -EFIAPI > GetSettings ( > OUT SETTINGS *Settings > ) > { > EFI_STATUS Status; > > Status = GetExact (EFI_SETUP_MODE_NAME, &gEfiGlobalVariableGuid, > &Settings->SetupMode, sizeof Settings->SetupMode, FALSE); > @@ -889,17 +887,16 @@ GetSettings ( > > Status = GetExact (EFI_VENDOR_KEYS_VARIABLE_NAME, &gEfiGlobalVariableGuid, > &Settings->VendorKeys, sizeof Settings->VendorKeys, FALSE); > return Status; > } > > STATIC > VOID > -EFIAPI > PrintSettings ( > IN CONST SETTINGS *Settings > ) > { > AsciiPrint ("info: SetupMode=%d SecureBoot=%d SecureBootEnable=%d " > "CustomMode=%d VendorKeys=%d\n", Settings->SetupMode, Settings->SecureBoot, > Settings->SecureBootEnable, Settings->CustomMode, Settings->VendorKeys); > } > Reviewed-by: Philippe Mathieu-Daude