From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in7.apple.com (mail-out7.apple.com [17.151.62.29]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1191021A6F105 for ; Tue, 6 Jun 2017 13:48:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1496782178; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-transfer-encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=3c0UAXzIEeHEl1kXhmjQAKrgVYSxR5xYTyRlOVLS+u8=; b=21nk35V56bJWIkZ12puvjeXSXXUX78JBlUXeRqxOmkp/b08y+xqyV4a9CVgqrCN0 w6pbcibQWNdCJNEZFDOIP9IMS+4A5HjfPn5N2cH4CCRmvQa5k98ZkmPnmn3aphXD WaBk46FvSGwr0+ymkAKTym7fSphctQY0eWw7zOsbx2xOUn7/p5DGZwt74P+Tnf10 XBvad4sh2Ngi5zba2u3sgs52lS74kdvD0NU3iHNOuuJ+li2KyZmuD42dB/mZVspf DSBuMBzLa4SKdT/jhUUgPjesDVudy4tFZ7IIuDB9R8iPFAlUyRjHk1gTGG3OFEud FclpQujutr1Ed1W/E+73Bg==; Received: from relay5.apple.com (relay5.apple.com [17.128.113.88]) (using TLS with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mail-in7.apple.com (Apple Secure Mail Relay) with SMTP id 35.D3.07949.06517395; Tue, 6 Jun 2017 13:49:38 -0700 (PDT) X-AuditID: 11973e16-bf3fb70000001f0d-70-59371560be0c Received: from nwk-mmpp-sz13.apple.com (nwk-mmpp-sz13.apple.com [17.128.115.216]) by relay5.apple.com (Apple SCV relay) with SMTP id 4D.60.02326.06517395; Tue, 6 Jun 2017 13:49:36 -0700 (PDT) MIME-version: 1.0 Received: from [17.153.85.153] (unknown [17.153.85.153]) by nwk-mmpp-sz13.apple.com (Oracle Communications Messaging Server 8.0.1.2.20170210 64bit (built Feb 10 2017)) with ESMTPSA id <0OR500K5W8IMBP00@nwk-mmpp-sz13.apple.com>; Tue, 06 Jun 2017 13:49:36 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish In-reply-to: <629c1154-77c8-07cf-131e-cdc64300245c@zytor.com> Date: Tue, 06 Jun 2017 13:49:34 -0700 Cc: Mike Kinney , "edk2-devel@lists.01.org" , "H. Peter Anvin" Message-id: <7A0046FF-FF4E-44FA-9A6F-D2765E07DAA1@apple.com> References: <1495473154-18184-1-git-send-email-michael.d.kinney@intel.com> <542CF652F8836A4AB8DBFAAD40ED192A4C5E8084@shsmsx102.ccr.corp.intel.com> <629c1154-77c8-07cf-131e-cdc64300245c@zytor.com> To: "Fan, Jeff" X-Mailer: Apple Mail (2.3273) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrJLMWRmVeSWpSXmKPExsUi2FAYoZskah5p8PSAscW6Pd/YLaZtFLc4 uX4Jo0VHxz8mBxaPxXteMnlMuvCY2eNEyxfWAOYoLpuU1JzMstQifbsEroyGn2fYCqbyV2z7 uJ61gfELdxcjJ4eEgInE3uvv2boYuTiEBFYzSfy8cZIFJrGlbyIzROIQo0TrsR1gCV4BQYkf k+8B2RwczALyEgfPy4KEmQW0JL4/amWBqJ/IJNHw8DUrSEJYQFzi3ZlNzCD1wgLxEjPn24OE 2QSUJVbM/8AOYnMK2Eq0Tl7IDGKzCKhKNK69DHYQs0Abo8Ts7ceYIfbaSGw9eApqwXFGifZ3 U8ASIgIqEhP+fGGEuFpW4tbsS8wQ9gE2iWcbYycwCs9CcvcshLtnIbl7ASPzKkah3MTMHN3M PHO9xIKCnFS95PzcTYygsJ9uJ7aD8eEqq0OMAhyMSjy8GXvMIoVYE8uKK3MPMUpzsCiJ8157 aBQpJJCeWJKanZpakFoUX1Sak1p8iJGJg1OqgVF1oe58hociLJP0J8X7LZ3xJvvoZcsVXs03 bAUn3D+goOFm2nRVfO1Xzr0eF7/Hq1xmnzdFK6BcZ2XOrCs6mmcYE+3K5/VsYPjPwjuXe/f+ bLEt+80Cwrk/JYbP2KR3YdnptQVc9yazX1gwV3dLx1K9hu8h+dHBJV/6u+U+5UdOyTu0zCOD 450SS3FGoqEWc1FxIgANdFeUXAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsUi2FB8QzdB1DzSYOp3JYt1e76xW0zbKG5x cv0SRouOjn9MDiwei/e8ZPKYdOExs8eJli+sAcxRXDYpqTmZZalF+nYJXBkNP8+wFUzlr9j2 cT1rA+MX7i5GTg4JAROJLX0TmbsYuTiEBA4xSrQe28ECkuAVEJT4MfkekM3BwSwgL3HwvCxI mFlAS+L7o1YWiPqJTBIND1+zgiSEBcQl3p3ZxAxSLywQLzFzvj1ImE1AWWLF/A/sIDangK1E 6+SFzCA2i4CqROPay2wgc5gF2hglZm8/xgyx10Zi68FTUAuOM0q0v5sClhARUJGY8OcLI8TV shK3Zl9insAoMAvJrbMQbp2F5NYFjMyrGAWKUnMSK031EgsKclL1kvNzNzGCA7UwYgfj/2VW hxgFOBiVeHgFdplFCrEmlhVX5gIDg4NZSYS35zNQiDclsbIqtSg/vqg0J7X4EGMV0AcTmaVE k/OBUZRXEm9oYmJgYmxsZmxsbmJOFWElcV7z/UaRQgLpiSWp2ampBalFMMuZODilGhi59i3P ucRz+doLhg+BdbmsNn6hLLrzprq1fdjv9+7lOnOxh8x1TMZ51kohuz6uc2Z9eS8wyvHAnPWM EXxRJi0FRzamdbpqP/KaKLBiY0YtZ+aLLRGMHJeyb9eZWQmsYfCXLQi8vcbj4P4uf7N7d/tP V9bsf82odpT5et38j7HyXuuZ7WRc5iqxFGckGmoxFxUnAgCVEHCnrwIAAA== Subject: Re: [Patch V2] UefiCpuPkg/MpInitLib: Fix X64 XCODE5/NASM compatibility issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Jun 2017 20:48:32 -0000 Content-transfer-encoding: 7BIT Content-type: text/plain; CHARSET=US-ASCII > On Jun 6, 2017, at 12:41 PM, H. Peter Anvin wrote: > > On 05/22/17 19:08, Fan, Jeff wrote: >> >> diff --git a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >> index fa54d01..0b14a53 100644 >> --- a/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >> +++ b/UefiCpuPkg/Library/MpInitLib/X64/MpFuncs.nasm >> @@ -1,5 +1,5 @@ >> ;------------------------------------------------------------------------------ ; -; Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
>> +; Copyright (c) 2015 - 2017, Intel Corporation. All rights >> +reserved.
>> ; This program and the accompanying materials ; are licensed and made available under the terms and conditions of the BSD License ; which accompanies this distribution. The full text of the license may be found at @@ -201,7 +201,7 @@ CProcedureInvoke: >> push rbp >> mov rbp, rsp >> >> - mov rax, ASM_PFX(InitializeFloatingPointUnits) >> + mov rax, qword [esi + InitializeFloatingPointUnitsAddress] Does nasm remove the need for the ASM_PFX() macro? That macro hides if C is decorating with a _ prefix. Also given it is a #define (equ) why do we use camel case vs. all caps? Thanks, Andrew Fish >> sub rsp, 20h >> call rax ; Call assembly function to initialize FPU per UEFI spec >> add rsp, 20h > > FYI, the qword specifier is unnecessary since you are already specifying > rax. > > However, why not simply drop the use of rax entirely and do: > > call [esi + InitializeFloatingPointUnitsAddress] > > (Also: is this *really* supposed to be esi and not rsi? The former > means a 32-bit address.) > > -hpa > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel