From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-in23.apple.com (mail-out23.apple.com [17.171.2.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6C9121A1E28 for ; Fri, 21 Oct 2016 13:54:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; d=apple.com; s=mailout2048s; c=relaxed/simple; q=dns/txt; i=@apple.com; t=1477083256; h=From:Sender:Reply-To:Subject:Date:Message-id:To:Cc:MIME-version:Content-type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-reply-to:References:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=KibwqK+0iKC1tnz2MXlPZoKvwO/UNFpgsKVPrssmx4I=; b=TySIp1moQqdr0QWPzVb0DW9zidvrHnUP7AjbSVSv8Q3BDMTTtY6QQPXmzpcQSB+J 7hcDVk4rsqF24JYwi5OBFM4iflswEqoejBPhwHK/jmQuzLhh2VO4WM6gBsJTjY94 zQtyH8yLxTHtjI4+3cSSEvvsGHL73z8AFnx/JBnLSH9KqP6FaueTD2+586cGSxIY b1tST+mrajxsxrbEuXMuRmgu+GRqxg9k928GJR+3rvenRGpXB1kXMMB+EXSqyDjQ djUCxZcd5O/B1mwcBsYJ6HooXSvxhOc/5rlIAFw7HP9ReF/NWw/6EGZZaUCFboj9 xogq6QT0YeFjSG5F3mQkMQ==; Received: from relay25.apple.com (relay25.apple.com [17.171.128.106]) by mail-in23.apple.com (Apple Secure Mail Relay) with SMTP id 54.BB.08419.8708A085; Fri, 21 Oct 2016 16:54:16 -0400 (EDT) X-AuditID: 11ab0217-9ed879a0000020e3-d5-580a8078d5f6 Received: from ma1-mmpp-sz10.apple.com (ma1-mmpp-sz10.apple.com [17.171.128.150]) by relay25.apple.com (Apple SCV relay) with SMTP id C3.00.24919.8708A085; Fri, 21 Oct 2016 16:54:16 -0400 (EDT) MIME-version: 1.0 Received: from [17.168.156.82] by ma1-mmpp-sz10.apple.com (Oracle Communications Messaging Server 8.0.1.1.0 64bit (built Jun 15 2016)) with ESMTPSA id <0OFF00LPN0QDL280@ma1-mmpp-sz10.apple.com>; Fri, 21 Oct 2016 13:54:16 -0700 (PDT) Sender: afish@apple.com From: Andrew Fish Message-id: <7A41C43F-250B-4DCB-9193-E21FBB4BA590@apple.com> Date: Fri, 21 Oct 2016 13:54:13 -0700 In-reply-to: <147708236992.14194.656313834108120082@jljusten-ivb> Cc: Ard Biesheuvel , edk2-devel-01 , "Gao, Liming" , Leif Lindholm , Mike Kinney , Laszlo Ersek To: Jordan Justen References: <147707992484.13791.10042868456965197315@jljusten-ivb> <147708236992.14194.656313834108120082@jljusten-ivb> X-Mailer: Apple Mail (2.3226) X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsUiuLohS7eigSvC4P09MYv/H3YzWuw5dJTZ Yse1fhaLT7v3sFgsO7aDxWLFvQ3sFh0d/5gc2D0W73nJ5HHn2h42j+7Z/1g83u+7yhbAEsVl k5Kak1mWWqRvl8CVMeFYK2vB2b+MFf1rXrM0MM6+w9jFyMkhIWAisefwErYuRi4OIYGDjBJP L69mhUksmrCUHSJxGCixrIUZJMErICjxY/I9FhCbWSBM4tP5H2wgtpDAO0aJSZviQGxhAXGJ d2c2gdWzCShLrJj/AWgQB1CvjcTlPRYQJQUS3za8YgKxWQRUJVZ3XAcr5xRwlDix9iMLyF5m gZ+MEp17X4MViQjoSvQt/8MCcdANJonbG2cwggyVEJCVmP3LCyQuIfCcTWL61JXMExiFZiG5 dRaSWyFsLYnvj1qB4hxAtrzEwfOyEGFNiWf3PrFD2NoST95dYF3AyLaKUTg3MTNHNzPPyFgv saAgJ1UvOT93EyM4rpjEdzB+fm14iFGAg1GJh3eFMFeEEGtiWXFl7iFGaQ4WJXFe25VsEUIC 6YklqdmpqQWpRfFFpTmpxYcYmTg4pRoYS3nKvkd9PyIfqey0VH+ZnNS8FTWuKW+Scp80bUxy 94vOX/Ziw1/Jw1LuAgZFTZsTuPTSQrTDppxozDVVyWt+Py3imtLd1XzztM2ZLuzqfBhUs6+k 6qzBrch7H97zyW41ExKyesJ+ceHJC8IHhZtes/33T9r+duekRbLR7/duC9g2tWPi0u1lSizF GYmGWsxFxYkAdoMYa4wCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrBLMWRmVeSWpSXmKPExsUiuLphmm5FA1eEwa8HPBb/P+xmtNhz6Ciz xY5r/SwWn3bvYbFYdmwHi8WKexvYLTo6/jE5sHss3vOSyePOtT1sHt2z/7F4vN93lS2AJYrL JiU1J7MstUjfLoErY8KxVtaCs38ZK/rXvGZpYJx9h7GLkZNDQsBEYtGEpewQtpjEhXvr2boY uTiEBA4zSjxd1sIMkuAVEJT4MfkeC4jNLBAm8en8DzYQW0jgHaPEpE1xILawgLjEuzObwOrZ BJQlVsz/ADSUA6jXRuLyHguIkgKJbxteMYHYLAKqEqs7roOVcwo4SpxY+5EFZC+zwE9Gic69 r8GKRAR0JfqW/2GBOOgGk8TtjTMYQYZKCMhKzP7lNYFRYBaS82YhOQ/C1pL4/qgVKM4BZMtL HDwvCxHWlHh27xM7hK0t8eTdBdYFjGyrGAWLUnMSK41M9RILCnJS9ZLzczcxQuIjawfj7Ztm hxgFOBiVeHirs7gihFgTy4orcw8xSnAwK4nwTtnAHiHEm5JYWZValB9fVJqTWnyIUZqDRUmc V60QqFogPbEkNTs1tSC1CCbLxMEp1cA4vfTAt1KDiPn3ZY/N2XX6xjEznsWSrlsy3KymGPKs i1n0ImZN4tK5n7MvRSmXpm4Q0n4ifiaMVf/qP6W+64trgr/xr7qW/uaKkt7GBNHNHsxqhyd0 MnOe3lv2YN3DO6dfhYWcq5OX8rrI+9G/4fH73RZRC+fFF28T/vamId7coe2C1uqemi45JZbi jERDLeai4kQATZgY8IsCAAA= X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 20:54:17 -0000 Content-Type: text/plain; CHARSET=US-ASCII Content-Transfer-Encoding: 7BIT > On Oct 21, 2016, at 1:39 PM, Jordan Justen wrote: > > On 2016-10-21 13:20:49, Andrew Fish wrote: >> On Oct 21, 2016, at 12:58 PM, Jordan Justen >> wrote: >> On 2016-10-21 12:37:21, Ard Biesheuvel wrote: >> >> I don't remember seeing any discussion regarding >> DISABLE_NEW_DEPRECATED_INTERFACES on the list, so I am a bit surprised >> seeing these bugs being filed and assigned. >> >> I agree. >> >> Also, the terminology seems confusing. 'new deprecated' seems like a >> contradiction. I guess it means 'newly deprecated', but that seems >> like a term that is quickly going to become obsolete. Soon there will >> be old deprecated items that are disabled with this switch. >> DISABLE_DEPRECATED_INTERFACES sounds better. >> >> But, shouldn't we have platforms opt-in to using the deprecated >> interfaces rather than adding DISABLE_NEW_DEPRECATED_INTERFACES to the >> build command line for every EDK II platform? >> >> Not using deprecated items should be the default for EDK II platforms. >> If a platform has to opt-in to the deprecated content in their .dsc, >> then it is obvious that they are relying on deprecated functionality. >> >> So, I guess I'd propose adding ENABLE_DEPRECATED_INTERFACES instead. >> >> Jordan, >> I think it depends on your point of view. If you have a platform that >> works and you update the edk2 revision you would expect it to still work. > > I think this is what UDK is for. If you want to depend directly on EDK > II, then you'll see less stability. > Jordan, Well there should be a published plan for a future UDK that this change is going to happen before we "break it" in master. Publishing the plan with the UDK does not count :). >> Thus the option is to DISABLE_DEPRECATED_INTERFACES as that maintains >> backward compatibility. > > In order to support UDK releases, maybe ENABLE_UDK2014_INTERFACES would be > something to consider. Or ENABLE_UDK_INTERFACE=2014 so we can use <=. > > But, I still think that EDK II platforms (as a goal) should represent > the best, cleanest examples of using EDK II. And, I think having every > platform accumulate cruft like CFLAGS to disable deprecated interfaces > works against that goal. > > Another point. What about when we want to deprecate more interfaces? > Oh know, we better not break platforms that only specified > DISABLE_NEW_DEPRECATED_INTERFACES! Let's add > DISABLE_NEW_DEPRECATED_INTERFACES2! :) > I think you make a very good point. How about DISABLE_2014_DEPRECATE_INTERFACES. I think that version scales, and might actually encourage cleanup as it shows when the interface first got deprecated. Thanks, Andrew Fish > -Jordan > >> I think it makes total sense to turn on DISABLE_DEPRECATED_INTERFACES on >> all the open source edk2 platform as soon as possible so all the open >> source code is following current best practices. >> Not to mention it would probably be a really good idea to give all the >> downstream folks a long lead time about the plan of making a non backward >> compatible change. >> Thanks, >> Andrew Fish >> >> -Jordan >> >> Before making any such changes, I would like a strong commitment from >> other package owners that deprecating an interface brings along with >> it the responsibility to update all existing callers, otherwise >> setting this define will only result in more breakage, and ARM has >> seen its share of inadvertent breakage in the past when changes to >> core code were made without taking other architectures into account. >> >> On 21 October 2016 at 02:21, >> wrote: >> >> https://bugzilla.tianocore.org/show_bug.cgi?id=164 >> >> yonghong.zhu@intel.com changed: >> >> What |Removed |Added >> ---------------------------------------------------------------------------- >> Priority|Lowest |Normal >> Status|UNCONFIRMED |CONFIRMED >> Assignee|michael.d.kinney@intel.com >> |ard.biesheuvel@linaro.org >> Ever confirmed|0 |1 >> Release(s) the| |EDK II Trunk >> issues must be| | >> fixed| | >> >> --- Comment #1 from yonghong.zhu@intel.com --- >> Assign to Package owner. >> >> -- >> You are receiving this mail because: >> You are the assignee for the bug. >> >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel