From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by ml01.01.org (Postfix) with ESMTP id 9B41E1A1DF5 for ; Thu, 11 Aug 2016 09:09:16 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 11 Aug 2016 09:09:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,505,1464678000"; d="scan'208";a="154306778" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by fmsmga004.fm.intel.com with ESMTP; 11 Aug 2016 09:09:16 -0700 Received: from orsmsx116.amr.corp.intel.com (10.22.240.14) by ORSMSX109.amr.corp.intel.com (10.22.240.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 11 Aug 2016 09:09:15 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.118]) by ORSMSX116.amr.corp.intel.com ([169.254.7.187]) with mapi id 14.03.0248.002; Thu, 11 Aug 2016 09:09:14 -0700 From: "Ma, Maurice" To: "Ni, Ruiyu" CC: "Agyeman, Prince" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 04/11] CorebootPayloadPkg/ResetSystemLib: Implement ResetPlatformSpecific Thread-Index: AQHR8svqfQp7Ou+Fsk2xn2Zh543fxaBD71Bw Date: Thu, 11 Aug 2016 16:09:14 +0000 Message-ID: <7AAC936950815649B5F88FAE785306C28413B877@ORSMSX113.amr.corp.intel.com> References: <20160810055611.266232-1-ruiyu.ni@intel.com> <20160810055611.266232-5-ruiyu.ni@intel.com> In-Reply-To: <20160810055611.266232-5-ruiyu.ni@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMmRjNDViNGMtNmM4MC00ZjEzLWEwYmMtY2VjMTVhNTA3YzAxIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6ImZLK2o0em0yQlNNTWJGTVNSMHltUkhPam91ZUVCdWpGTXJhMmFsY1wvWE13PSJ9 x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH 04/11] CorebootPayloadPkg/ResetSystemLib: Implement ResetPlatformSpecific X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Aug 2016 16:09:16 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable It looks good to me.=20 Reviewed by: Maurice Ma Regards, Maurice -----Original Message----- From: Ni, Ruiyu=20 Sent: Tuesday, August 09, 2016 10:56 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince Subject: [PATCH 04/11] CorebootPayloadPkg/ResetSystemLib: Implement ResetPl= atformSpecific Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Ruiyu Ni Cc: Maurice Ma Cc: Prince Agyeman --- .../Library/ResetSystemLib/ResetSystemLib.c | 23 ++++++++++++++++++= +++- 1 file changed, 22 insertions(+), 1 deletion(-) diff --git a/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c b/C= orebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c index 55f5609..f6621bf 100644 --- a/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c +++ b/CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c @@ -1,7 +1,7 @@ /** @file Reset System Library functions for coreboot =20 - Copyright (c) 2014, Intel Corporation. All rights reserved.
+ Copyright (c) 2014 - 2016, Intel Corporation. All rights=20 + reserved.
This program and the accompanying materials are licensed and made available under the terms and conditions of the BS= D License which accompanies this distribution. The full text of the license may b= e found at @@ -161,3 +161,24 @@ EnterS3WithImmediateWake ( AcpiPmControl (5); ASSERT (FALSE); } + +/** + This function causes a systemwide reset. The exact type of the reset=20 +is defined + by the EFI_GUID that follows the Null-terminated Unicode string passed i= nto ResetData. + If the platform does not recognize the EFI_GUID in ResetData the=20 +platform must pick a + supported reset type to perform.The platform may optionally log the=20 +parameters from + any non-normal reset that occurs. + + @param[in] DataSize The size, in bytes, of ResetData. + @param[in] ResetData The data buffer starts with a Null-terminated str= ing, followed + by the EFI_GUID. +**/ +VOID +EFIAPI +ResetPlatformSpecific ( + IN UINTN DataSize, + IN VOID *ResetData + ) +{ + ResetCold (); +} -- 2.9.0.windows.1