public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ma, Maurice" <maurice.ma@intel.com>
To: "Agyeman, Prince" <prince.agyeman@intel.com>
Cc: "Leahy, Leroy P" <leroy.p.leahy@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 2/2] CorebootPayloadPkg: fixed GCC49 and GCC5 hang in PeiCore
Date: Thu, 18 Aug 2016 02:55:22 +0000	[thread overview]
Message-ID: <7AAC936950815649B5F88FAE785306C284148192@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <97ae23986a9bdaba3ae51984f3a63ba1662baeb2.1471457662.git.prince.agyeman@intel.com>

Reviewed by: Maurice Ma <maurice.ma@intel.com>

-----Original Message-----
From: Agyeman, Prince 
Sent: Wednesday, August 17, 2016 1:16 PM
To: edk2-devel@lists.01.org
Cc: Ma, Maurice; Leahy, Leroy P
Subject: [PATCH 2/2] CorebootPayloadPkg: fixed GCC49 and GCC5 hang in PeiCore

Section alignment of .data in GCC49 and GCC5 are 0x40 rather than 0x20 in GCC48 and below.
This causes a hang in PeiCore.

Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Prince Agyeman <prince.agyeman@intel.com>
---
 CorebootPayloadPkg/CorebootPayloadPkg.fdf | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
index 481f343..d07fd30 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf
+++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf
@@ -219,7 +219,7 @@ INF CorebootPayloadPkg/FbGop/FbGop.inf
 
 [Rule.Common.PEI_CORE]
   FILE PEI_CORE = $(NAMED_GUID) {
-    PE32     PE32   Align=32    $(INF_OUTPUT)/$(MODULE_NAME).efi
+    PE32     PE32   Align=Auto    $(INF_OUTPUT)/$(MODULE_NAME).efi
     UI       STRING ="$(MODULE_NAME)" Optional
     VERSION  STRING ="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER)
   }
@@ -227,7 +227,7 @@ INF CorebootPayloadPkg/FbGop/FbGop.inf
 [Rule.Common.PEIM]
   FILE PEIM = $(NAMED_GUID) {
      PEI_DEPEX PEI_DEPEX Optional        $(INF_OUTPUT)/$(MODULE_NAME).depex
-     PE32      PE32   Align=32           $(INF_OUTPUT)/$(MODULE_NAME).efi
+     PE32      PE32   Align=Auto           $(INF_OUTPUT)/$(MODULE_NAME).efi
      UI       STRING="$(MODULE_NAME)" Optional
      VERSION  STRING="$(INF_VERSION)" Optional BUILD_NUM=$(BUILD_NUMBER)
   }
--
2.7.4



       reply	other threads:[~2016-08-18  2:55 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <de35aeeba5ea531a649f9317dccdf2af403769c4.1471457662.git.prince.agyeman@intel.com>
     [not found] ` <97ae23986a9bdaba3ae51984f3a63ba1662baeb2.1471457662.git.prince.agyeman@intel.com>
2016-08-18  2:55   ` Ma, Maurice [this message]
2016-08-18  2:56 ` [PATCH 1/2] CorebootPayloadPkg : Added MpInitLib to CorebootPayloadPkg.dsc Ma, Maurice

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7AAC936950815649B5F88FAE785306C284148192@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox