From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 539B41A1E56 for ; Wed, 12 Oct 2016 21:03:00 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP; 12 Oct 2016 21:03:00 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,338,1473145200"; d="scan'208";a="19073540" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by fmsmga005.fm.intel.com with ESMTP; 12 Oct 2016 21:02:59 -0700 Received: from orsmsx158.amr.corp.intel.com (10.22.240.20) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 12 Oct 2016 21:02:59 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.161]) by ORSMSX158.amr.corp.intel.com ([169.254.10.129]) with mapi id 14.03.0248.002; Wed, 12 Oct 2016 21:02:58 -0700 From: "Ma, Maurice" To: "Mudusuru, Giri P" CC: "Yao, Jiewen" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position independent Thread-Index: AQHSJO2aju6UUF0mFE+cjW5xSnDj4aCln9GwgAAjbXA= Date: Thu, 13 Oct 2016 04:02:58 +0000 Message-ID: <7AAC936950815649B5F88FAE785306C284167EB5@ORSMSX113.amr.corp.intel.com> References: <7ea97596e527f44a8d69170d0481c21ff087c565.1476320550.git.maurice.ma@intel.com> <4666AEFED60F8E4198B42BB01DCEABDF76F11BA7@ORSMSX113.amr.corp.intel.com> In-Reply-To: <4666AEFED60F8E4198B42BB01DCEABDF76F11BA7@ORSMSX113.amr.corp.intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDZlZDNlNDctMTc0Yy00YjM2LWFhOWUtYTE5NDIxNGY5MTZkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlpqREUxUldld3ZGN3VuVUZIRWhxZVM4OGFSVFk3TUIyakJDcU1mMzF3XC93PSJ9 x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons position independent X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Oct 2016 04:03:00 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Giri, Sure, I'll fix the typo. Thank you for the review! -Maurice -----Original Message----- From: Mudusuru, Giri P=20 Sent: Wednesday, October 12, 2016 6:56 PM To: Ma, Maurice; edk2-devel@lists.01.org Cc: Yao, Jiewen Subject: RE: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons pos= ition independent Thanks for fixing the bug Maurice. Please fix the typo funcitons in the tit= le during checkin Reviewed-by: Giri P Mudusuru =20 > -----Original Message----- > From: Ma, Maurice > Sent: Wednesday, October 12, 2016 6:03 PM > To: edk2-devel@lists.01.org > Cc: Ma, Maurice ; Yao, Jiewen=20 > ; Mudusuru, Giri P > Subject: [edk2] [PATCH] IntelFsp2Pkg/FspSecCore: Make FSP funcitons=20 > position independent >=20 > The current AsmGetFspInfoHeader function in FspHeader.nasm is position=20 > dependent code since it uses absolute address. Change to use relative=20 > address instead to make it position independent. >=20 > Cc: Jiewen Yao > Cc: Giri P Mudusuru > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Maurice Ma > --- > IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > b/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > index a848dcbc0298..ad631943e32d 100644 > --- a/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > +++ b/IntelFsp2Pkg/FspSecCore/Ia32/FspHelper.nasm > @@ -31,7 +31,7 @@ ASM_PFX(NextInstruction): > pop eax > sub eax, ASM_PFX(NextInstruction) > add eax, ASM_PFX(AsmGetFspInfoHeader) > - sub eax, dword [ASM_PFX(FspInfoHeaderRelativeOff)] > + sub eax, dword [eax - ASM_PFX(AsmGetFspInfoHeader) + > ASM_PFX(FspInfoHeaderRelativeOff)] > ret >=20 > global ASM_PFX(AsmGetFspInfoHeaderNoStack) > -- > 1.9.5.msysgit.0