From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A2A1A1A1E43 for ; Wed, 26 Oct 2016 19:56:52 -0700 (PDT) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga102.jf.intel.com with ESMTP; 26 Oct 2016 19:56:32 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,404,1473145200"; d="scan'208";a="24545676" Received: from orsmsx102.amr.corp.intel.com ([10.22.225.129]) by orsmga004.jf.intel.com with ESMTP; 26 Oct 2016 19:56:32 -0700 Received: from orsmsx112.amr.corp.intel.com (10.22.240.13) by ORSMSX102.amr.corp.intel.com (10.22.225.129) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 26 Oct 2016 19:56:32 -0700 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.50]) by ORSMSX112.amr.corp.intel.com ([169.254.3.58]) with mapi id 14.03.0248.002; Wed, 26 Oct 2016 19:56:32 -0700 From: "Ma, Maurice" To: "Dong, Guo" CC: "Agyeman, Prince" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH] CorebootPayloadPkg: Add "Down" key to Boot Manager Menu Thread-Index: AQHSL+tzRu2ORI3FjkewCXbfjclGz6C7m45A Date: Thu, 27 Oct 2016 02:56:31 +0000 Message-ID: <7AAC936950815649B5F88FAE785306C284176D52@ORSMSX113.amr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMGE5NDE3NTgtZWNkZS00MTEwLTkyMjktMDE1NDU3MTNlY2ZiIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6InBOU2VLTVEwXC9Ld2VXQkNYcDBHOSs0Slhld1RMVVM2SW5MSWNUejBVbXNvPSJ9 x-originating-ip: [10.22.254.139] MIME-Version: 1.0 Subject: Re: [PATCH] CorebootPayloadPkg: Add "Down" key to Boot Manager Menu X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 02:56:52 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Maurice Ma -----Original Message----- From: Dong, Guo=20 Sent: Wednesday, October 26, 2016 5:45 PM To: edk2-devel@lists.01.org Cc: Ma, Maurice; Agyeman, Prince; Dong, Guo Subject: [edk2] [PATCH] CorebootPayloadPkg: Add "Down" key to Boot Manager = Menu Also add Down key to Boot Manager Menu since some serial terminals don't su= pport F2 key. Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Guo Dong Reviewed-by: Maurice Ma --- .../Library/PlatformBootManagerLib/PlatformBootManager.c | 13 +++++++++= ++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBoot= Manager.c b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootM= anager.c index a31384a..c16a6b3 100644 --- a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager= .c +++ b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootMana +++ ger.c @@ -181,6 +181,7 @@ PlatformBootManagerBeforeConsole ( { EFI_INPUT_KEY Enter; EFI_INPUT_KEY F2; + EFI_INPUT_KEY Down; EFI_BOOT_MANAGER_LOAD_OPTION BootOption; =20 PlatformConsoleInit (); @@ -201,6 +202,14 @@ PlatformBootManagerBeforeConsole ( EfiBootManagerAddKeyOptionVariable (NULL, (UINT16) BootOption.OptionNumb= er, 0, &F2, NULL); =20 // + // Also add Down key to Boot Manager Menu since some serial terminals do= n't support F2 key. + // + Down.ScanCode =3D SCAN_DOWN; + Down.UnicodeChar =3D CHAR_NULL; + EfiBootManagerGetBootManagerMenu (&BootOption); =20 + EfiBootManagerAddKeyOptionVariable (NULL, (UINT16)=20 + BootOption.OptionNumber, 0, &Down, NULL); + + // // Register UEFI Shell // PlatformRegisterFvBootOption (PcdGetPtr (PcdShellFile), L"UEFI Shell", L= OAD_OPTION_ACTIVE); @@ -239,8 +248,8 @@ PlatformBootManagerAfterConsole ( =20 Print ( L"\n" - L"F2 to enter Boot Manager Menu.\n" - L"ENTER to boot directly.\n" + L"F2 or Down to enter Boot Manager Menu.\n" + L"ENTER to boot directly.\n" L"\n" ); =20 -- 2.7.0.windows.1