public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ma, Maurice" <maurice.ma@intel.com>
To: Leo Duran <leo.duran@amd.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"brijesh.singh@amd.com" <brijesh.singh@amd.com>,
	"lersek@redhat.com" <lersek@redhat.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	"Fan, Jeff" <jeff.fan@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>,
	 "Gao, Liming" <liming.gao@intel.com>,
	"Agyeman, Prince" <prince.agyeman@intel.com>,
	"Ni, Ruiyu" <ruiyu.ni@intel.com>,
	"Steele, Kelly" <kelly.steele@intel.com>,
	"Wei, David" <david.wei@intel.com>,
	"Guo, Mang" <mang.guo@intel.com>
Subject: Re: [PATCH v4 2/9] CorebootPayloadPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe
Date: Tue, 10 Jan 2017 03:59:57 +0000	[thread overview]
Message-ID: <7AAC936950815649B5F88FAE785306C2841C35F7@ORSMSX113.amr.corp.intel.com> (raw)
In-Reply-To: <1483719899-16125-3-git-send-email-leo.duran@amd.com>

Looks good to me.
Reviewed-by: Maurice Ma <maurice.ma@intel.com>

Regards,
Maurice

-----Original Message-----
From: Leo Duran [mailto:leo.duran@amd.com] 
Sent: Friday, January 6, 2017 8:25 AM
To: edk2-devel@lists.01.org
Cc: brijesh.singh@amd.com; lersek@redhat.com; Justen, Jordan L <jordan.l.justen@intel.com>; Fan, Jeff <jeff.fan@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Ma, Maurice <maurice.ma@intel.com>; Agyeman, Prince <prince.agyeman@intel.com>; Ni, Ruiyu <ruiyu.ni@intel.com>; Steele, Kelly <kelly.steele@intel.com>; Wei, David <david.wei@intel.com>; Guo, Mang <mang.guo@intel.com>; Leo Duran <leo.duran@amd.com>
Subject: [PATCH v4 2/9] CorebootPayloadPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe

From: Brijesh Singh <brijesh.singh@amd.com>

This patch adds the new BaseIoFifoLib (IoFifoLib class) library consumed by the UefiCpuPkg/CpuIo2Dxe driver.

Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Prince Agyeman <prince.agyeman@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
Signed-off-by: Leo Duran  <leo.duran@amd.com>
---
 CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc    | 3 +++
 CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 3 +++
 2 files changed, 6 insertions(+)

diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
index cdfcb75..1647b38 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
@@ -4,6 +4,8 @@
 # Provides drivers and definitions to create uefi payload for coreboot.
 #
 # Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017, AMD Inc. All rights reserved.<BR> #
 # This program and the accompanying materials are licensed and made available under  # the terms and conditions of the BSD License that accompanies this distribution.
 # The full text of the license may be found at @@ -129,6 +131,7 @@ [LibraryClasses]
   PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
   CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
   IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
+  IoFifoLib|MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf
 !if $(PCIE_BASE) == 0
   PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf
   PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
index c35f261..6c6ad94 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
@@ -4,6 +4,8 @@
 # Provides drivers and definitions to create uefi payload for coreboot.
 #
 # Copyright (c) 2014 - 2016, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2017, AMD Inc. All rights reserved.<BR> #
 # This program and the accompanying materials are licensed and made available under  # the terms and conditions of the BSD License that accompanies this distribution.
 # The full text of the license may be found at @@ -131,6 +133,7 @@ [LibraryClasses]
   PrintLib|MdePkg/Library/BasePrintLib/BasePrintLib.inf
   CpuLib|MdePkg/Library/BaseCpuLib/BaseCpuLib.inf
   IoLib|MdePkg/Library/BaseIoLibIntrinsic/BaseIoLibIntrinsic.inf
+  IoFifoLib|MdePkg/Library/BaseIoFifoLib/BaseIoFifoLib.inf
 !if $(PCIE_BASE) == 0
   PciLib|MdePkg/Library/BasePciLibCf8/BasePciLibCf8.inf
   PciCf8Lib|MdePkg/Library/BasePciCf8Lib/BasePciCf8Lib.inf
--
1.9.1



  reply	other threads:[~2017-01-10  3:59 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-06 16:24 [PATCH v4 0/9] BaseIoFifoLib Leo Duran
2017-01-06 16:24 ` [PATCH v4 1/9] MdePkg: Add BaseIoFifoLib library Leo Duran
2017-01-06 16:24 ` [PATCH v4 2/9] CorebootPayloadPkg: Modify .DSC files that include UefiCpuPkg/CpuIo2Dxe Leo Duran
2017-01-10  3:59   ` Ma, Maurice [this message]
2017-01-06 16:24 ` [PATCH v4 3/9] DuetPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 4/9] OvmfPkg: " Leo Duran
2017-01-06 16:35   ` Laszlo Ersek
2017-01-06 16:24 ` [PATCH v4 5/9] QuarkPlatformPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 6/9] UefiCpuPkg: " Leo Duran
2017-01-06 16:24 ` [PATCH v4 7/9] Vlv2TbltDevicePkg: " Leo Duran
2017-01-09  2:16   ` Wei, David
2017-01-06 16:24 ` [PATCH v4 8/9] Modify UefiCpuPkg/CpuIo2Dxe to use new BaseIoFifoLib library Leo Duran
2017-01-06 16:24 ` [PATCH v4 9/9] Modify QemuFwCfgLib " Leo Duran
2017-01-06 16:40   ` Laszlo Ersek
2017-01-06 16:30 ` [PATCH v4 0/9] BaseIoFifoLib Duran, Leo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7AAC936950815649B5F88FAE785306C2841C35F7@ORSMSX113.amr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox