From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1C3C681E9E for ; Thu, 19 Jan 2017 20:12:25 -0800 (PST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP; 19 Jan 2017 20:12:24 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,257,1477983600"; d="scan'208";a="33009123" Received: from orsmsx109.amr.corp.intel.com ([10.22.240.7]) by orsmga002.jf.intel.com with ESMTP; 19 Jan 2017 20:12:24 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.27]) by ORSMSX109.amr.corp.intel.com ([169.254.11.220]) with mapi id 14.03.0248.002; Thu, 19 Jan 2017 20:12:24 -0800 From: "Ma, Maurice" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Agyeman, Prince" , "Gao, Liming" , "Kinney, Michael D" Thread-Topic: [PATCH 5/7] CorebootPayloadPkg: Use EfiEventGroupSignal from UefiLib Thread-Index: AQHScJCXICrx96brGkaiXiQB91ZK6qFAxVog Date: Fri, 20 Jan 2017 04:12:24 +0000 Message-ID: <7AAC936950815649B5F88FAE785306C2841C8837@ORSMSX113.amr.corp.intel.com> References: <1484636920-180432-1-git-send-email-star.zeng@intel.com> <1484636920-180432-6-git-send-email-star.zeng@intel.com> In-Reply-To: <1484636920-180432-6-git-send-email-star.zeng@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH 5/7] CorebootPayloadPkg: Use EfiEventGroupSignal from UefiLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 20 Jan 2017 04:12:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good.=20 Reviewed-by: Maurice Ma Regards, Maurice -----Original Message----- From: Zeng, Star=20 Sent: Monday, January 16, 2017 11:09 PM To: edk2-devel@lists.01.org Cc: Zeng, Star ; Ma, Maurice ; A= gyeman, Prince ; Gao, Liming ; Kinney, Michael D Subject: [PATCH 5/7] CorebootPayloadPkg: Use EfiEventGroupSignal from UefiL= ib Use EfiEventGroupSignal from UefiLib and remove InternalBdsEmptyCallbackFun= tion. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D298 Cc: Maurice Ma Cc: Prince Agyeman Cc: Liming Gao Cc: Michael Kinney Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Star Zeng --- .../PlatformBootManagerLib/PlatformBootManager.c | 25 ++----------------= ---- 1 file changed, 2 insertions(+), 23 deletions(-) diff --git a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBoot= Manager.c b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootM= anager.c index 56be30f7a041..7e92441da11f 100644 --- a/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager= .c +++ b/CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootMana +++ ger.c @@ -2,7 +2,7 @@ This file include all platform action which can be customized by IBV/OEM. =20 -Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.
+Copyright (c) 2015 - 2017, Intel Corporation. All rights reserved.
This program and the accompanying materials are licensed and made availab= le under the terms and conditions of the BSD License which accompanies thi= s distribution. The full text of the license may be found at @@ -17,16 +17= ,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR = IMPLIED. #include "PlatformConsole.h" =20 VOID -EFIAPI -InternalBdsEmptyCallbackFuntion ( - IN EFI_EVENT Event, - IN VOID *Context - ) -{ - return; -} - -VOID InstallReadyToLock ( VOID ) @@ -34,24 +24,13 @@ InstallReadyToLock ( EFI_STATUS Status; EFI_HANDLE Handle; EFI_SMM_ACCESS2_PROTOCOL *SmmAccess; - EFI_EVENT EndOfDxeEvent; =20 DEBUG((DEBUG_INFO,"InstallReadyToLock entering......\n")); // // Inform the SMM infrastructure that we're entering BDS and may run 3rd= party code hereafter // Since PI1.2.1, we need signal EndOfDxe as ExitPmAuth // - Status =3D gBS->CreateEventEx ( - EVT_NOTIFY_SIGNAL, - TPL_CALLBACK, - InternalBdsEmptyCallbackFuntion, - NULL, - &gEfiEndOfDxeEventGroupGuid, - &EndOfDxeEvent - ); - ASSERT_EFI_ERROR (Status); - gBS->SignalEvent (EndOfDxeEvent); - gBS->CloseEvent (EndOfDxeEvent); + EfiEventGroupSignal (&gEfiEndOfDxeEventGroupGuid); DEBUG((DEBUG_INFO,"All EndOfDxe callbacks have returned successfully\n")= ); =20 // -- 2.7.0.windows.1