From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=134.134.136.100; helo=mga07.intel.com; envelope-from=maurice.ma@intel.com; receiver=edk2-devel@lists.01.org Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 50228220D4C0F for ; Tue, 14 Nov 2017 07:33:23 -0800 (PST) Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Nov 2017 07:37:30 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,395,1505804400"; d="scan'208";a="149406817" Received: from orsmsx108.amr.corp.intel.com ([10.22.240.6]) by orsmga004.jf.intel.com with ESMTP; 14 Nov 2017 07:37:30 -0800 Received: from orsmsx157.amr.corp.intel.com (10.22.240.23) by ORSMSX108.amr.corp.intel.com (10.22.240.6) with Microsoft SMTP Server (TLS) id 14.3.319.2; Tue, 14 Nov 2017 07:37:30 -0800 Received: from orsmsx113.amr.corp.intel.com ([169.254.9.80]) by ORSMSX157.amr.corp.intel.com ([169.254.9.28]) with mapi id 14.03.0319.002; Tue, 14 Nov 2017 07:37:29 -0800 From: "Ma, Maurice" To: "You, Benjamin" , "edk2-devel@lists.01.org" CC: "Agyeman, Prince" Thread-Topic: [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition Thread-Index: AQHTXSR3SU2u+gaiFE6Ja8qhOMTFE6MUAlyQ Date: Tue, 14 Nov 2017 15:37:28 +0000 Message-ID: <7AAC936950815649B5F88FAE785306C2C7665076@ORSMSX113.amr.corp.intel.com> References: <20171114084113.127904-1-benjamin.you@intel.com> In-Reply-To: <20171114084113.127904-1-benjamin.you@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMzYxZjEwNGItODBmYy00MmU1LWFmZDUtMzNlNjExYzYxMTgzIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJzNWZqNVZKM3RUWWdyc0FcLzZcL3lSTStSVTRnajVlNkV0TnBjTjFuZ3dRaVwvaWx0R0lqSnRYdXRUZDNOdXJxdDM1In0= dlp-product: dlpe-windows dlp-version: 11.0.0.116 dlp-reaction: no-action x-originating-ip: [10.22.254.140] MIME-Version: 1.0 Subject: Re: [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space addition X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 15:33:23 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Looks good to me. Reviewed-by: Maurice Ma Thanks Maurice -----Original Message----- From: You, Benjamin=20 Sent: Tuesday, November 14, 2017 12:41 AM To: edk2-devel@lists.01.org Cc: Ma, Maurice ; Agyeman, Prince Subject: [PATCH] CorebootModulePkg/CbSupportDxe: Remove duplicated IO Space= addition Since UefiCpuPkg's CpuDxe Driver already adds Local Apic's MMIO space to GC= D, CorebootModulePkg's CbSupportDxe should not do this again. Doing this ag= ain causes error return status from GCD service, and ASSERT (FALSE) with de= bug build, so the duplicated addition is removed. Cc: Maurice Ma Cc: Prince Agyeman Contributed-under: TianoCore Contribution Agreement 1.0 Signed-off-by: Benjamin You --- CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c b/CorebootModule= Pkg/CbSupportDxe/CbSupportDxe.c index 24bacf815c..c526c9e871 100755 --- a/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c +++ b/CorebootModulePkg/CbSupportDxe/CbSupportDxe.c @@ -140,9 +140,6 @@ CbDxeEntryPoint ( // // Report MMIO/IO Resources // - Status =3D CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo,= 0xFEE00000, SIZE_1MB, 0, SystemTable); // LAPIC - ASSERT_EFI_ERROR (Status); - Status =3D CbReserveResourceInGcd (TRUE, EfiGcdMemoryTypeMemoryMappedIo,= 0xFEC00000, SIZE_4KB, 0, SystemTable); // IOAPIC ASSERT_EFI_ERROR (Status); =20 -- 2.14.3.windows.1