From: "Ma, Maurice" <maurice.ma@intel.com>
To: Wonkyu Kim <norwayforest92@gmail.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Williams, Hannah" <hannah.williams@intel.com>,
"gaumless@gmail.com" <gaumless@gmail.com>,
"Zhao, Lijian" <lijian.zhao@intel.com>,
"Kim, Wonkyu" <wonkyu.kim@intel.com>,
"stefan.reinauer@coreboot.org" <stefan.reinauer@coreboot.org>,
"Agyeman, Prince" <prince.agyeman@intel.com>
Subject: Re: [PATCH] CorebootPayloadPkg: don't use serial output for Release build
Date: Tue, 16 Oct 2018 00:13:28 +0000 [thread overview]
Message-ID: <7AAC936950815649B5F88FAE785306C2E4F82DBD@FMSMSX153.amr.corp.intel.com> (raw)
In-Reply-To: <f5655912dbcf73e43c086771f8001266e700d9f9.1539626732.git.wonkyu.kim@intel.com>
Hi, Kim,
Looks good to me.
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
-Maurice
-----Original Message-----
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wonkyu Kim
Sent: Monday, October 15, 2018 15:45
To: edk2-devel@lists.01.org
Cc: Williams, Hannah <hannah.williams@intel.com>; gaumless@gmail.com; Zhao, Lijian <lijian.zhao@intel.com>; Kim, Wonkyu <wonkyu.kim@intel.com>; stefan.reinauer@coreboot.org; Agyeman, Prince <prince.agyeman@intel.com>
Subject: [edk2] [PATCH] CorebootPayloadPkg: don't use serial output for Release build
From: Wonkyu Kim <wonkyu.kim@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Wonkyu Kim <wonkyu.kim@intel.com>
---
CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 4 ++++
CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++
2 files changed, 8 insertions(+)
diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
index b6cdb697a5b0..7d5052be9301 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
@@ -263,7 +263,11 @@
#
################################################################################
[PcdsFeatureFlag]
+!if $(TARGET) == DEBUG
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
+!else
+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
+!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
index c3fe099e5fec..0484e941cce7 100644
--- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
+++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
@@ -263,7 +263,11 @@
#
################################################################################
[PcdsFeatureFlag]
+!if $(TARGET) == DEBUG
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE
+!else
+ gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE
+!endif
gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE
gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE
gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE
--
2.17.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org
https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2018-10-16 0:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-15 22:44 [PATCH] CorebootPayloadPkg: don't use serial output for Release build Wonkyu Kim
2018-10-16 0:13 ` Ma, Maurice [this message]
2018-10-17 2:45 ` You, Benjamin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AAC936950815649B5F88FAE785306C2E4F82DBD@FMSMSX153.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox