From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.115; helo=mga14.intel.com; envelope-from=maurice.ma@intel.com; receiver=edk2-devel@lists.01.org Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9017521173C72 for ; Mon, 15 Oct 2018 17:13:30 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 15 Oct 2018 17:13:29 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,386,1534834800"; d="scan'208";a="97727416" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga004.fm.intel.com with ESMTP; 15 Oct 2018 17:13:29 -0700 Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.319.2; Mon, 15 Oct 2018 17:13:29 -0700 Received: from fmsmsx153.amr.corp.intel.com ([169.254.9.169]) by FMSMSX109.amr.corp.intel.com ([169.254.15.83]) with mapi id 14.03.0319.002; Mon, 15 Oct 2018 17:13:29 -0700 From: "Ma, Maurice" To: Wonkyu Kim , "edk2-devel@lists.01.org" CC: "Williams, Hannah" , "gaumless@gmail.com" , "Zhao, Lijian" , "Kim, Wonkyu" , "stefan.reinauer@coreboot.org" , "Agyeman, Prince" Thread-Topic: [edk2] [PATCH] CorebootPayloadPkg: don't use serial output for Release build Thread-Index: AQHUZNinywevoNzsUUChIo0snsNWDqUg+D3A Date: Tue, 16 Oct 2018 00:13:28 +0000 Message-ID: <7AAC936950815649B5F88FAE785306C2E4F82DBD@FMSMSX153.amr.corp.intel.com> References: In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNWEzMzc4YjAtMjk3Yy00YjNmLWE0YWUtZTY4MDI0YWQzOTkyIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRjh3Ukt4Nk1remlwcytJV0dKUjJcL1UzM0lYMGlTQWphYjhSaDRLa241N0FkRkVwR1l6MDk0Smw2RzM3R3RRSVkifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.1.200.108] MIME-Version: 1.0 Subject: Re: [PATCH] CorebootPayloadPkg: don't use serial output for Release build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 16 Oct 2018 00:13:30 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Kim, Looks good to me. Reviewed-by: Maurice Ma -Maurice -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Wonk= yu Kim Sent: Monday, October 15, 2018 15:45 To: edk2-devel@lists.01.org Cc: Williams, Hannah ; gaumless@gmail.com; Zhao,= Lijian ; Kim, Wonkyu ; stefan= .reinauer@coreboot.org; Agyeman, Prince Subject: [edk2] [PATCH] CorebootPayloadPkg: don't use serial output for Rel= ease build From: Wonkyu Kim Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Wonkyu Kim --- CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 4 ++++ CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc b/CorebootPayloa= dPkg/CorebootPayloadPkgIa32.dsc index b6cdb697a5b0..7d5052be9301 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc @@ -263,7 +263,11 @@ # ##########################################################################= ###### [PcdsFeatureFlag] +!if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE +!else + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE +!endif gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE diff --git a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc b/CorebootPay= loadPkg/CorebootPayloadPkgIa32X64.dsc index c3fe099e5fec..0484e941cce7 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc +++ b/CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc @@ -263,7 +263,11 @@ # ##########################################################################= ###### [PcdsFeatureFlag] +!if $(TARGET) =3D=3D DEBUG gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|TRUE +!else + gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseSerial|FALSE +!endif gEfiMdeModulePkgTokenSpaceGuid.PcdStatusCodeUseMemory|FALSE gEfiMdeModulePkgTokenSpaceGuid.PcdDxeIplSwitchToLongMode|TRUE gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE --=20 2.17.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel