From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.136; helo=mga12.intel.com; envelope-from=maurice.ma@intel.com; receiver=edk2-devel@lists.01.org Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4AF652118AA9F for ; Fri, 2 Nov 2018 08:02:53 -0700 (PDT) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga106.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2018 08:02:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,456,1534834800"; d="scan'208";a="93229951" Received: from orsmsx101.amr.corp.intel.com ([10.22.225.128]) by FMSMGA003.fm.intel.com with ESMTP; 02 Nov 2018 08:02:51 -0700 Received: from orsmsx155.amr.corp.intel.com (10.22.240.21) by ORSMSX101.amr.corp.intel.com (10.22.225.128) with Microsoft SMTP Server (TLS) id 14.3.408.0; Fri, 2 Nov 2018 08:02:51 -0700 Received: from orsmsx105.amr.corp.intel.com ([169.254.2.237]) by ORSMSX155.amr.corp.intel.com ([169.254.7.161]) with mapi id 14.03.0415.000; Fri, 2 Nov 2018 08:02:51 -0700 From: "Ma, Maurice" To: "Zhang, Shenglei" CC: "Agyeman, Prince" , "You, Benjamin" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH v2 1/5] CorebootPayloadPkg: Remove EdkShellBinPkg in FDF Thread-Index: AQHUcaveNNs34RhwOU2bz4rL110gAqU8kgGg Date: Fri, 2 Nov 2018 15:02:50 +0000 Message-ID: <7AAC936950815649B5F88FAE785306C2E4FA37B1@ORSMSX105.amr.corp.intel.com> References: <20181101062639.9924-1-shenglei.zhang@intel.com> <20181101062639.9924-2-shenglei.zhang@intel.com> In-Reply-To: <20181101062639.9924-2-shenglei.zhang@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYzc4YTI4ZWUtMTVjMC00YWNhLWJmMDctMDUwNDYxODU0ODc3IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiUDNjS3hMMnpzcWM0Nm41VjdPVXFrU0twaWlvNlArM3pmUExadGE5OFBMTitQUlNzUjlraVpqUlRRenhMdENkUiJ9 dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.22.254.138] MIME-Version: 1.0 Subject: Re: [PATCH v2 1/5] CorebootPayloadPkg: Remove EdkShellBinPkg in FDF X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 15:02:53 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Hi, Shenglei, Thank you for the patch. I saw many other references in CorebootPayloadPkg DSC files for FULL_BIN. = I think we should remove all of them from both DSC and FDF at the same tim= e. The current SHELL_TYPE defined in DSC file is FULL_BIN. It needs to be ch= anged to UEFI_BIN. Otherwise, the final image will not have any Shell mod= ule included since FULL_BIN is removed in FDF.=20 Thanks Maurice -----Original Message----- From: Zhang, Shenglei=20 Sent: Wednesday, October 31, 2018 23:27 To: edk2-devel@lists.01.org Cc: Ma, Maurice ; Agyeman, Prince ; You, Benjamin Subject: [PATCH v2 1/5] CorebootPayloadPkg: Remove EdkShellBinPkg in FDF Remove EdkShellBinPkg in CorebootPayloadPkg.fdf. https://bugzilla.tianocore.org/show_bug.cgi?id=3D1108 Cc: Maurice Ma Cc: Prince Agyeman Cc: Benjamin You Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: shenglei --- CorebootPayloadPkg/CorebootPayloadPkg.fdf | 8 -------- 1 file changed, 8 deletions(-) diff --git a/CorebootPayloadPkg/CorebootPayloadPkg.fdf b/CorebootPayloadPkg= /CorebootPayloadPkg.fdf index 7994f0c949..741a5c232e 100644 --- a/CorebootPayloadPkg/CorebootPayloadPkg.fdf +++ b/CorebootPayloadPkg/CorebootPayloadPkg.fdf @@ -185,14 +185,6 @@ INF ShellPkg/DynamicCommand/DpDynamicCommand/DpDynamic= Command.inf INF ShellPkg/Application/Shell/Shell.inf !endif =20 -!if $(SHELL_TYPE) =3D=3D FULL_BIN -!if $(ARCH) =3D=3D IA32 -INF RuleOverride =3D BINARY USE =3D IA32 EdkShellBinPkg/FullShell/FullShe= ll.inf -!else -INF RuleOverride =3D BINARY USE =3D X64 EdkShellBinPkg/FullShell/FullShel= l.inf -!endif -!endif - !if $(SHELL_TYPE) =3D=3D MIN_BIN !if $(ARCH) =3D=3D IA32 INF RuleOverride =3D BINARY USE =3D IA32 ShellBinPkg/MinUefiShell/MinUefi= Shell.inf --=20 2.18.0.windows.1