Re: Commit Partitioning - Re: [edk2-devel] [edk2] [PATCH V2] UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader

["Ma, Maurice" <maurice.ma@intel.com>]

Hi, Jordan

That is a good point.   Smaller patch will always help the review easier.  
Thank you for pointing it out.   

Thanks
Maurice
> -----Original Message-----
> From: Justen, Jordan L
> Sent: Monday, April 15, 2019 15:28
> To: Dong, Guo <guo.dong@intel.com>; Ma, Maurice
> <maurice.ma@intel.com>; devel@edk2.groups.io
> Cc: Agyeman, Prince <prince.agyeman@intel.com>; You, Benjamin
> <benjamin.you@intel.com>; Dong, Guo <guo.dong@intel.com>
> Subject: Commit Partitioning - Re: [edk2-devel] [edk2] [PATCH V2]
> UefiPayloadPkg: Enhance UEFI payload for coreboot and Slim Bootloader
> 
> On 2019-04-11 08:51:22, Guo Dong wrote:
> > CorebootModulePkg and CorebootPayloadPkg originally supports coreboot
> only.
> > In order to support other bootloaders, such as Slim Bootloader, they
> > need be updated to be more generic.
> > UEFI Payload (UefiPayloadPkg) a converged package from
> > CorebootModulePkg and CorebootPayloadPkg with following updates:
> > a. Support both coreboot and Slim Bootloader b. Removed
> > SataControllerDxe and BaseSerialPortLib16550 to use EDK2 modules c.
> > Support passing bootloader parameter to UEFI payload, e.g. coreboot
> >    table from coreboot or HOB list from Slim Bootloader d. Using
> > GraphicsOutputDxe from EDK2 with minor change instead of FbGop e.
> > Remove the dependency to IntelFrameworkPkg and
> IntelFrameworkModulePkg
> >    and QuarkSocPkg
> > f. Use BaseDebugLibSerialPort library as DebugLib g. Use HPET timer,
> > drop legacy 8254 timer support h. Use BaseXApicX2ApicLib instead of
> > BaseXApicLib i. Remove HOB gUefiFrameBufferInfoGuid to use EDK2
> > graphics HOBs.
> > j. Other clean ups
> 
> Why this wasn't split into *at least* 10 patches given the 10 major bullet
> points listed here?
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Commit-Partitioning
> 
> >
> > On how UefiPayloadPkg could work with coreboot/Slim Bootloader, please
> > refer UefiPayloadPkg/BuildAndIntegrationInstructions.txt
> >
> > Once UefiPayloadPkg is checked-in, CorebootModulePkg and
> > CorebootPayloadPkg could be retired.
> >
> > Signed-off-by: Guo Dong <guo.dong@intel.com>
> > Reviewed-by: Maurice Ma <maurice.ma@intel.com>
> 
> Same question to Maurice.
> 
> Maybe something to consider in the future.
> 
> -Jordan
> 
> > ---
> >  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.c                               | 158
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.h                               |  30
> ++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/BlSupportDxe/BlSupportDxe.inf                             |  58
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/BlSupportPei/BlSupportPei.c                               | 566
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/BlSupportPei/BlSupportPei.h                               |  39
> +++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/BlSupportPei/BlSupportPei.inf                             |  73
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++
> >  UefiPayloadPkg/BuildAndIntegrationInstructions.txt                       |  82
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++
> >  UefiPayloadPkg/GraphicsOutputDxe/ComponentName.c                         | 184
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++
> >  UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutput.c                        | 739
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutput.h                        |  53
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/GraphicsOutputDxe/GraphicsOutputDxe.inf                   |  53
> +++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Include/Coreboot.h                                        | 249
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++
> >  UefiPayloadPkg/Include/Guid/AcpiBoardInfoGuid.h                          |  29
> +++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Include/Guid/MemoryMapInfoGuid.h                          |  36
> ++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Include/Guid/SerialPortInfoGuid.h                         |  31
> +++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Include/Guid/SystemTableInfoGuid.h                        |  26
> ++++++++++++++++++++++++++
> >  UefiPayloadPkg/Include/Library/BlParseLib.h                              | 120
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++
> >  UefiPayloadPkg/Include/Library/PlatformSupportLib.h                      |  28
> ++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.c                       | 270
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf                     |  40
> ++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/CbParseLib/CbParseLib.c                           | 560
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/CbParseLib/CbParseLib.inf                         |  39
> +++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridge.h                  |  80
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++
> >  UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c               | 222
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf             |  41
> +++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c           |
> 584
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++
> >  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.c
> | 265
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++
> >
> UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManager.h
> | 132
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++
> >
> UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.i
> nf |  71
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++
> >  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
> | 599
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++
> >  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.h
> |  70
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++
> >  UefiPayloadPkg/Library/PlatformBootManagerLib/PlatformData.c             |
> 39 +++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c                 |  98
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf               |  39
> +++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/PlatformSupportLibNull/PlatformSupportLibNull.c
> |  29 +++++++++++++++++++++++++++++
> >
> UefiPayloadPkg/Library/PlatformSupportLibNull/PlatformSupportLibNull.inf
> |  28 ++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c                   | 171
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/ResetSystemLib/ResetSystemLib.inf                 |  40
> ++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/SblParseLib/SblParseLib.c                         | 223
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/Library/SblParseLib/SblParseLib.inf                       |  46
> ++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/SecCore/FindPeiCore.c                                     | 193
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++
> >  UefiPayloadPkg/SecCore/Ia32/SecEntry.nasm                                |  78
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++
> >  UefiPayloadPkg/SecCore/Ia32/Stack.nasm                                   |  72
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++
> >  UefiPayloadPkg/SecCore/SecCore.inf                                       |  58
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/SecCore/SecMain.c                                         | 288
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/SecCore/SecMain.h                                         | 131
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++
> >  UefiPayloadPkg/UefiPayloadPkg.dec                                        |  71
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++
> >  UefiPayloadPkg/UefiPayloadPkg.fdf                                        | 288
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/UefiPayloadPkgIa32.dsc                                    | 573
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> +++++++++++++++++++++++++++++++++++++++++++++++++++
> >  UefiPayloadPkg/UefiPayloadPkgIa32X64.dsc                                 | 574
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> ++++++++++++++++++++++++++++++++++++++++++++++++++++
> >  50 files changed, 8566 insertions(+)