From: "Ma, Maurice" <maurice.ma@intel.com>
To: "Dong, Guo" <guo.dong@intel.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>
Cc: "Agyeman, Prince" <prince.agyeman@intel.com>,
"You, Benjamin" <benjamin.you@intel.com>
Subject: Re: [edk2-devel] [PATCH 0/2] Retire CorebootModulePkg and CorebootPayloadPkg
Date: Thu, 9 May 2019 00:44:04 +0000 [thread overview]
Message-ID: <7AAC936950815649B5F88FAE785306C2F6F68CD6@ORSMSX105.amr.corp.intel.com> (raw)
In-Reply-To: <20190507222728.28296-1-guo.dong@intel.com>
This patchset looks good me.
Reviewed-by: Maurice Ma <maurice.ma@intel.com>
Regards,
Maurice
> -----Original Message-----
> From: Dong, Guo
> Sent: Tuesday, May 7, 2019 15:27
> To: devel@edk2.groups.io
> Cc: Ma, Maurice <maurice.ma@intel.com>; Agyeman, Prince
> <prince.agyeman@intel.com>; You, Benjamin <benjamin.you@intel.com>;
> Dong, Guo <guo.dong@intel.com>
> Subject: [edk2-devel] [PATCH 0/2] Retire CorebootModulePkg and
> CorebootPayloadPkg
>
> Since UefiPayloadPkg in EDK2 supports Coreboot and Slim Bootloader, and
> no concerns were received for the RFC to remove CorebootModulePkg and
> CorebootPayloadPkg from EDK2
> (https://edk2.groups.io/g/devel/message/39126),
> here is the action patch to remove CorebootModulePkg and
> CorebootPayloadPkg.
>
> Guo Dong (2):
> Retire CorebootModulePkg from EDK2
> Retire CorebootPayloadPkg from EDK2
>
> CorebootModulePkg/CbSupportDxe/CbSupportDxe.c | 158 --
> CorebootModulePkg/CbSupportDxe/CbSupportDxe.h | 30 -
> CorebootModulePkg/CbSupportDxe/CbSupportDxe.inf | 60 -
> CorebootModulePkg/CbSupportPei/CbSupportPei.c | 440 ------
> CorebootModulePkg/CbSupportPei/CbSupportPei.h | 42 -
> CorebootModulePkg/CbSupportPei/CbSupportPei.inf | 74 -
> CorebootModulePkg/CorebootModulePkg.dec | 59 -
> CorebootModulePkg/Include/Coreboot.h | 249 ----
> CorebootModulePkg/Include/Guid/AcpiBoardInfoGuid.h | 26 -
> .../Include/Guid/FrameBufferInfoGuid.h | 34 -
> .../Include/Guid/SystemTableInfoGuid.h | 24 -
> CorebootModulePkg/Include/Library/CbParseLib.h | 186 ---
> .../Include/Library/CbPlatformSupportLib.h | 28 -
> .../BaseSerialPortLib16550.c | 1089 --------------
> .../BaseSerialPortLib16550.inf | 42 -
> .../BaseSerialPortLib16550.uni | 16 -
> CorebootModulePkg/Library/CbParseLib/CbParseLib.c | 721 ---------
> .../Library/CbParseLib/CbParseLib.inf | 39 -
> .../CbPlatformSupportLibNull.c | 29 -
> .../CbPlatformSupportLibNull.inf | 29 -
> .../CbPlatformSupportLibNull.uni | 14 -
> .../SataControllerDxe/ComponentName.c | 170 ---
> .../SataControllerDxe/SataController.c | 1043 -------------
> .../SataControllerDxe/SataController.h | 536 -------
> .../SataControllerDxe/SataControllerDxe.inf | 43 -
> CorebootModulePkg/SecCore/FindPeiCore.c | 193 ---
> CorebootModulePkg/SecCore/Ia32/SecEntry.asm | 72 -
> CorebootModulePkg/SecCore/Ia32/SecEntry.nasm | 66 -
> CorebootModulePkg/SecCore/Ia32/Stack.asm | 76 -
> CorebootModulePkg/SecCore/Ia32/Stack.nasm | 72 -
> CorebootModulePkg/SecCore/SecCore.inf | 57 -
> CorebootModulePkg/SecCore/SecMain.c | 285 ----
> CorebootModulePkg/SecCore/SecMain.h | 128 --
> .../BuildAndIntegrationInstructions.txt | 82 --
> CorebootPayloadPkg/CorebootPayloadPkg.dec | 48 -
> CorebootPayloadPkg/CorebootPayloadPkg.fdf | 285 ----
> CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc | 574 --------
> CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc | 575 --------
> CorebootPayloadPkg/FbGop/ComponentName.c | 306 ----
> CorebootPayloadPkg/FbGop/FbGop.c | 1536 --------------------
> CorebootPayloadPkg/FbGop/FbGop.h | 413 ------
> CorebootPayloadPkg/FbGop/FbGop.inf | 63 -
> .../Library/AcpiTimerLib/AcpiTimerLib.c | 270 ----
> .../Library/AcpiTimerLib/AcpiTimerLib.inf | 40 -
> .../Library/PciHostBridgeLib/PciHostBridge.h | 80 -
> .../Library/PciHostBridgeLib/PciHostBridgeLib.c | 222 ---
> .../Library/PciHostBridgeLib/PciHostBridgeLib.inf | 41 -
> .../PciHostBridgeLib/PciHostBridgeSupport.c | 584 --------
> .../PlatformBootManagerLib/PlatformBootManager.c | 265 ----
> .../PlatformBootManagerLib/PlatformBootManager.h | 121 --
> .../PlatformBootManagerLib.inf | 74 -
> .../PlatformBootManagerLib/PlatformConsole.c | 611 --------
> .../PlatformBootManagerLib/PlatformConsole.h | 70 -
> .../Library/PlatformBootManagerLib/PlatformData.c | 19 -
> .../Library/PlatformHookLib/PlatformHookLib.c | 105 --
> .../Library/PlatformHookLib/PlatformHookLib.inf | 39 -
> .../Library/ResetSystemLib/ResetSystemLib.c | 221 ---
> .../Library/ResetSystemLib/ResetSystemLib.inf | 38 -
> 58 files changed, 12812 deletions(-)
> delete mode 100755 CorebootModulePkg/CbSupportDxe/CbSupportDxe.c
> delete mode 100644 CorebootModulePkg/CbSupportDxe/CbSupportDxe.h
> delete mode 100644 CorebootModulePkg/CbSupportDxe/CbSupportDxe.inf
> delete mode 100755 CorebootModulePkg/CbSupportPei/CbSupportPei.c
> delete mode 100644 CorebootModulePkg/CbSupportPei/CbSupportPei.h
> delete mode 100644 CorebootModulePkg/CbSupportPei/CbSupportPei.inf
> delete mode 100644 CorebootModulePkg/CorebootModulePkg.dec
> delete mode 100644 CorebootModulePkg/Include/Coreboot.h
> delete mode 100644
> CorebootModulePkg/Include/Guid/AcpiBoardInfoGuid.h
> delete mode 100644
> CorebootModulePkg/Include/Guid/FrameBufferInfoGuid.h
> delete mode 100644
> CorebootModulePkg/Include/Guid/SystemTableInfoGuid.h
> delete mode 100644 CorebootModulePkg/Include/Library/CbParseLib.h
> delete mode 100644
> CorebootModulePkg/Include/Library/CbPlatformSupportLib.h
> delete mode 100644
> CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550
> .c
> delete mode 100644
> CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550
> .inf
> delete mode 100644
> CorebootModulePkg/Library/BaseSerialPortLib16550/BaseSerialPortLib16550
> .uni
> delete mode 100644 CorebootModulePkg/Library/CbParseLib/CbParseLib.c
> delete mode 100644
> CorebootModulePkg/Library/CbParseLib/CbParseLib.inf
> delete mode 100644
> CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportL
> ibNull.c
> delete mode 100644
> CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportL
> ibNull.inf
> delete mode 100644
> CorebootModulePkg/Library/CbPlatformSupportLibNull/CbPlatformSupportL
> ibNull.uni
> delete mode 100644
> CorebootModulePkg/SataControllerDxe/ComponentName.c
> delete mode 100644
> CorebootModulePkg/SataControllerDxe/SataController.c
> delete mode 100644
> CorebootModulePkg/SataControllerDxe/SataController.h
> delete mode 100644
> CorebootModulePkg/SataControllerDxe/SataControllerDxe.inf
> delete mode 100644 CorebootModulePkg/SecCore/FindPeiCore.c
> delete mode 100644 CorebootModulePkg/SecCore/Ia32/SecEntry.asm
> delete mode 100644 CorebootModulePkg/SecCore/Ia32/SecEntry.nasm
> delete mode 100644 CorebootModulePkg/SecCore/Ia32/Stack.asm
> delete mode 100644 CorebootModulePkg/SecCore/Ia32/Stack.nasm
> delete mode 100644 CorebootModulePkg/SecCore/SecCore.inf
> delete mode 100644 CorebootModulePkg/SecCore/SecMain.c
> delete mode 100644 CorebootModulePkg/SecCore/SecMain.h
> delete mode 100644
> CorebootPayloadPkg/BuildAndIntegrationInstructions.txt
> delete mode 100644 CorebootPayloadPkg/CorebootPayloadPkg.dec
> delete mode 100644 CorebootPayloadPkg/CorebootPayloadPkg.fdf
> delete mode 100644 CorebootPayloadPkg/CorebootPayloadPkgIa32.dsc
> delete mode 100644 CorebootPayloadPkg/CorebootPayloadPkgIa32X64.dsc
> delete mode 100644 CorebootPayloadPkg/FbGop/ComponentName.c
> delete mode 100644 CorebootPayloadPkg/FbGop/FbGop.c delete mode
> 100644 CorebootPayloadPkg/FbGop/FbGop.h delete mode 100644
> CorebootPayloadPkg/FbGop/FbGop.inf
> delete mode 100644
> CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.c
> delete mode 100644
> CorebootPayloadPkg/Library/AcpiTimerLib/AcpiTimerLib.inf
> delete mode 100644
> CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridge.h
> delete mode 100644
> CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c
> delete mode 100644
> CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf
> delete mode 100644
> CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManag
> er.c
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManag
> er.h
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformBootManag
> erLib.inf
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.c
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformConsole.h
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformBootManagerLib/PlatformData.c
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.c
> delete mode 100644
> CorebootPayloadPkg/Library/PlatformHookLib/PlatformHookLib.inf
> delete mode 100644
> CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.c
> delete mode 100644
> CorebootPayloadPkg/Library/ResetSystemLib/ResetSystemLib.inf
>
> --
> 2.16.2.windows.1
prev parent reply other threads:[~2019-05-09 0:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-07 22:27 [edk2-devel] [PATCH 0/2] Retire CorebootModulePkg and CorebootPayloadPkg Guo Dong
2019-05-07 22:27 ` [edk2-devel] [PATCH 1/2] Retire CorebootModulePkg from EDK2 Guo Dong
2019-05-07 22:27 ` [edk2-devel] [PATCH 2/2] Retire CorebootPayloadPkg " Guo Dong
2019-05-09 0:44 ` Ma, Maurice [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AAC936950815649B5F88FAE785306C2F6F68CD6@ORSMSX105.amr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox