From: "Sami Mujawar" <sami.mujawar@arm.com>
To: Sunny Wang <Sunny.Wang@arm.com>,
"devel@edk2.groups.io" <devel@edk2.groups.io>,
Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>,
Matteo Carlini <Matteo.Carlini@arm.com>,
Akanksha Jain <Akanksha.Jain2@arm.com>,
Ben Adderson <Ben.Adderson@arm.com>,
Pierre Gondois <Pierre.Gondois@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2
Date: Mon, 14 Mar 2022 15:00:09 +0000 [thread overview]
Message-ID: <7AAF43C2-964A-436B-ACED-0CAA5D781528@arm.com> (raw)
In-Reply-To: <DB8PR08MB3993B25B1E1CB1479AD16C1A850F9@DB8PR08MB3993.eurprd08.prod.outlook.com>
Hi All,
Azure pipeline jobs are failing due to broken download link for the GCC Arm 10.3-2021.07 compiler, see https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=44398&view=logs&j=9b8d87a5-bd93-5358-8ffa-588e312c4376&t=aacec3cc-93ca-52e0-9354-41df8e192656
I am working to get the download links fixed. In the meantime, some patches may not get merged in edk2.
Apologies for the inconvenience.
Regards,
Sami Mujawar
On 14/03/2022, 11:49, "Sunny Wang" <Sunny.Wang@arm.com> wrote:
I tested this patch as well and confirmed this patch fixed the FWTS failure below. Thanks, Sami.
- dbg2: DBG2 Device 'COM0' not found in ACPI object name space.
Tested-by: Sunny Wang <sunny.wang@arm.com>
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Jagadeesh Ujja via groups.io
Sent: 14 March 2022 05:01
To: devel@edk2.groups.io; Sami Mujawar <Sami.Mujawar@arm.com>
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>; Matteo Carlini <Matteo.Carlini@arm.com>; Akanksha Jain <Akanksha.Jain2@arm.com>; Ben Adderson <Ben.Adderson@arm.com>; Pierre Gondois <Pierre.Gondois@arm.com>
Subject: Re: [edk2-devel] [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2
Hi Sami,
The patch is tested and looks good to me:
Tested-by: Jagadeesh Ujja <Jagadeesh.Ujja@arm.com>
On Fri, Mar 11, 2022 at 6:38 PM PierreGondois <pierre.gondois@arm.com> wrote:
>
> Hi Sami,
> The patch looks good to me:
>
> Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>
>
> On 3/10/22 18:39, Sami Mujawar wrote:
> > According to the Debug Port Table 2 (DBG2) specification,
> > February 17, 2021, the NamespaceString is a NULL terminated
> > ASCII string that consists of a fully qualified reference
> > to the object that represents the serial port device in the
> > ACPI namespace.
> >
> > The DBG2 table generator did not populate the full device
> > path for the serial port device, and this results in a FWTS
> > test failure.
> >
> > Therefore, populate the full namespace device path for the
> > serial port in DBG2 table.
> >
> > Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
> > ---
> > The changes can be seen at:
> > https://github.com/samimujawar/edk2/tree/2105_dbg2_generator_namestring_issue_v1
> >
> > DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 +++++++---
> > 1 file changed, 7 insertions(+), 3 deletions(-)
> >
> > diff --git a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > index 3d513dbd1fbe8c47d270a9e639b2797098201d91..f6dfb3d94c10980a0e7712ce9427648b69974061 100644
> > --- a/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > +++ b/DynamicTablesPkg/Library/Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c
> > @@ -1,7 +1,7 @@
> > /** @file
> > DBG2 Table Generator
> >
> > - Copyright (c) 2017 - 2021, Arm Limited. All rights reserved.<BR>
> > + Copyright (c) 2017 - 2022, Arm Limited. All rights reserved.<BR>
> >
> > SPDX-License-Identifier: BSD-2-Clause-Patent
> >
> > @@ -55,13 +55,17 @@ Requirements:
> > */
> > #define NAME_STR_DBG_PORT0 "COM0"
> >
> > +/** A string representing the full path name of the debug port 0.
> > +*/
> > +#define NAMESPACE_STR_DBG_PORT0 "\\_SB_.COM0"
> > +
> > /** An UID representing the debug port 0.
> > */
> > #define UID_DBG_PORT0 0
> >
> > /** The length of the namespace string.
> > */
> > -#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAME_STR_DBG_PORT0)
> > +#define DBG2_NAMESPACESTRING_FIELD_SIZE sizeof (NAMESPACE_STR_DBG_PORT0)
> >
> > /** The PL011 UART address range length.
> > */
> > @@ -166,7 +170,7 @@ DBG2_TABLE AcpiDbg2 = {
> > 0, // {Template}: Serial Port Subtype
> > 0, // {Template}: Serial Port Base Address
> > PL011_UART_LENGTH,
> > - NAME_STR_DBG_PORT0
> > + NAMESPACE_STR_DBG_PORT0
> > )
> > }
> > };
>
>
>
>
>
IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium. Thank you.
next prev parent reply other threads:[~2022-03-14 15:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-10 17:39 [PATCH v1 1/1] DynamicTablesPkg: Fix serial port namespace path in DBG2 Sami Mujawar
2022-03-11 13:08 ` PierreGondois
2022-03-14 5:00 ` [edk2-devel] " Jagadeesh Ujja
2022-03-14 11:49 ` Sunny Wang
2022-03-14 15:00 ` Sami Mujawar [this message]
2022-03-15 14:46 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7AAF43C2-964A-436B-ACED-0CAA5D781528@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox