From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=192.55.52.151; helo=mga17.intel.com; envelope-from=zailiang.sun@intel.com; receiver=edk2-devel@lists.01.org Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id F20062119BBFA for ; Tue, 18 Dec 2018 19:13:03 -0800 (PST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Dec 2018 19:13:02 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,371,1539673200"; d="scan'208";a="101758861" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga006.jf.intel.com with ESMTP; 18 Dec 2018 19:13:02 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 18 Dec 2018 19:13:02 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.408.0; Tue, 18 Dec 2018 19:13:01 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.203]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.59]) with mapi id 14.03.0415.000; Wed, 19 Dec 2018 11:13:00 +0800 From: "Sun, Zailiang" To: "Qian, Yi" , "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Wei, David" Thread-Topic: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement Thread-Index: AQHUk5foWZ/wdAeBn0KxA6hm/XKRXKWDP8cAgACUwACAAPB6AIAAAIuAgAAdRoCAAIdNsA== Date: Wed, 19 Dec 2018 03:12:59 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850BFCBDD@SHSMSX104.ccr.corp.intel.com> References: <1544783322-17436-1-git-send-email-star.zeng@intel.com> <1544783322-17436-7-git-send-email-star.zeng@intel.com> <0C09AFA07DD0434D9E2A0C6AEB0483104022170A@shsmsx102.ccr.corp.intel.com> <0C09AFA07DD0434D9E2A0C6AEB04831040221999@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiYmY3YWI5MjQtOWNkNy00MjljLWE5ZDgtYmEzNzY1OWUzYjc2IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiRWtXVDk5OHJkekhaUUZTUlphTzdxc25vT0VHeFFqbitjVmFIdVdJbmJQWkQrMWtic3BnUFhhWlU3YWhWMGVcL20ifQ== x-ctpclassification: CTP_NT dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' statement X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 19 Dec 2018 03:13:04 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zailiang Sun > -----Original Message----- > From: Qian, Yi > Sent: Wednesday, December 19, 2018 11:08 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Wei, David > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement >=20 > Reviewed-by: Yi Qian >=20 > Thanks > Qian Yi >=20 > -----Original Message----- > From: Zeng, Star > Sent: Wednesday, December 19, 2018 9:23 AM > To: Qian, Yi ; edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Wei, David ; > Zeng, Star > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement >=20 > Yi, Zailiang and David, >=20 > So, is it ok to give RB to the patch from you? :) >=20 >=20 > Thanks, > Star > -----Original Message----- > From: Qian, Yi > Sent: Wednesday, December 19, 2018 9:21 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Wei, David > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement >=20 > It's fine. Thank you for your update. >=20 > Thanks > Qian Yi >=20 > -----Original Message----- > From: Zeng, Star > Sent: Tuesday, December 18, 2018 7:01 PM > To: Qian, Yi ; edk2-devel@lists.01.org > Cc: Sun, Zailiang ; Wei, David ; > Zeng, Star > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement >=20 > Yi, >=20 > Good question. >=20 > With the patch, the code can be compiled and the image can boot to setup. > The image could not find shell, but that is not related to the patch. > It is because > https://github.com/tianocore/edk2/commit/2840bb51040bb79c1ad53b1eb1cbb > 86e5edf80ca#diff-0318cca23f8f1c46d1076b3a5891fadd updated the platform > dsc and fdf to use 2.0 shell source build (with 2.0 shell file GUID), but= the code at > https://github.com/tianocore/edk2/blob/master/Vlv2TbltDevicePkg/Library/P= la > tformBdsLib/BdsPlatform.c#L1365 is still using PcdShellFile (which matche= s to > EDK shell) to find shell file. >=20 >=20 > Thanks, > Star > -----Original Message----- > From: Qian, Yi > Sent: Tuesday, December 18, 2018 10:08 AM > To: Zeng, Star ; edk2-devel@lists.01.org > Cc: Sun, Zailiang > Subject: RE: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement >=20 > Hi Star, > This patch is good to me. Only one thing I need to know is whether you= have > done the unit test, at least, compilation, and boot into shell. >=20 > Thanks > Qian Yi >=20 > -----Original Message----- > From: Zeng, Star > Sent: Friday, December 14, 2018 6:29 PM > To: edk2-devel@lists.01.org > Cc: Zeng, Star ; Sun, Zailiang ; > Qian, Yi > Subject: [PATCH 6/7] Vlv2TbltDevicePkg: Remove PcdPeiCoreMaxXXX PCDs' > statement >=20 > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1405 >=20 > The codes have been updated to not use PcdPeiCoreMaxFvSupported, > PcdPeiCoreMaxPeimPerFv and PcdPeiCoreMaxPpiSupported, so their statement > in platform DSC could be removed. >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Star Zeng > --- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 2 -- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 -- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 -- > 3 files changed, 6 deletions(-) >=20 > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > index f8ad29df5986..d43611550285 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > @@ -663,10 +663,8 @@ [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x400 > gEfiCpuTokenSpaceGuid.PcdCpuIEDRamSize|0x400000 >=20 > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdS3AcpiReservedMemorySize > |0x10000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|50 > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPpiSupported|128 > gEfiCpuTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000 > !if $(S4_ENABLE) =3D=3D TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChang > e|TRUE > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index ca3b2ff90287..a33816c4d18b 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -663,10 +663,8 @@ [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x400 > gEfiCpuTokenSpaceGuid.PcdCpuIEDRamSize|0x400000 >=20 > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdS3AcpiReservedMemorySize > |0x10000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|50 > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPpiSupported|128 > gEfiCpuTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000 > !if $(S4_ENABLE) =3D=3D TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChang > e|TRUE > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 81f36bd73b28..b50731f25ffb 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -663,10 +663,8 @@ [PcdsFixedAtBuild.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdMaxHardwareErrorVariableSize|0x400 > gEfiCpuTokenSpaceGuid.PcdCpuIEDRamSize|0x400000 >=20 > gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdS3AcpiReservedMemorySize > |0x10000 > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPeimPerFv|50 > gEfiMdeModulePkgTokenSpaceGuid.PcdSrIovSupport|FALSE > gEfiMdeModulePkgTokenSpaceGuid.PcdAriSupport|FALSE > - gEfiMdeModulePkgTokenSpaceGuid.PcdPeiCoreMaxPpiSupported|128 > gEfiCpuTokenSpaceGuid.PcdCpuSmmApSyncTimeout|1000 > !if $(S4_ENABLE) =3D=3D TRUE >=20 > gEfiMdeModulePkgTokenSpaceGuid.PcdResetOnMemoryTypeInformationChang > e|TRUE > -- > 2.7.0.windows.1