Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Laszlo Ersek]

Hi Mike,

On 04/04/19 01:42, Michael D Kinney wrote:
> Hello,
> 
> New in V3
> =========
> * Update the base of the patch series from edk2-stable201903 to
>   7ed72121b7 that is after the file add/remove freeze:
> 
>   https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html
> 
> * Replace copyright line in License.txt in root with a single copyright
>   for "TianoCore and contributors".
> * Clarify commit message for changes to License.txt to state the text 
>   differences are larger than expected due to differences in line breaks.
> * There is one less patch in the series than V2 due to the retirement
>   of the EdkCompatibilityPkg.
> * The git feature "git range-diff" can be used to compare the V2 and
>   V3 branches even though they have different bases.  If you have both
>   the V2 and V3 branches in your local repo, you can use the following 
>   command to see the changes.  Most are due to the removal of .S files
>   in March.  If you pipe through grep looking for "diff --git" you will
>   see the list of files with differences.
> 
>   git range-diff edk2-stable201903..Bug_1373_BsdPatentLicense_V2 7ed72121b7..Bug_1373_BsdPatentLicense_V3

Didn't you intend to pick up feedback tags from previous reviews?

Anyway,

> c910bd4e91 ArmVirtPkg: Replace BSD License with BSD+Patent License

This patch has not been changed in v3, so I can repeat, from my v2
review at
<http://mid.mail-archive.com/ea8c496c-882f-aea8-fa07-833f9e42bfaa@redhat.com>:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License

The seven new files under "OvmfPkg/SioBusDxe" are covered now, and the
"create-release.py" hunk has been dropped.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent

Not changed relative to v2, so I can repeat my:

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


Thanks!
Laszlo

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Ma, Maurice]

[-- Attachment #1: Type: text/plain, Size: 147 bytes --]

Reviewed changes for CorebootPayloadPkg and CorebootModulePkg. 
And they look good to me.

Reviewed-by: Maurice Ma < maurice.ma@intel.com >

[-- Attachment #2: Type: text/html, Size: 289 bytes --]

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Ni, Ray]

[-- Attachment #1: Type: text/plain, Size: 142 bytes --]

Reviewed-by: Ray Ni <ray.ni@intel.com> for Nt32Pkg, IntelSiliconPkg, FatPkg, EmulatorPkg, PcAtChipsetPkg, UefiCpuPkg, ShellBinPkg, ShellPkg.

[-- Attachment #2: Type: text/html, Size: 201 bytes --]

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Siyuan, Fu]

[-- Attachment #1: Type: text/plain, Size: 68 bytes --]

Reviewed-by: Siyuan Fu <siyuan.fu@intel.com>     for NetworkPkg

[-- Attachment #2: Type: text/html, Size: 189 bytes --]

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Ni, Ray]

Reviewed-by: Ray Ni <ray.ni@intel.com> for OptionRomPkg.

> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael
> D Kinney
> Sent: Saturday, April 6, 2019 5:40 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> EDK II Maintainers and Reviewers,
> 
> I have create an EDK II Wiki Page to track the progress of the reviews for
> change of EDK II to a BSD+Patent License.
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Change-EDK-II-to-
> BSD-Patent-License.
> 
> Please review your patches and provide feedback and reviewed-by
> responses to this list by April 8, 2019 to support the commit of the changes on
> April 9, 2019.
> 
> Thanks,
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, April 3, 2019 4:42 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2] [PATCH V3] Change EDK II to BSD+Patent License
> >
> > Hello,
> >
> > New in V3
> > =========
> > * Update the base of the patch series from edk2-
> > stable201903 to
> >   7ed72121b7 that is after the file add/remove freeze:
> >
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > April/038574.html
> >
> > * Replace copyright line in License.txt in root with a single
> > copyright
> >   for "TianoCore and contributors".
> > * Clarify commit message for changes to License.txt to state the text
> >   differences are larger than expected due to differences in line
> > breaks.
> > * There is one less patch in the series than V2 due to the retirement
> >   of the EdkCompatibilityPkg.
> > * The git feature "git range-diff" can be used to compare the V2 and
> >   V3 branches even though they have different bases.
> > If you have both
> >   the V2 and V3 branches in your local repo, you can use the following
> >   command to see the changes.  Most are due to the removal of .S files
> >   in March.  If you pipe through grep looking for "diff --git" you
> > will
> >   see the list of files with differences.
> >
> >   git range-diff edk2-
> > stable201903..Bug_1373_BsdPatentLicense_V2
> > 7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> > New in V2
> > =========
> > * Remove Cc lines from commit messages
> > * Remove branch reference from commit messages
> > * Change license in 2 files missed in OvmfPkg
> > * Update OvmfPkg/License.txt to BSD+Patent as the default license
> > * Move the portions of Contributions.txt in the root of
> > edk2 to
> >   Readme.md in the root of edk2 that describe how to contribute
> >   along with the commit message format.
> > * Add to Readme.md in the root of edk2 that Signed-off- by means that
> >   the contributor certifies compliance to the Developer's Certificate
> >   of Origin 1.1.  https://developercertificate.org =========
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > This change is based on the following emails:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > February/036260.html
> >   https://lists.01.org/pipermail/edk2-devel/2018-
> > October/030385.html
> >
> > RFCs with detailed process for the license change:
> >   V3: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/038116.html
> >   V2: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037669.html
> >   V1: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037500.html
> >
> > I have posted the patch series for review on the following branch
> > using
> > 7ed72121b7 as the base for the patch series.
> >
> >
> > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> > tLicense_V3
> >
> > The commits in patch series can be viewed here:
> >
> >
> > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> > tentLicense_V3
> >
> > The patch series has one patch per package along with a few patches to
> > update the license information in the root of the
> > edk2 repository
> > as described in the RFC V3.
> >
> > Due to the size of the patch series, I prefer to not send the patch
> > emails.  Instead, please perform code reviews using content from the
> > branch.
> >
> > All EDK II package maintainers and package reviewers should provide
> > review feedback for their packages.  The critical part of the review
> > is:
> > 1) Any changes that cause build breaks or logic changes.  These code
> >    changes are intended to only modify license contents in comment
> >    blocks.
> > 2) Any file that has been changed to BSD+Patent, but should remain
> >    with the current license.
> > 3) Any file that that has not changed to BSD+Patent, but should be
> >    changed to BSD+Patent.
> >
> > Feedback and Reviewed-by emails should identify the patch the feedback
> > applies using the patch summary listed below.  The goal is to complete
> > all reviews to support the commit of these patches on April 9, 2019.
> >
> > eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
> > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to
> BSD+Patent
> > f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with
> > BSD+Patent License
> > 845b945044 StdLib: Replace BSD License with BSD+Patent License
> > e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
> > a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent
> > License
> > a67328cbb4 UefiCpuPkg: Replace BSD License with
> > BSD+Patent License
> > 248d91c908 StandaloneMmPkg: Replace BSD License with
> > BSD+Patent License
> > 415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent
> > License 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> > BSD+Patent License
> > 9ffa4947d3 ShellPkg: Replace BSD License with
> > BSD+Patent License
> > fdb6510955 ShellBinPkg: Replace BSD License with
> > BSD+Patent License
> > dc5f8d93d9 SecurityPkg: Replace BSD License with
> > BSD+Patent License
> > 841d42a913 QuarkSocPkg: Replace BSD License with
> > BSD+Patent License
> > 75c3756e18 QuarkPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 657491e5a3 PcAtChipsetPkg: Replace BSD License with
> > BSD+Patent License
> > 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
> > 521b8139c7 OptionRomPkg: Replace BSD License with
> > BSD+Patent License
> > ec339f8320 Omap35xxPkg: Replace BSD License with
> > BSD+Patent License
> > ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License
> > aa99b9adeb NetworkPkg: Replace BSD License with
> > BSD+Patent License
> > 88bdc989d7 MdePkg: Replace BSD License with BSD+Patent License
> > 5628b5e5c7 MdeModulePkg: Replace BSD License with
> > BSD+Patent License
> > 505e36838d IntelSiliconPkg: Replace BSD License with
> > BSD+Patent License
> > e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with
> > BSD+Patent License
> > d7347d7ef0 IntelFspPkg: Replace BSD License with
> > BSD+Patent License
> > 487741dd60 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent
> > License 0e8d264faf IntelFsp2Pkg: Replace BSD License with
> > BSD+Patent License
> > f4835e9508 IntelFrameworkPkg: Replace BSD License with
> > BSD+Patent License
> > d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License with
> > BSD+Patent License 5a3c8a14ce FmpDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent License
> > f336d7d7de EmulatorPkg: Replace BSD License with
> > BSD+Patent License
> > 5ea93a6088 EmbeddedPkg: Replace BSD License with
> > BSD+Patent License
> > 2afa7c0820 DynamicTablesPkg: Replace BSD License with
> > BSD+Patent License
> > 4768af6404 CryptoPkg: Replace BSD License with
> > BSD+Patent License
> > 9aecbee0a3 CorebootPayloadPkg: Replace BSD License with
> > BSD+Patent License
> > e7716450b8 CorebootModulePkg: Replace BSD License with
> > BSD+Patent License
> > 04fb04e0aa BeagleBoardPkg: Replace BSD License with
> > BSD+Patent License
> > c910bd4e91 ArmVirtPkg: Replace BSD License with
> > BSD+Patent License
> > 6f98d2f305 ArmPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent License
> > 0fb7bd552b BaseTools: Replace BSD License with
> > BSD+Patent License
> > bc61733285 edk2: Replace BSD License with BSD+Patent License
> > 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD to BSD+Patent
> > 17a33094a9 edk2: Add License-History.txt
> >
> > Best regards,
> >
> > Mike
> 
> 
> 

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Wu, Hao A]

For SourceLevelDebugPkg:
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, April 06, 2019 5:40 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> EDK II Maintainers and Reviewers,
> 
> I have create an EDK II Wiki Page to track the progress
> of the reviews for change of EDK II to a BSD+Patent License.
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Change-EDK-II-to-
> BSD-Patent-License.
> 
> Please review your patches and provide feedback and
> reviewed-by responses to this list by April 8, 2019 to
> support the commit of the changes on April 9, 2019.
> 
> Thanks,
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, April 3, 2019 4:42 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2] [PATCH V3] Change EDK II to BSD+Patent
> > License
> >
> > Hello,
> >
> > New in V3
> > =========
> > * Update the base of the patch series from edk2-
> > stable201903 to
> >   7ed72121b7 that is after the file add/remove freeze:
> >
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > April/038574.html
> >
> > * Replace copyright line in License.txt in root with a
> > single copyright
> >   for "TianoCore and contributors".
> > * Clarify commit message for changes to License.txt to
> > state the text
> >   differences are larger than expected due to
> > differences in line breaks.
> > * There is one less patch in the series than V2 due to
> > the retirement
> >   of the EdkCompatibilityPkg.
> > * The git feature "git range-diff" can be used to
> > compare the V2 and
> >   V3 branches even though they have different bases.
> > If you have both
> >   the V2 and V3 branches in your local repo, you can
> > use the following
> >   command to see the changes.  Most are due to the
> > removal of .S files
> >   in March.  If you pipe through grep looking for "diff
> > --git" you will
> >   see the list of files with differences.
> >
> >   git range-diff edk2-
> > stable201903..Bug_1373_BsdPatentLicense_V2
> > 7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> > New in V2
> > =========
> > * Remove Cc lines from commit messages
> > * Remove branch reference from commit messages
> > * Change license in 2 files missed in OvmfPkg
> > * Update OvmfPkg/License.txt to BSD+Patent as the
> > default license
> > * Move the portions of Contributions.txt in the root of
> > edk2 to
> >   Readme.md in the root of edk2 that describe how to
> > contribute
> >   along with the commit message format.
> > * Add to Readme.md in the root of edk2 that Signed-off-
> > by means that
> >   the contributor certifies compliance to the
> > Developer's Certificate
> >   of Origin 1.1.  https://developercertificate.org
> > =========
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > This change is based on the following emails:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > February/036260.html
> >   https://lists.01.org/pipermail/edk2-devel/2018-
> > October/030385.html
> >
> > RFCs with detailed process for the license change:
> >   V3: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/038116.html
> >   V2: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037669.html
> >   V1: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037500.html
> >
> > I have posted the patch series for review on the
> > following branch using
> > 7ed72121b7 as the base for the patch series.
> >
> >
> > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> > tLicense_V3
> >
> > The commits in patch series can be viewed here:
> >
> >
> > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> > tentLicense_V3
> >
> > The patch series has one patch per package along with a
> > few patches
> > to update the license information in the root of the
> > edk2 repository
> > as described in the RFC V3.
> >
> > Due to the size of the patch series, I prefer to not
> > send the
> > patch emails.  Instead, please perform code reviews
> > using content
> > from the branch.
> >
> > All EDK II package maintainers and package reviewers
> > should provide
> > review feedback for their packages.  The critical part
> > of the review
> > is:
> > 1) Any changes that cause build breaks or logic
> > changes.  These code
> >    changes are intended to only modify license contents
> > in comment
> >    blocks.
> > 2) Any file that has been changed to BSD+Patent, but
> > should remain
> >    with the current license.
> > 3) Any file that that has not changed to BSD+Patent,
> > but should be
> >    changed to BSD+Patent.
> >
> > Feedback and Reviewed-by emails should identify the
> > patch the feedback
> > applies using the patch summary listed below.  The goal
> > is to complete
> > all reviews to support the commit of these patches on
> > April 9, 2019.
> >
> > eece5f8a6e edk2: Remove Contributions.txt and update
> > Readme.md
> > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause
> > BSD to BSD+Patent
> > f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD
> > License with BSD+Patent License
> > 845b945044 StdLib: Replace BSD License with BSD+Patent
> > License
> > e55c8532c9 AppPkg: Replace BSD License with BSD+Patent
> > License
> > a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License
> > with BSD+Patent License
> > a67328cbb4 UefiCpuPkg: Replace BSD License with
> > BSD+Patent License
> > 248d91c908 StandaloneMmPkg: Replace BSD License with
> > BSD+Patent License
> > 415927330c SourceLevelDebugPkg: Replace BSD License
> > with BSD+Patent License
> > 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> > BSD+Patent License
> > 9ffa4947d3 ShellPkg: Replace BSD License with
> > BSD+Patent License
> > fdb6510955 ShellBinPkg: Replace BSD License with
> > BSD+Patent License
> > dc5f8d93d9 SecurityPkg: Replace BSD License with
> > BSD+Patent License
> > 841d42a913 QuarkSocPkg: Replace BSD License with
> > BSD+Patent License
> > 75c3756e18 QuarkPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 657491e5a3 PcAtChipsetPkg: Replace BSD License with
> > BSD+Patent License
> > 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent
> > License
> > 521b8139c7 OptionRomPkg: Replace BSD License with
> > BSD+Patent License
> > ec339f8320 Omap35xxPkg: Replace BSD License with
> > BSD+Patent License
> > ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent
> > License
> > aa99b9adeb NetworkPkg: Replace BSD License with
> > BSD+Patent License
> > 88bdc989d7 MdePkg: Replace BSD License with BSD+Patent
> > License
> > 5628b5e5c7 MdeModulePkg: Replace BSD License with
> > BSD+Patent License
> > 505e36838d IntelSiliconPkg: Replace BSD License with
> > BSD+Patent License
> > e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with
> > BSD+Patent License
> > d7347d7ef0 IntelFspPkg: Replace BSD License with
> > BSD+Patent License
> > 487741dd60 IntelFsp2WrapperPkg: Replace BSD License
> > with BSD+Patent License
> > 0e8d264faf IntelFsp2Pkg: Replace BSD License with
> > BSD+Patent License
> > f4835e9508 IntelFrameworkPkg: Replace BSD License with
> > BSD+Patent License
> > d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License
> > with BSD+Patent License
> > 5a3c8a14ce FmpDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent
> > License
> > f336d7d7de EmulatorPkg: Replace BSD License with
> > BSD+Patent License
> > 5ea93a6088 EmbeddedPkg: Replace BSD License with
> > BSD+Patent License
> > 2afa7c0820 DynamicTablesPkg: Replace BSD License with
> > BSD+Patent License
> > 4768af6404 CryptoPkg: Replace BSD License with
> > BSD+Patent License
> > 9aecbee0a3 CorebootPayloadPkg: Replace BSD License with
> > BSD+Patent License
> > e7716450b8 CorebootModulePkg: Replace BSD License with
> > BSD+Patent License
> > 04fb04e0aa BeagleBoardPkg: Replace BSD License with
> > BSD+Patent License
> > c910bd4e91 ArmVirtPkg: Replace BSD License with
> > BSD+Patent License
> > 6f98d2f305 ArmPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent
> > License
> > 0fb7bd552b BaseTools: Replace BSD License with
> > BSD+Patent License
> > bc61733285 edk2: Replace BSD License with BSD+Patent
> > License
> > 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD
> > to BSD+Patent
> > 17a33094a9 edk2: Add License-History.txt
> >
> > Best regards,
> >
> > Mike
> 
> 
> 

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Dong, Eric]

For UefiCpuPkg,  Reviewed-by: Eric Dong <eric.dong@intel.com>

Thanks,
Eric
> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, April 6, 2019 5:40 AM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> EDK II Maintainers and Reviewers,
> 
> I have create an EDK II Wiki Page to track the progress of the reviews for
> change of EDK II to a BSD+Patent License.
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Change-EDK-II-to-
> BSD-Patent-License.
> 
> Please review your patches and provide feedback and reviewed-by
> responses to this list by April 8, 2019 to support the commit of the changes on
> April 9, 2019.
> 
> Thanks,
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, April 3, 2019 4:42 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2] [PATCH V3] Change EDK II to BSD+Patent License
> >
> > Hello,
> >
> > New in V3
> > =========
> > * Update the base of the patch series from edk2-
> > stable201903 to
> >   7ed72121b7 that is after the file add/remove freeze:
> >
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > April/038574.html
> >
> > * Replace copyright line in License.txt in root with a single
> > copyright
> >   for "TianoCore and contributors".
> > * Clarify commit message for changes to License.txt to state the text
> >   differences are larger than expected due to differences in line
> > breaks.
> > * There is one less patch in the series than V2 due to the retirement
> >   of the EdkCompatibilityPkg.
> > * The git feature "git range-diff" can be used to compare the V2 and
> >   V3 branches even though they have different bases.
> > If you have both
> >   the V2 and V3 branches in your local repo, you can use the following
> >   command to see the changes.  Most are due to the removal of .S files
> >   in March.  If you pipe through grep looking for "diff --git" you
> > will
> >   see the list of files with differences.
> >
> >   git range-diff edk2-
> > stable201903..Bug_1373_BsdPatentLicense_V2
> > 7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> > New in V2
> > =========
> > * Remove Cc lines from commit messages
> > * Remove branch reference from commit messages
> > * Change license in 2 files missed in OvmfPkg
> > * Update OvmfPkg/License.txt to BSD+Patent as the default license
> > * Move the portions of Contributions.txt in the root of
> > edk2 to
> >   Readme.md in the root of edk2 that describe how to contribute
> >   along with the commit message format.
> > * Add to Readme.md in the root of edk2 that Signed-off- by means that
> >   the contributor certifies compliance to the Developer's Certificate
> >   of Origin 1.1.  https://developercertificate.org =========
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > This change is based on the following emails:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > February/036260.html
> >   https://lists.01.org/pipermail/edk2-devel/2018-
> > October/030385.html
> >
> > RFCs with detailed process for the license change:
> >   V3: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/038116.html
> >   V2: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037669.html
> >   V1: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037500.html
> >
> > I have posted the patch series for review on the following branch
> > using
> > 7ed72121b7 as the base for the patch series.
> >
> >
> > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> > tLicense_V3
> >
> > The commits in patch series can be viewed here:
> >
> >
> > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> > tentLicense_V3
> >
> > The patch series has one patch per package along with a few patches to
> > update the license information in the root of the
> > edk2 repository
> > as described in the RFC V3.
> >
> > Due to the size of the patch series, I prefer to not send the patch
> > emails.  Instead, please perform code reviews using content from the
> > branch.
> >
> > All EDK II package maintainers and package reviewers should provide
> > review feedback for their packages.  The critical part of the review
> > is:
> > 1) Any changes that cause build breaks or logic changes.  These code
> >    changes are intended to only modify license contents in comment
> >    blocks.
> > 2) Any file that has been changed to BSD+Patent, but should remain
> >    with the current license.
> > 3) Any file that that has not changed to BSD+Patent, but should be
> >    changed to BSD+Patent.
> >
> > Feedback and Reviewed-by emails should identify the patch the feedback
> > applies using the patch summary listed below.  The goal is to complete
> > all reviews to support the commit of these patches on April 9, 2019.
> >
> > eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
> > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to
> BSD+Patent
> > f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with
> > BSD+Patent License
> > 845b945044 StdLib: Replace BSD License with BSD+Patent License
> > e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
> > a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent
> > License
> > a67328cbb4 UefiCpuPkg: Replace BSD License with
> > BSD+Patent License
> > 248d91c908 StandaloneMmPkg: Replace BSD License with
> > BSD+Patent License
> > 415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent
> > License 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> > BSD+Patent License
> > 9ffa4947d3 ShellPkg: Replace BSD License with
> > BSD+Patent License
> > fdb6510955 ShellBinPkg: Replace BSD License with
> > BSD+Patent License
> > dc5f8d93d9 SecurityPkg: Replace BSD License with
> > BSD+Patent License
> > 841d42a913 QuarkSocPkg: Replace BSD License with
> > BSD+Patent License
> > 75c3756e18 QuarkPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 657491e5a3 PcAtChipsetPkg: Replace BSD License with
> > BSD+Patent License
> > 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
> > 521b8139c7 OptionRomPkg: Replace BSD License with
> > BSD+Patent License
> > ec339f8320 Omap35xxPkg: Replace BSD License with
> > BSD+Patent License
> > ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License
> > aa99b9adeb NetworkPkg: Replace BSD License with
> > BSD+Patent License
> > 88bdc989d7 MdePkg: Replace BSD License with BSD+Patent License
> > 5628b5e5c7 MdeModulePkg: Replace BSD License with
> > BSD+Patent License
> > 505e36838d IntelSiliconPkg: Replace BSD License with
> > BSD+Patent License
> > e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with
> > BSD+Patent License
> > d7347d7ef0 IntelFspPkg: Replace BSD License with
> > BSD+Patent License
> > 487741dd60 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent
> > License 0e8d264faf IntelFsp2Pkg: Replace BSD License with
> > BSD+Patent License
> > f4835e9508 IntelFrameworkPkg: Replace BSD License with
> > BSD+Patent License
> > d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License with
> > BSD+Patent License 5a3c8a14ce FmpDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent License
> > f336d7d7de EmulatorPkg: Replace BSD License with
> > BSD+Patent License
> > 5ea93a6088 EmbeddedPkg: Replace BSD License with
> > BSD+Patent License
> > 2afa7c0820 DynamicTablesPkg: Replace BSD License with
> > BSD+Patent License
> > 4768af6404 CryptoPkg: Replace BSD License with
> > BSD+Patent License
> > 9aecbee0a3 CorebootPayloadPkg: Replace BSD License with
> > BSD+Patent License
> > e7716450b8 CorebootModulePkg: Replace BSD License with
> > BSD+Patent License
> > 04fb04e0aa BeagleBoardPkg: Replace BSD License with
> > BSD+Patent License
> > c910bd4e91 ArmVirtPkg: Replace BSD License with
> > BSD+Patent License
> > 6f98d2f305 ArmPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent License
> > 0fb7bd552b BaseTools: Replace BSD License with
> > BSD+Patent License
> > bc61733285 edk2: Replace BSD License with BSD+Patent License
> > 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD to BSD+Patent
> > 17a33094a9 edk2: Add License-History.txt
> >
> > Best regards,
> >
> > Mike
> 
> 
> 

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Wu, Hao A]

For MdeModulePkg:
Reviewed-by: Hao Wu <hao.a.wu@intel.com>

Best Regards,
Hao Wu


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, April 06, 2019 5:40 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> EDK II Maintainers and Reviewers,
> 
> I have create an EDK II Wiki Page to track the progress
> of the reviews for change of EDK II to a BSD+Patent License.
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Change-EDK-II-to-
> BSD-Patent-License.
> 
> Please review your patches and provide feedback and
> reviewed-by responses to this list by April 8, 2019 to
> support the commit of the changes on April 9, 2019.
> 
> Thanks,
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, April 3, 2019 4:42 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2] [PATCH V3] Change EDK II to BSD+Patent
> > License
> >
> > Hello,
> >
> > New in V3
> > =========
> > * Update the base of the patch series from edk2-
> > stable201903 to
> >   7ed72121b7 that is after the file add/remove freeze:
> >
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > April/038574.html
> >
> > * Replace copyright line in License.txt in root with a
> > single copyright
> >   for "TianoCore and contributors".
> > * Clarify commit message for changes to License.txt to
> > state the text
> >   differences are larger than expected due to
> > differences in line breaks.
> > * There is one less patch in the series than V2 due to
> > the retirement
> >   of the EdkCompatibilityPkg.
> > * The git feature "git range-diff" can be used to
> > compare the V2 and
> >   V3 branches even though they have different bases.
> > If you have both
> >   the V2 and V3 branches in your local repo, you can
> > use the following
> >   command to see the changes.  Most are due to the
> > removal of .S files
> >   in March.  If you pipe through grep looking for "diff
> > --git" you will
> >   see the list of files with differences.
> >
> >   git range-diff edk2-
> > stable201903..Bug_1373_BsdPatentLicense_V2
> > 7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> > New in V2
> > =========
> > * Remove Cc lines from commit messages
> > * Remove branch reference from commit messages
> > * Change license in 2 files missed in OvmfPkg
> > * Update OvmfPkg/License.txt to BSD+Patent as the
> > default license
> > * Move the portions of Contributions.txt in the root of
> > edk2 to
> >   Readme.md in the root of edk2 that describe how to
> > contribute
> >   along with the commit message format.
> > * Add to Readme.md in the root of edk2 that Signed-off-
> > by means that
> >   the contributor certifies compliance to the
> > Developer's Certificate
> >   of Origin 1.1.  https://developercertificate.org
> > =========
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > This change is based on the following emails:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > February/036260.html
> >   https://lists.01.org/pipermail/edk2-devel/2018-
> > October/030385.html
> >
> > RFCs with detailed process for the license change:
> >   V3: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/038116.html
> >   V2: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037669.html
> >   V1: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037500.html
> >
> > I have posted the patch series for review on the
> > following branch using
> > 7ed72121b7 as the base for the patch series.
> >
> >
> > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> > tLicense_V3
> >
> > The commits in patch series can be viewed here:
> >
> >
> > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> > tentLicense_V3
> >
> > The patch series has one patch per package along with a
> > few patches
> > to update the license information in the root of the
> > edk2 repository
> > as described in the RFC V3.
> >
> > Due to the size of the patch series, I prefer to not
> > send the
> > patch emails.  Instead, please perform code reviews
> > using content
> > from the branch.
> >
> > All EDK II package maintainers and package reviewers
> > should provide
> > review feedback for their packages.  The critical part
> > of the review
> > is:
> > 1) Any changes that cause build breaks or logic
> > changes.  These code
> >    changes are intended to only modify license contents
> > in comment
> >    blocks.
> > 2) Any file that has been changed to BSD+Patent, but
> > should remain
> >    with the current license.
> > 3) Any file that that has not changed to BSD+Patent,
> > but should be
> >    changed to BSD+Patent.
> >
> > Feedback and Reviewed-by emails should identify the
> > patch the feedback
> > applies using the patch summary listed below.  The goal
> > is to complete
> > all reviews to support the commit of these patches on
> > April 9, 2019.
> >
> > eece5f8a6e edk2: Remove Contributions.txt and update
> > Readme.md
> > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause
> > BSD to BSD+Patent
> > f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD
> > License with BSD+Patent License
> > 845b945044 StdLib: Replace BSD License with BSD+Patent
> > License
> > e55c8532c9 AppPkg: Replace BSD License with BSD+Patent
> > License
> > a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License
> > with BSD+Patent License
> > a67328cbb4 UefiCpuPkg: Replace BSD License with
> > BSD+Patent License
> > 248d91c908 StandaloneMmPkg: Replace BSD License with
> > BSD+Patent License
> > 415927330c SourceLevelDebugPkg: Replace BSD License
> > with BSD+Patent License
> > 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> > BSD+Patent License
> > 9ffa4947d3 ShellPkg: Replace BSD License with
> > BSD+Patent License
> > fdb6510955 ShellBinPkg: Replace BSD License with
> > BSD+Patent License
> > dc5f8d93d9 SecurityPkg: Replace BSD License with
> > BSD+Patent License
> > 841d42a913 QuarkSocPkg: Replace BSD License with
> > BSD+Patent License
> > 75c3756e18 QuarkPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 657491e5a3 PcAtChipsetPkg: Replace BSD License with
> > BSD+Patent License
> > 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent
> > License
> > 521b8139c7 OptionRomPkg: Replace BSD License with
> > BSD+Patent License
> > ec339f8320 Omap35xxPkg: Replace BSD License with
> > BSD+Patent License
> > ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent
> > License
> > aa99b9adeb NetworkPkg: Replace BSD License with
> > BSD+Patent License
> > 88bdc989d7 MdePkg: Replace BSD License with BSD+Patent
> > License
> > 5628b5e5c7 MdeModulePkg: Replace BSD License with
> > BSD+Patent License
> > 505e36838d IntelSiliconPkg: Replace BSD License with
> > BSD+Patent License
> > e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with
> > BSD+Patent License
> > d7347d7ef0 IntelFspPkg: Replace BSD License with
> > BSD+Patent License
> > 487741dd60 IntelFsp2WrapperPkg: Replace BSD License
> > with BSD+Patent License
> > 0e8d264faf IntelFsp2Pkg: Replace BSD License with
> > BSD+Patent License
> > f4835e9508 IntelFrameworkPkg: Replace BSD License with
> > BSD+Patent License
> > d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License
> > with BSD+Patent License
> > 5a3c8a14ce FmpDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent
> > License
> > f336d7d7de EmulatorPkg: Replace BSD License with
> > BSD+Patent License
> > 5ea93a6088 EmbeddedPkg: Replace BSD License with
> > BSD+Patent License
> > 2afa7c0820 DynamicTablesPkg: Replace BSD License with
> > BSD+Patent License
> > 4768af6404 CryptoPkg: Replace BSD License with
> > BSD+Patent License
> > 9aecbee0a3 CorebootPayloadPkg: Replace BSD License with
> > BSD+Patent License
> > e7716450b8 CorebootModulePkg: Replace BSD License with
> > BSD+Patent License
> > 04fb04e0aa BeagleBoardPkg: Replace BSD License with
> > BSD+Patent License
> > c910bd4e91 ArmVirtPkg: Replace BSD License with
> > BSD+Patent License
> > 6f98d2f305 ArmPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent
> > License
> > 0fb7bd552b BaseTools: Replace BSD License with
> > BSD+Patent License
> > bc61733285 edk2: Replace BSD License with BSD+Patent
> > License
> > 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD
> > to BSD+Patent
> > 17a33094a9 edk2: Add License-History.txt
> >
> > Best regards,
> >
> > Mike
> 
> 
> 

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[chasel.chiu]

[-- Attachment #1: Type: text/plain, Size: 143 bytes --]

Reviewed-by: Chasel Chiu < chasel.chiu@intel.com >

for below packages:
IntelFspPkg
IntelFspWrapperPkg
IntelFsp2Pkg
IntelFsp2WrapperPkg

[-- Attachment #2: Type: text/html, Size: 323 bytes --]

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[yi.qian]

[-- Attachment #1: Type: text/plain, Size: 101 bytes --]

For Vlv2DeviceRefCodePkg and Vlv2TbltDevicePkg
Reviewed by Qian Yi<yi.qian@intel.com>
--
Qian Yi

[-- Attachment #2: Type: text/html, Size: 126 bytes --]

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[yi.qian]

Reviewed by Qian Yi<yi.qian@intel.com>

Thanks
Qian Yi

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, April 06, 2019 5:40 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> EDK II Maintainers and Reviewers,
> 
> I have create an EDK II Wiki Page to track the progress of the reviews for
> change of EDK II to a BSD+Patent License.
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Change-EDK-II-to-
> BSD-Patent-License.
> 
> Please review your patches and provide feedback and reviewed-by
> responses to this list by April 8, 2019 to support the commit of the changes on
> April 9, 2019.
> 
> Thanks,
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, April 3, 2019 4:42 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2] [PATCH V3] Change EDK II to BSD+Patent License
> >
> > Hello,
> >
> > New in V3
> > =========
> > * Update the base of the patch series from edk2-
> > stable201903 to
> >   7ed72121b7 that is after the file add/remove freeze:
> >
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > April/038574.html
> >
> > * Replace copyright line in License.txt in root with a single
> > copyright
> >   for "TianoCore and contributors".
> > * Clarify commit message for changes to License.txt to state the text
> >   differences are larger than expected due to differences in line
> > breaks.
> > * There is one less patch in the series than V2 due to the retirement
> >   of the EdkCompatibilityPkg.
> > * The git feature "git range-diff" can be used to compare the V2 and
> >   V3 branches even though they have different bases.
> > If you have both
> >   the V2 and V3 branches in your local repo, you can use the following
> >   command to see the changes.  Most are due to the removal of .S files
> >   in March.  If you pipe through grep looking for "diff --git" you
> > will
> >   see the list of files with differences.
> >
> >   git range-diff edk2-
> > stable201903..Bug_1373_BsdPatentLicense_V2
> > 7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> > New in V2
> > =========
> > * Remove Cc lines from commit messages
> > * Remove branch reference from commit messages
> > * Change license in 2 files missed in OvmfPkg
> > * Update OvmfPkg/License.txt to BSD+Patent as the default license
> > * Move the portions of Contributions.txt in the root of
> > edk2 to
> >   Readme.md in the root of edk2 that describe how to contribute
> >   along with the commit message format.
> > * Add to Readme.md in the root of edk2 that Signed-off- by means that
> >   the contributor certifies compliance to the Developer's Certificate
> >   of Origin 1.1.  https://developercertificate.org =========
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > This change is based on the following emails:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > February/036260.html
> >   https://lists.01.org/pipermail/edk2-devel/2018-
> > October/030385.html
> >
> > RFCs with detailed process for the license change:
> >   V3: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/038116.html
> >   V2: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037669.html
> >   V1: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037500.html
> >
> > I have posted the patch series for review on the following branch
> > using
> > 7ed72121b7 as the base for the patch series.
> >
> >
> > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> > tLicense_V3
> >
> > The commits in patch series can be viewed here:
> >
> >
> > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> > tentLicense_V3
> >
> > The patch series has one patch per package along with a few patches to
> > update the license information in the root of the
> > edk2 repository
> > as described in the RFC V3.
> >
> > Due to the size of the patch series, I prefer to not send the patch
> > emails.  Instead, please perform code reviews using content from the
> > branch.
> >
> > All EDK II package maintainers and package reviewers should provide
> > review feedback for their packages.  The critical part of the review
> > is:
> > 1) Any changes that cause build breaks or logic changes.  These code
> >    changes are intended to only modify license contents in comment
> >    blocks.
> > 2) Any file that has been changed to BSD+Patent, but should remain
> >    with the current license.
> > 3) Any file that that has not changed to BSD+Patent, but should be
> >    changed to BSD+Patent.
> >
> > Feedback and Reviewed-by emails should identify the patch the feedback
> > applies using the patch summary listed below.  The goal is to complete
> > all reviews to support the commit of these patches on April 9, 2019.
> >
> > eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
> > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to
> BSD+Patent
> > f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with
> > BSD+Patent License
> > 845b945044 StdLib: Replace BSD License with BSD+Patent License
> > e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
> > a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent
> > License
> > a67328cbb4 UefiCpuPkg: Replace BSD License with
> > BSD+Patent License
> > 248d91c908 StandaloneMmPkg: Replace BSD License with
> > BSD+Patent License
> > 415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent
> > License 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> > BSD+Patent License
> > 9ffa4947d3 ShellPkg: Replace BSD License with
> > BSD+Patent License
> > fdb6510955 ShellBinPkg: Replace BSD License with
> > BSD+Patent License
> > dc5f8d93d9 SecurityPkg: Replace BSD License with
> > BSD+Patent License
> > 841d42a913 QuarkSocPkg: Replace BSD License with
> > BSD+Patent License
> > 75c3756e18 QuarkPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 657491e5a3 PcAtChipsetPkg: Replace BSD License with
> > BSD+Patent License
> > 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
> > 521b8139c7 OptionRomPkg: Replace BSD License with
> > BSD+Patent License
> > ec339f8320 Omap35xxPkg: Replace BSD License with
> > BSD+Patent License
> > ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License
> > aa99b9adeb NetworkPkg: Replace BSD License with
> > BSD+Patent License
> > 88bdc989d7 MdePkg: Replace BSD License with BSD+Patent License
> > 5628b5e5c7 MdeModulePkg: Replace BSD License with
> > BSD+Patent License
> > 505e36838d IntelSiliconPkg: Replace BSD License with
> > BSD+Patent License
> > e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with
> > BSD+Patent License
> > d7347d7ef0 IntelFspPkg: Replace BSD License with
> > BSD+Patent License
> > 487741dd60 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent
> > License 0e8d264faf IntelFsp2Pkg: Replace BSD License with
> > BSD+Patent License
> > f4835e9508 IntelFrameworkPkg: Replace BSD License with
> > BSD+Patent License
> > d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License with
> > BSD+Patent License 5a3c8a14ce FmpDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent License
> > f336d7d7de EmulatorPkg: Replace BSD License with
> > BSD+Patent License
> > 5ea93a6088 EmbeddedPkg: Replace BSD License with
> > BSD+Patent License
> > 2afa7c0820 DynamicTablesPkg: Replace BSD License with
> > BSD+Patent License
> > 4768af6404 CryptoPkg: Replace BSD License with
> > BSD+Patent License
> > 9aecbee0a3 CorebootPayloadPkg: Replace BSD License with
> > BSD+Patent License
> > e7716450b8 CorebootModulePkg: Replace BSD License with
> > BSD+Patent License
> > 04fb04e0aa BeagleBoardPkg: Replace BSD License with
> > BSD+Patent License
> > c910bd4e91 ArmVirtPkg: Replace BSD License with
> > BSD+Patent License
> > 6f98d2f305 ArmPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent License
> > 0fb7bd552b BaseTools: Replace BSD License with
> > BSD+Patent License
> > bc61733285 edk2: Replace BSD License with BSD+Patent License
> > 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD to BSD+Patent
> > 17a33094a9 edk2: Add License-History.txt
> >
> > Best regards,
> >
> > Mike
> 
> 
> 



-- 
Qian Yi

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[zailiang.sun]

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Wednesday, April 3, 2019 4:42 PM
> To: devel@edk2.groups.io; Kinney, Michael D 
> <michael.d.kinney@intel.com>
> Subject: [edk2] [PATCH V3] Change EDK II to BSD+Patent License
> 
> Hello,
> 
> New in V3
> =========
> * Update the base of the patch series from edk2-
> stable201903 to
>   7ed72121b7 that is after the file add/remove freeze:
> 
>   https://lists.01.org/pipermail/edk2-devel/2019-
> April/038574.html
> 
> * Replace copyright line in License.txt in root with a single 
> copyright
>   for "TianoCore and contributors".
> * Clarify commit message for changes to License.txt to state the text
>   differences are larger than expected due to differences in line 
> breaks.
> * There is one less patch in the series than V2 due to the retirement
>   of the EdkCompatibilityPkg.
> * The git feature "git range-diff" can be used to compare the V2 and
>   V3 branches even though they have different bases.
> If you have both
>   the V2 and V3 branches in your local repo, you can use the following
>   command to see the changes.  Most are due to the removal of .S files
>   in March.  If you pipe through grep looking for "diff --git" you 
> will
>   see the list of files with differences.
> 
>   git range-diff edk2-
> stable201903..Bug_1373_BsdPatentLicense_V2
> 7ed72121b7..Bug_1373_BsdPatentLicense_V3
> 
> New in V2
> =========
> * Remove Cc lines from commit messages
> * Remove branch reference from commit messages
> * Change license in 2 files missed in OvmfPkg
> * Update OvmfPkg/License.txt to BSD+Patent as the default license
> * Move the portions of Contributions.txt in the root of
> edk2 to
>   Readme.md in the root of edk2 that describe how to contribute
>   along with the commit message format.
> * Add to Readme.md in the root of edk2 that Signed-off- by means that
>   the contributor certifies compliance to the Developer's Certificate
>   of Origin 1.1.  https://developercertificate.org =========
> 
> BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> 
> This change is based on the following emails:
>   https://lists.01.org/pipermail/edk2-devel/2019-
> February/036260.html
>   https://lists.01.org/pipermail/edk2-devel/2018-
> October/030385.html
> 
> RFCs with detailed process for the license change:
>   V3: https://lists.01.org/pipermail/edk2-devel/2019-
> March/038116.html
>   V2: https://lists.01.org/pipermail/edk2-devel/2019-
> March/037669.html
>   V1: https://lists.01.org/pipermail/edk2-devel/2019-
> March/037500.html
> 
> I have posted the patch series for review on the following branch 
> using
> 7ed72121b7 as the base for the patch series.
> 
> 
> https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> tLicense_V3
> 
> The commits in patch series can be viewed here:
> 
> 
> https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> tentLicense_V3
> 
> The patch series has one patch per package along with a few patches to 
> update the license information in the root of the
> edk2 repository
> as described in the RFC V3.
> 
> Due to the size of the patch series, I prefer to not send the patch 
> emails.  Instead, please perform code reviews using content from the 
> branch.
> 
> All EDK II package maintainers and package reviewers should provide 
> review feedback for their packages.  The critical part of the review
> is:
> 1) Any changes that cause build breaks or logic changes.  These code
>    changes are intended to only modify license contents in comment
>    blocks.
> 2) Any file that has been changed to BSD+Patent, but should remain
>    with the current license.
> 3) Any file that that has not changed to BSD+Patent, but should be
>    changed to BSD+Patent.
> 
> Feedback and Reviewed-by emails should identify the patch the feedback 
> applies using the patch summary listed below.  The goal is to complete 
> all reviews to support the commit of these patches on April 9, 2019.
> 
> eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
> 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent
> f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with 
> BSD+Patent License
> 845b945044 StdLib: Replace BSD License with BSD+Patent License
> e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
> a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with
> BSD+Patent License
> 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent 
> License
> a67328cbb4 UefiCpuPkg: Replace BSD License with
> BSD+Patent License
> 248d91c908 StandaloneMmPkg: Replace BSD License with
> BSD+Patent License
> 415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent 
> License 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> BSD+Patent License
> 9ffa4947d3 ShellPkg: Replace BSD License with
> BSD+Patent License
> fdb6510955 ShellBinPkg: Replace BSD License with
> BSD+Patent License
> dc5f8d93d9 SecurityPkg: Replace BSD License with
> BSD+Patent License
> 841d42a913 QuarkSocPkg: Replace BSD License with
> BSD+Patent License
> 75c3756e18 QuarkPlatformPkg: Replace BSD License with
> BSD+Patent License
> 657491e5a3 PcAtChipsetPkg: Replace BSD License with
> BSD+Patent License
> 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
> 521b8139c7 OptionRomPkg: Replace BSD License with
> BSD+Patent License
> ec339f8320 Omap35xxPkg: Replace BSD License with
> BSD+Patent License
> ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License 
> aa99b9adeb NetworkPkg: Replace BSD License with
> BSD+Patent License
> 88bdc989d7 MdePkg: Replace BSD License with BSD+Patent License
> 5628b5e5c7 MdeModulePkg: Replace BSD License with
> BSD+Patent License
> 505e36838d IntelSiliconPkg: Replace BSD License with
> BSD+Patent License
> e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with
> BSD+Patent License
> d7347d7ef0 IntelFspPkg: Replace BSD License with
> BSD+Patent License
> 487741dd60 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent 
> License 0e8d264faf IntelFsp2Pkg: Replace BSD License with
> BSD+Patent License
> f4835e9508 IntelFrameworkPkg: Replace BSD License with
> BSD+Patent License
> d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License with 
> BSD+Patent License 5a3c8a14ce FmpDevicePkg: Replace BSD License with
> BSD+Patent License
> 87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent License 
> f336d7d7de EmulatorPkg: Replace BSD License with
> BSD+Patent License
> 5ea93a6088 EmbeddedPkg: Replace BSD License with
> BSD+Patent License
> 2afa7c0820 DynamicTablesPkg: Replace BSD License with
> BSD+Patent License
> 4768af6404 CryptoPkg: Replace BSD License with
> BSD+Patent License
> 9aecbee0a3 CorebootPayloadPkg: Replace BSD License with
> BSD+Patent License
> e7716450b8 CorebootModulePkg: Replace BSD License with
> BSD+Patent License
> 04fb04e0aa BeagleBoardPkg: Replace BSD License with
> BSD+Patent License
> c910bd4e91 ArmVirtPkg: Replace BSD License with
> BSD+Patent License
> 6f98d2f305 ArmPlatformPkg: Replace BSD License with
> BSD+Patent License
> 1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent License 
> 0fb7bd552b BaseTools: Replace BSD License with
> BSD+Patent License
> bc61733285 edk2: Replace BSD License with BSD+Patent License 
> 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD to BSD+Patent
> 17a33094a9 edk2: Add License-History.txt
> 
> Best regards,
> 
> Mike

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[chasel.chiu]

I'm ok with the changes in below packages.

Thanks!
Chasel

Reviewed-by: Chasel Chiu <chasel.chiu@intel.com>
For 
IntelFspPkg
IntelFspWrapperPkg
IntelFsp2Pkg
IntelFsp2WrapperPkg


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Liming Gao
> Sent: Monday, April 8, 2019 1:10 PM
> To: devel@edk2.groups.io; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> Mike:
>   I also review QuarkPlatformPkg, QuarkSocPkg. The changes look good to me.
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> Thanks
> Liming
> >-----Original Message-----
> >From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> >Michael D Kinney
> >Sent: Thursday, April 04, 2019 7:42 AM
> >To: devel@edk2.groups.io; Kinney, Michael D
> ><michael.d.kinney@intel.com>
> >Subject: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> >License
> >
> >Hello,
> >
> >New in V3
> >=========
> >* Update the base of the patch series from edk2-stable201903 to
> >  7ed72121b7 that is after the file add/remove freeze:
> >
> >  https://lists.01.org/pipermail/edk2-devel/2019-April/038574.html
> >
> >* Replace copyright line in License.txt in root with a single copyright
> >  for "TianoCore and contributors".
> >* Clarify commit message for changes to License.txt to state the text
> >  differences are larger than expected due to differences in line breaks.
> >* There is one less patch in the series than V2 due to the retirement
> >  of the EdkCompatibilityPkg.
> >* The git feature "git range-diff" can be used to compare the V2 and
> >  V3 branches even though they have different bases.  If you have both
> >  the V2 and V3 branches in your local repo, you can use the following
> >  command to see the changes.  Most are due to the removal of .S files
> >  in March.  If you pipe through grep looking for "diff --git" you will
> >  see the list of files with differences.
> >
> >  git range-diff edk2-stable201903..Bug_1373_BsdPatentLicense_V2
> >7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> >New in V2
> >=========
> >* Remove Cc lines from commit messages
> >* Remove branch reference from commit messages
> >* Change license in 2 files missed in OvmfPkg
> >* Update OvmfPkg/License.txt to BSD+Patent as the default license
> >* Move the portions of Contributions.txt in the root of edk2 to
> >  Readme.md in the root of edk2 that describe how to contribute
> >  along with the commit message format.
> >* Add to Readme.md in the root of edk2 that Signed-off-by means that
> >  the contributor certifies compliance to the Developer's Certificate
> >  of Origin 1.1.  https://developercertificate.org =========
> >
> >BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> >This change is based on the following emails:
> >  https://lists.01.org/pipermail/edk2-devel/2019-February/036260.html
> >  https://lists.01.org/pipermail/edk2-devel/2018-October/030385.html
> >
> >RFCs with detailed process for the license change:
> >  V3: https://lists.01.org/pipermail/edk2-devel/2019-March/038116.html
> >  V2: https://lists.01.org/pipermail/edk2-devel/2019-March/037669.html
> >  V1: https://lists.01.org/pipermail/edk2-devel/2019-March/037500.html
> >
> >I have posted the patch series for review on the following branch using
> >7ed72121b7 as the base for the patch series.
> >
> >  https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense_V3
> >
> >The commits in patch series can be viewed here:
> >
> >
> >https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPatentLicense_V
> >3
> >
> >The patch series has one patch per package along with a few patches to
> >update the license information in the root of the edk2 repository as
> >described in the RFC V3.
> >
> >Due to the size of the patch series, I prefer to not send the patch
> >emails.  Instead, please perform code reviews using content from the
> >branch.
> >
> >All EDK II package maintainers and package reviewers should provide
> >review feedback for their packages.  The critical part of the review
> >is:
> >1) Any changes that cause build breaks or logic changes.  These code
> >   changes are intended to only modify license contents in comment
> >   blocks.
> >2) Any file that has been changed to BSD+Patent, but should remain
> >   with the current license.
> >3) Any file that that has not changed to BSD+Patent, but should be
> >   changed to BSD+Patent.
> >
> >Feedback and Reviewed-by emails should identify the patch the feedback
> >applies using the patch summary listed below.  The goal is to complete
> >all reviews to support the commit of these patches on April 9, 2019.
> >
> >eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
> >224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent
> >f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with
> >BSD+Patent License
> >845b945044 StdLib: Replace BSD License with BSD+Patent License
> >e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
> >a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with BSD+Patent
> >License 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with
> >BSD+Patent License
> >a67328cbb4 UefiCpuPkg: Replace BSD License with BSD+Patent License
> >248d91c908 StandaloneMmPkg: Replace BSD License with BSD+Patent License
> >415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent
> >License 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> >BSD+Patent License
> >9ffa4947d3 ShellPkg: Replace BSD License with BSD+Patent License
> >fdb6510955 ShellBinPkg: Replace BSD License with BSD+Patent License
> >dc5f8d93d9 SecurityPkg: Replace BSD License with BSD+Patent License
> >841d42a913 QuarkSocPkg: Replace BSD License with BSD+Patent License
> >75c3756e18 QuarkPlatformPkg: Replace BSD License with BSD+Patent
> >License
> >657491e5a3 PcAtChipsetPkg: Replace BSD License with BSD+Patent License
> >4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
> >521b8139c7 OptionRomPkg: Replace BSD License with BSD+Patent License
> >ec339f8320 Omap35xxPkg: Replace BSD License with BSD+Patent License
> >ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License
> >aa99b9adeb NetworkPkg: Replace BSD License with BSD+Patent License
> >88bdc989d7 MdePkg: Replace BSD License with BSD+Patent License
> >5628b5e5c7 MdeModulePkg: Replace BSD License with BSD+Patent License
> >505e36838d IntelSiliconPkg: Replace BSD License with BSD+Patent License
> >e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with BSD+Patent
> >License
> >d7347d7ef0 IntelFspPkg: Replace BSD License with BSD+Patent License
> >487741dd60 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent
> >License 0e8d264faf IntelFsp2Pkg: Replace BSD License with BSD+Patent
> >License
> >f4835e9508 IntelFrameworkPkg: Replace BSD License with BSD+Patent
> >License d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License with
> >BSD+Patent License
> >5a3c8a14ce FmpDevicePkg: Replace BSD License with BSD+Patent License
> >87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent License
> >f336d7d7de EmulatorPkg: Replace BSD License with BSD+Patent License
> >5ea93a6088 EmbeddedPkg: Replace BSD License with BSD+Patent License
> >2afa7c0820 DynamicTablesPkg: Replace BSD License with BSD+Patent
> >License
> >4768af6404 CryptoPkg: Replace BSD License with BSD+Patent License
> >9aecbee0a3 CorebootPayloadPkg: Replace BSD License with BSD+Patent
> >License
> >e7716450b8 CorebootModulePkg: Replace BSD License with BSD+Patent
> >License 04fb04e0aa BeagleBoardPkg: Replace BSD License with BSD+Patent
> >License
> >c910bd4e91 ArmVirtPkg: Replace BSD License with BSD+Patent License
> >6f98d2f305 ArmPlatformPkg: Replace BSD License with BSD+Patent License
> >1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent License
> >0fb7bd552b BaseTools: Replace BSD License with BSD+Patent License
> >bc61733285 edk2: Replace BSD License with BSD+Patent License 8ee83c5dcd
> >edk2: Change License.txt from 2-Clause BSD to BSD+Patent
> >17a33094a9 edk2: Add License-History.txt
> >
> >Best regards,
> >
> >Mike
> >
> >
> >
> 
> 
> 

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Sun, Zailiang]

For Vlv2TbltDevicePkg and Vlv2DeviceRefCodePkg

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>


> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Michael D Kinney
> Sent: Saturday, April 06, 2019 5:40 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent
> License
> 
> EDK II Maintainers and Reviewers,
> 
> I have create an EDK II Wiki Page to track the progress of the reviews for
> change of EDK II to a BSD+Patent License.
> 
> https://github.com/tianocore/tianocore.github.io/wiki/Change-EDK-II-to-
> BSD-Patent-License.
> 
> Please review your patches and provide feedback and reviewed-by
> responses to this list by April 8, 2019 to support the commit of the changes on
> April 9, 2019.
> 
> Thanks,
> 
> Mike
> 
> 
> > -----Original Message-----
> > From: Kinney, Michael D
> > Sent: Wednesday, April 3, 2019 4:42 PM
> > To: devel@edk2.groups.io; Kinney, Michael D
> > <michael.d.kinney@intel.com>
> > Subject: [edk2] [PATCH V3] Change EDK II to BSD+Patent License
> >
> > Hello,
> >
> > New in V3
> > =========
> > * Update the base of the patch series from edk2-
> > stable201903 to
> >   7ed72121b7 that is after the file add/remove freeze:
> >
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > April/038574.html
> >
> > * Replace copyright line in License.txt in root with a single
> > copyright
> >   for "TianoCore and contributors".
> > * Clarify commit message for changes to License.txt to state the text
> >   differences are larger than expected due to differences in line
> > breaks.
> > * There is one less patch in the series than V2 due to the retirement
> >   of the EdkCompatibilityPkg.
> > * The git feature "git range-diff" can be used to compare the V2 and
> >   V3 branches even though they have different bases.
> > If you have both
> >   the V2 and V3 branches in your local repo, you can use the following
> >   command to see the changes.  Most are due to the removal of .S files
> >   in March.  If you pipe through grep looking for "diff --git" you
> > will
> >   see the list of files with differences.
> >
> >   git range-diff edk2-
> > stable201903..Bug_1373_BsdPatentLicense_V2
> > 7ed72121b7..Bug_1373_BsdPatentLicense_V3
> >
> > New in V2
> > =========
> > * Remove Cc lines from commit messages
> > * Remove branch reference from commit messages
> > * Change license in 2 files missed in OvmfPkg
> > * Update OvmfPkg/License.txt to BSD+Patent as the default license
> > * Move the portions of Contributions.txt in the root of
> > edk2 to
> >   Readme.md in the root of edk2 that describe how to contribute
> >   along with the commit message format.
> > * Add to Readme.md in the root of edk2 that Signed-off- by means that
> >   the contributor certifies compliance to the Developer's Certificate
> >   of Origin 1.1.  https://developercertificate.org =========
> >
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1373
> >
> > This change is based on the following emails:
> >   https://lists.01.org/pipermail/edk2-devel/2019-
> > February/036260.html
> >   https://lists.01.org/pipermail/edk2-devel/2018-
> > October/030385.html
> >
> > RFCs with detailed process for the license change:
> >   V3: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/038116.html
> >   V2: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037669.html
> >   V1: https://lists.01.org/pipermail/edk2-devel/2019-
> > March/037500.html
> >
> > I have posted the patch series for review on the following branch
> > using
> > 7ed72121b7 as the base for the patch series.
> >
> >
> > https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPaten
> > tLicense_V3
> >
> > The commits in patch series can be viewed here:
> >
> >
> > https://github.com/mdkinney/edk2/commits/Bug_1373_BsdPa
> > tentLicense_V3
> >
> > The patch series has one patch per package along with a few patches to
> > update the license information in the root of the
> > edk2 repository
> > as described in the RFC V3.
> >
> > Due to the size of the patch series, I prefer to not send the patch
> > emails.  Instead, please perform code reviews using content from the
> > branch.
> >
> > All EDK II package maintainers and package reviewers should provide
> > review feedback for their packages.  The critical part of the review
> > is:
> > 1) Any changes that cause build breaks or logic changes.  These code
> >    changes are intended to only modify license contents in comment
> >    blocks.
> > 2) Any file that has been changed to BSD+Patent, but should remain
> >    with the current license.
> > 3) Any file that that has not changed to BSD+Patent, but should be
> >    changed to BSD+Patent.
> >
> > Feedback and Reviewed-by emails should identify the patch the feedback
> > applies using the patch summary listed below.  The goal is to complete
> > all reviews to support the commit of these patches on April 9, 2019.
> >
> > eece5f8a6e edk2: Remove Contributions.txt and update Readme.md
> > 224dce1ae5 OvmfPkg: Change License.txt from 2-Clause BSD to
> BSD+Patent
> > f3cbc2ffc7 StdLibPrivateInternalFiles: Replace BSD License with
> > BSD+Patent License
> > 845b945044 StdLib: Replace BSD License with BSD+Patent License
> > e55c8532c9 AppPkg: Replace BSD License with BSD+Patent License
> > a6df2af909 Vlv2TbltDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 6360b3f3af Vlv2DeviceRefCodePkg: Replace BSD License with BSD+Patent
> > License
> > a67328cbb4 UefiCpuPkg: Replace BSD License with
> > BSD+Patent License
> > 248d91c908 StandaloneMmPkg: Replace BSD License with
> > BSD+Patent License
> > 415927330c SourceLevelDebugPkg: Replace BSD License with BSD+Patent
> > License 4cd6c3f31f SignedCapsulePkg: Replace BSD License with
> > BSD+Patent License
> > 9ffa4947d3 ShellPkg: Replace BSD License with
> > BSD+Patent License
> > fdb6510955 ShellBinPkg: Replace BSD License with
> > BSD+Patent License
> > dc5f8d93d9 SecurityPkg: Replace BSD License with
> > BSD+Patent License
> > 841d42a913 QuarkSocPkg: Replace BSD License with
> > BSD+Patent License
> > 75c3756e18 QuarkPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 657491e5a3 PcAtChipsetPkg: Replace BSD License with
> > BSD+Patent License
> > 4ac687248f OvmfPkg: Replace BSD License with BSD+Patent License
> > 521b8139c7 OptionRomPkg: Replace BSD License with
> > BSD+Patent License
> > ec339f8320 Omap35xxPkg: Replace BSD License with
> > BSD+Patent License
> > ad1bf1a53a Nt32Pkg: Replace BSD License with BSD+Patent License
> > aa99b9adeb NetworkPkg: Replace BSD License with
> > BSD+Patent License
> > 88bdc989d7 MdePkg: Replace BSD License with BSD+Patent License
> > 5628b5e5c7 MdeModulePkg: Replace BSD License with
> > BSD+Patent License
> > 505e36838d IntelSiliconPkg: Replace BSD License with
> > BSD+Patent License
> > e1fecb94e7 IntelFspWrapperPkg: Replace BSD License with
> > BSD+Patent License
> > d7347d7ef0 IntelFspPkg: Replace BSD License with
> > BSD+Patent License
> > 487741dd60 IntelFsp2WrapperPkg: Replace BSD License with BSD+Patent
> > License 0e8d264faf IntelFsp2Pkg: Replace BSD License with
> > BSD+Patent License
> > f4835e9508 IntelFrameworkPkg: Replace BSD License with
> > BSD+Patent License
> > d9af7c1d3b IntelFrameworkModulePkg: Replace BSD License with
> > BSD+Patent License 5a3c8a14ce FmpDevicePkg: Replace BSD License with
> > BSD+Patent License
> > 87d9ee37c5 FatPkg: Replace BSD License with BSD+Patent License
> > f336d7d7de EmulatorPkg: Replace BSD License with
> > BSD+Patent License
> > 5ea93a6088 EmbeddedPkg: Replace BSD License with
> > BSD+Patent License
> > 2afa7c0820 DynamicTablesPkg: Replace BSD License with
> > BSD+Patent License
> > 4768af6404 CryptoPkg: Replace BSD License with
> > BSD+Patent License
> > 9aecbee0a3 CorebootPayloadPkg: Replace BSD License with
> > BSD+Patent License
> > e7716450b8 CorebootModulePkg: Replace BSD License with
> > BSD+Patent License
> > 04fb04e0aa BeagleBoardPkg: Replace BSD License with
> > BSD+Patent License
> > c910bd4e91 ArmVirtPkg: Replace BSD License with
> > BSD+Patent License
> > 6f98d2f305 ArmPlatformPkg: Replace BSD License with
> > BSD+Patent License
> > 1ce858bf27 ArmPkg: Replace BSD License with BSD+Patent License
> > 0fb7bd552b BaseTools: Replace BSD License with
> > BSD+Patent License
> > bc61733285 edk2: Replace BSD License with BSD+Patent License
> > 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD to BSD+Patent
> > 17a33094a9 edk2: Add License-History.txt
> >
> > Best regards,
> >
> > Mike
> 
> 
> 

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Laszlo Ersek]

On 04/04/19 01:42, Michael D Kinney wrote:

> 17a33094a9 edk2: Add License-History.txt

I have a minuscule comment for this patch.

In the "Key Dates" section, you list two dates:
- July 18, 2017
- April 9, 2019

The 2nd date refers to a commit (that is, not patch authorship) date. I
think that's fine.

The first date however refers to a patch authorship date, not a commit
date. I don't feel too strongly about this, but I think the consistency
could be improved.

In particular, from the commits listed in
<https://bugzilla.tianocore.org/show_bug.cgi?id=629#c3>, the most
relevant seems to be b6538c118ae8. The authorship date on that patch is
indeed 2017-07-18; however its commit date is 2017-08-03.

If, for one of the "key dates" above, we use a "commit date" (and not an
"authorship date"), then we might want to do the same for the other "key
date" (i.e., we might want to replace "July 18, 2017" with "August 3,
2017").

Anyway, I'll leave it up to you; I'm fine with the patch as-is.

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD to BSD+Patent

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> bc61733285 edk2: Replace BSD License with BSD+Patent License

Reviewed-by: Laszlo Ersek <lersek@redhat.com>


> eece5f8a6e edk2: Remove Contributions.txt and update Readme.md

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks
Laszlo

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Michael D Kinney]

Laszlo,

I agree dates should be consistent.  For these 
types of dates, I think the commit date is the
better choice.  I will change July 18 to Aug 3.

Thanks,

Mike

> -----Original Message-----
> From: Laszlo Ersek [mailto:lersek@redhat.com]
> Sent: Monday, April 8, 2019 5:13 AM
> To: devel@edk2.groups.io; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: Re: [edk2-devel] [edk2] [PATCH V3] Change EDK
> II to BSD+Patent License
> 
> On 04/04/19 01:42, Michael D Kinney wrote:
> 
> > 17a33094a9 edk2: Add License-History.txt
> 
> I have a minuscule comment for this patch.
> 
> In the "Key Dates" section, you list two dates:
> - July 18, 2017
> - April 9, 2019
> 
> The 2nd date refers to a commit (that is, not patch
> authorship) date. I
> think that's fine.
> 
> The first date however refers to a patch authorship
> date, not a commit
> date. I don't feel too strongly about this, but I think
> the consistency
> could be improved.
> 
> In particular, from the commits listed in
> <https://bugzilla.tianocore.org/show_bug.cgi?id=629#c3>
> , the most
> relevant seems to be b6538c118ae8. The authorship date
> on that patch is
> indeed 2017-07-18; however its commit date is 2017-08-
> 03.
> 
> If, for one of the "key dates" above, we use a "commit
> date" (and not an
> "authorship date"), then we might want to do the same
> for the other "key
> date" (i.e., we might want to replace "July 18, 2017"
> with "August 3,
> 2017").
> 
> Anyway, I'll leave it up to you; I'm fine with the
> patch as-is.
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> 
> > 8ee83c5dcd edk2: Change License.txt from 2-Clause BSD
> to BSD+Patent
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> 
> > bc61733285 edk2: Replace BSD License with BSD+Patent
> License
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> 
> > eece5f8a6e edk2: Remove Contributions.txt and update
> Readme.md
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> 
> Thanks
> Laszlo

Re: [edk2-devel] [edk2] [PATCH V3] Change EDK II to BSD+Patent License

[Laszlo Ersek]

Sami, Alexei: please jump to the end of this email.

On 04/08/19 22:25, Michael D Kinney wrote:
> EDK II Maintainers and Reviewers,
>
> I have rebased the patch series as of April 8, 2019, and I have
> added the Reviewed-by tags I have received.  Please review the
> commit messages in the V3a branch verify that I have not missed
> any reviewers.

I ran a range-diff between master..v3 and master..v3a (with v3a pointing
to commit c7e9f1bac2a2). Results:

(1) All my R-b's have been picked up. That means the following 7
patches:

edk2: Add License-History.txt
edk2: Change License.txt from 2-Clause BSD to BSD+Patent
edk2: Replace BSD License with BSD+Patent License
ArmVirtPkg: Replace BSD License with BSD+Patent License
OvmfPkg: Replace BSD License with BSD+Patent License
OvmfPkg: Change License.txt from 2-Clause BSD to BSD+Patent
edk2: Remove Contributions.txt and update Readme.md

(2) my R-b has not been mistakenly added to any patch I haven't
reviewed, so that's OK too.

(3) I did notice something interesting: the latest rebase of the patch

  UefiCpuPkg: Replace BSD License with BSD+Patent License

seems to have introduced a small unexpected change. Let me quote the
range-diff output:

> 40:  a67328cbb41d ! 40:  8c92495fcf11 UefiCpuPkg: Replace BSD License with BSD+Patent License
>     @@ -18,6 +18,8 @@
>
>          Contributed-under: TianoCore Contribution Agreement 1.1
>          Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
>     +    Reviewed-by: Eric Dong <eric.dong@intel.com>
>     +    Reviewed-by: Ray Ni <ray.ni@intel.com>
>
>      diff --git a/UefiCpuPkg/UefiCpuPkg.dec b/UefiCpuPkg/UefiCpuPkg.dec
>      --- a/UefiCpuPkg/UefiCpuPkg.dec
>     @@ -1134,7 +1136,7 @@
>      @@
>         handles cases where local APIC is disabled.
>
>     -   Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
>      -  This program and the accompanying materials
>      -  are licensed and made available under the terms and conditions of the BSD License
>      -  which accompanies this distribution.  The full text of the license may be found at
>     @@ -1210,7 +1212,7 @@
>      @@
>         Register CPU Features Library to register and manage CPU features.
>
>     -   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>      -  This program and the accompanying materials
>      -  are licensed and made available under the terms and conditions of the BSD License
>      -  which accompanies this distribution.  The full text of the license may be found at
>     @@ -1400,7 +1402,7 @@
>      @@
>         not provided for that register.
>
>     -   Copyright (c) 2015 - 2018, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2015 - 2019, Intel Corporation. All rights reserved.<BR>
>      -  This program and the accompanying materials are licensed and made available under
>      -  the terms and conditions of the BSD License which accompanies this distribution.
>      -  The full text of the license may be found at
>     @@ -2347,7 +2349,7 @@
>      @@
>       #  Register CPU Features Library DXE instance.
>       #
>     - #  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>     + #  Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>      -#  This program and the accompanying materials
>      -#  are licensed and made available under the terms and conditions of the BSD License
>      -#  which accompanies this distribution.  The full text of the license may be found at
>     @@ -2366,7 +2368,7 @@
>      @@
>       #  Register CPU Features Library PEI instance.
>       #
>     - #  Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>     + #  Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>      -#  This program and the accompanying materials
>      -#  are licensed and made available under the terms and conditions of the BSD License
>      -#  which accompanies this distribution.  The full text of the license may be found at
>     @@ -2856,7 +2858,7 @@
>      @@
>         CPU Register Table Library definitions.
>
>     -   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>      -  This program and the accompanying materials
>      -  are licensed and made available under the terms and conditions of the BSD License
>      -  which accompanies this distribution.  The full text of the license may be found at
>     @@ -3785,7 +3787,7 @@
>      @@
>         UEFI Application to display CPUID leaf information.
>
>     -   Copyright (c) 2016 - 2018, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2016 - 2019, Intel Corporation. All rights reserved.<BR>
>      -  This program and the accompanying materials
>      -  are licensed and made available under the terms and conditions of the BSD License
>      -  which accompanies this distribution.  The full text of the license may be found at
>     @@ -4049,7 +4051,7 @@
>      --- a/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
>      +++ b/UefiCpuPkg/Library/BaseXApicLib/BaseXApicLib.c
>      @@
>     -   Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
>         Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
>
>      -  This program and the accompanying materials
>     @@ -4068,7 +4070,7 @@
>      --- a/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
>      +++ b/UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.c
>      @@
>     -   Copyright (c) 2010 - 2018, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2010 - 2019, Intel Corporation. All rights reserved.<BR>
>         Copyright (c) 2017, AMD Inc. All rights reserved.<BR>
>
>      -  This program and the accompanying materials
>     @@ -4697,7 +4699,7 @@
>      @@
>         CPU Register Table Library functions.
>
>     -   Copyright (c) 2017, Intel Corporation. All rights reserved.<BR>
>     +   Copyright (c) 2017 - 2019, Intel Corporation. All rights reserved.<BR>
>      -  This program and the accompanying materials
>      -  are licensed and made available under the terms and conditions of the BSD License
>      -  which accompanies this distribution.  The full text of the license may be found at
>     @@ -4709,6 +4711,26 @@
>
>       **/
>
>     +@@
>     +   //
>     +   if (Before) {
>     +     PreviousEntry = GetPreviousNode (FeatureList, FindEntry);
>     +-  } else {
>     ++  } else {
>     ++
>     +     PreviousEntry = GetNextNode (FeatureList, FindEntry);
>     +   }
>     +
>     +@@
>     +       }
>     +     }
>     +   }
>     +-}
>     ++}
>     ++
>     +
>     + /**
>     +   Checks and adjusts current CPU features per dependency relationship.
>
>      diff --git a/UefiCpuPkg/Library/SecPeiDxeTimerLibUefiCpu/X86TimerLib.c b/UefiCpuPkg/Library/SecPeiDxeTimerLibUefiCpu/X86TimerLib.c
>      --- a/UefiCpuPkg/Library/SecPeiDxeTimerLibUefiCpu/X86TimerLib.c

The contextual differences due to the copyright year updates are fine.

However, the v3a version of the patch, namely commit 8c92495fcf11,
silently fixes some whitespace errors too, in file
"UefiCpuPkg/Library/RegisterCpuFeaturesLib/RegisterCpuFeaturesLib.c",
which were originally introduced in commit b3c71b472dff
("UefiCpuPkg/RegisterCpuFeaturesLib: Add logic to support semaphore
type.", 2018-10-22).

The v3 version of the patch set didn't include that silent whitespace
fix.

I'm not suggesting that the series should be re-spun one more time just
because of this though!

(4) I've test-built OVMF and ArmVirtQemu in my usual build configs, at
c7e9f1bac2a2, and they all build fine.

Back to the email:

On 04/08/19 22:25, Michael D Kinney wrote:
> I have also verified that no files have been
> added/removed since the V3 patch series was posted last week.
>
> https://github.com/mdkinney/edk2/tree/Bug_1373_BsdPatentLicense_V3a
>
> I have updated the status of the patch reviews on the Wiki page:
>
> https://github.com/tianocore/tianocore.github.io/wiki/Change-EDK-II-to-BSD-Patent-License
>
> I am only missing a review for the DynamicTablesPkg.  Please let
> Me know if you have can help complete that review.

Adding Sami, Alexei, Leif and Ard, for this paragraph.

Thanks
Laszlo