public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"Gao, Zhichao" <zhichao.gao@intel.com>
Cc: "Qian, Yi" <yi.qian@intel.com>, "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: Add new API ResetSystem
Date: Mon, 15 Apr 2019 03:20:30 +0000	[thread overview]
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C51B47@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <20190415030611.12464-22-zhichao.gao@intel.com>

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of
> Gao, Zhichao
> Sent: Monday, April 15, 2019 11:06 AM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>; Gao,
> Liming <liming.gao@intel.com>
> Subject: [edk2-devel] [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib:
> Add new API ResetSystem
> 
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1460
> 
> Add a new API ResetSystem to this ResetSystemLib instance.
> It only adds the basic functions from ResetSystemRuntimeDxe.
> Lacking of this interface may cause link error, if some drivers use this new API
> and link to this library instance.
> Notes:
> This library API only provide a basic function of reset. Full function should use
> the instance in the MdeModulePkg and make sure the depex driver is
> dispatched.
> 
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Zhichao Gao <zhichao.gao@intel.com>
> ---
>  .../Library/ResetSystemLib/ResetSystemLib.c   | 43 +++++++++++++++++++
>  1 file changed, 43 insertions(+)
> 
> diff --git a/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> b/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> index 1cd6f80891..02457352e9 100644
> --- a/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> +++ b/Vlv2TbltDevicePkg/Library/ResetSystemLib/ResetSystemLib.c
> @@ -190,3 +190,46 @@ ResetPlatformSpecific (  {
>    ResetCold ();
>  }
> +
> +/**
> +  The ResetSystem function resets the entire platform.
> +
> +  @param[in] ResetType      The type of reset to perform.
> +  @param[in] ResetStatus    The status code for the reset.
> +  @param[in] DataSize       The size, in bytes, of ResetData.
> +  @param[in] ResetData      For a ResetType of EfiResetCold, EfiResetWarm,
> or EfiResetShutdown
> +                            the data buffer starts with a Null-terminated string, optionally
> +                            followed by additional binary data. The string is a description
> +                            that the caller may use to further indicate the reason for the
> +                            system reset.
> +**/
> +VOID
> +EFIAPI
> +ResetSystem (
> +  IN EFI_RESET_TYPE               ResetType,
> +  IN EFI_STATUS                   ResetStatus,
> +  IN UINTN                        DataSize,
> +  IN VOID                         *ResetData OPTIONAL
> +  )
> +{
> +  switch (ResetType) {
> +  case EfiResetWarm:
> +    ResetWarm ();
> +    break;
> +
> +  case EfiResetCold:
> +    ResetCold ();
> +    break;
> +
> +  case EfiResetShutdown:
> +    ResetShutdown ();
> +    return ;
> +
> +  case EfiResetPlatformSpecific:
> +    ResetPlatformSpecific (DataSize, ResetData);
> +    return;
> +
> +  default:
> +    return ;
> +  }
> +}
> --
> 2.21.0.windows.1
> 
> 
> 


  reply	other threads:[~2019-04-15  3:20 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-15  3:05 [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Gao, Zhichao
2019-04-15  3:05 ` [PATCH 01/25] MdePkg/UefiSpec.h: Change comments of EFI_RESET_SYSTEM Gao, Zhichao
2019-04-15  3:05 ` [PATCH 02/25] MdePkg/PiPeiCis.h: Change comments of EFI_PEI_RESET2_SYSTEM Gao, Zhichao
2019-04-15  3:05 ` [PATCH 03/25] MdePkg/PeiServicesLib.h: Change comments of PeiServicesResetSystem2 Gao, Zhichao
2019-04-15  3:05 ` [PATCH 04/25] MdePkg/PeiServicesLib.c: " Gao, Zhichao
2019-04-15  3:05 ` [PATCH 05/25] SecurityPkg/Tcg2Dxe: Change comments of ShutdownTpmOnReset Gao, Zhichao
2019-04-15  3:05 ` [PATCH 06/25] MdeModulePkg/ResetSystemLib.h: Change comments of ResetSystem Gao, Zhichao
2019-04-15  3:05 ` [PATCH 07/25] MdeModulePkg/DxeResetSystemLib.c: " Gao, Zhichao
2019-04-15  3:05 ` [PATCH 08/25] MdeModulePkg/BaseResetSystemLibNull.c: " Gao, Zhichao
2019-04-15  3:05 ` [PATCH 09/25] MdeModulePkg/RuntimeResetSystemLib.c: Change comments Gao, Zhichao
2019-04-15  3:05 ` [PATCH 10/25] MdeModulePkg/PeiResetSystemlib.c: Change comments of ResetSystem Gao, Zhichao
2019-04-15  3:05 ` [PATCH 11/25] MdeModulePkg/ResetSystemRuntimeDxe: Change comments Gao, Zhichao
2019-04-15  3:05 ` [PATCH 12/25] MdeModulePkg/ResetSystemPei: Change comments of ResetSystem2 Gao, Zhichao
2019-04-15  3:05 ` [PATCH 13/25] MdeModulePkg/PeiMain: Change comments of PeiResetSystem2 Gao, Zhichao
2019-04-15  3:06 ` [PATCH 14/25] MdeModulePkg/NvmExpressHci.c: Change comments Gao, Zhichao
2019-04-15  3:06 ` [PATCH 15/25] BeagleBoardPkg/ResetSystemLib: Add new API ResetSystem Gao, Zhichao
2019-04-15  9:51   ` [edk2-devel] " Leif Lindholm
2019-04-15  3:06 ` [PATCH 16/25] CorebootPayloadPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15  3:06 ` [PATCH 17/25] Nt32Pkg/ResetSystemLib: " Gao, Zhichao
2019-04-17  3:15   ` [edk2-devel] " Wu, Hao A
2019-04-15  3:06 ` [PATCH 18/25] OvmfPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15 16:38   ` Laszlo Ersek
2019-04-15  3:06 ` [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15  3:06 ` [PATCH 20/25] QuarkSocPkg/ResetSystemLib: " Gao, Zhichao
2019-04-15  3:06 ` [PATCH 21/25] Vlv2TbltdevicePkg/ResetSystemLib: " Gao, Zhichao
2019-04-15  3:20   ` Sun, Zailiang [this message]
2019-04-15  3:06 ` [PATCH 22/25] ArmPkg/ArmSmcPsciResetSystemLib: Add a " Gao, Zhichao
2019-04-15  9:52   ` Leif Lindholm
2019-04-15  3:06 ` [PATCH 23/25] ArmVirtPkg/ArmVirtPsciResetSystemLib: " Gao, Zhichao
2019-04-15  3:06 ` [PATCH 24/25] MdeModulePkg/ResetUtilityLib: Add a new API ResetSystemWithSubtype Gao, Zhichao
2019-04-17  5:24   ` Wu, Hao A
2019-04-15  3:06 ` [PATCH 25/25] " Gao, Zhichao
2019-04-17  5:47   ` [edk2-devel] " Wu, Hao A
2019-04-17  1:19 ` [edk2-devel] [PATCH 00/25] Add the new APIs ResetSystem and ResetSystemWithSubtype Liming Gao
2019-04-17  2:45 ` Wu, Hao A
     [not found] ` <159586F2D3C4CEE3.6441@groups.io>
     [not found]   ` <3CE959C139B4C44DBEA1810E3AA6F9000B7C400F@SHSMSX101.ccr.corp.intel.com>
2019-04-25  6:22     ` [edk2-devel] [PATCH 19/25] PcAtChipsetPkg/ResetSystemLib: Add new API ResetSystem Ni, Ray

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7CB7EF03E15B5D48981329A508747A9850C51B47@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox