From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zailiang.sun@intel.com)
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by groups.io with SMTP; Thu, 09 May 2019 00:54:02 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:54:02 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,449,1549958400"; 
   d="scan'208";a="169892747"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga002.fm.intel.com with ESMTP; 09 May 2019 00:54:00 -0700
Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:53:57 -0700
Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by
 fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:53:57 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX101.ccr.corp.intel.com ([169.254.1.129]) with mapi id 14.03.0415.000;
 Thu, 9 May 2019 15:53:55 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable protocols to depex
Thread-Topic: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable
 protocols to depex
Thread-Index: AQHVBiAQQVfn/vph50GkSqdGG2ozMaZibG3A
Date: Thu, 9 May 2019 07:53:54 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C62DC4@SHSMSX104.ccr.corp.intel.com>
References: <20190509043111.15272-1-michael.d.kinney@intel.com>
 <20190509043111.15272-4-michael.d.kinney@intel.com>
In-Reply-To: <20190509043111.15272-4-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, May 9, 2019 12:31 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [Patch 03/16] Vlv2TbltDevicePkg/AcpiPlatform: Add variable
> protocols to depex
>=20
> Add the arch protocols gEfiVariableArchProtocolGuid and
> gEfiVariableWriteArchProtocolGuid to the dependency expression for the
> AcpiPlatform module to guarantee that the variables that AcpiPlatform
> depends upon are set before they are used by this module.
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf | 10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
>=20
> diff --git a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> index 8422985764..c59920db03 100644
> --- a/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> +++ b/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.inf
> @@ -1,10 +1,12 @@
>  #
>  #
> -# Copyright (c)  1999  - 2018, Intel Corporation. All rights reserved
> -#
>=20
> +# Copyright (c)  1999  - 2019, Intel Corporation. All rights reserved #
> +
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
> -#
>=20
> +#
> +
>  #
>  #
>  #  Module Name:
> @@ -79,6 +81,8 @@ [Pcd]
>    gEfiMdeModulePkgTokenSpaceGuid.PcdAcpiTableStorageFile
>=20
>  [Depex]
> +  gEfiVariableArchProtocolGuid        AND
> +  gEfiVariableWriteArchProtocolGuid   AND
>    gEfiAcpiSupportProtocolGuid AND
>    gEfiMpServiceProtocolGuid AND
>    gEfiCpuIoProtocolGuid
> --
> 2.21.0.windows.1