From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.43, mailfrom: zailiang.sun@intel.com) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by groups.io with SMTP; Thu, 09 May 2019 00:54:26 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga004.jf.intel.com ([10.7.209.38]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:54:11 -0700 X-ExtLoop1: 1 Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by orsmga004.jf.intel.com with ESMTP; 09 May 2019 00:54:10 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 00:54:10 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 00:54:10 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.18]) with mapi id 14.03.0415.000; Thu, 9 May 2019 15:54:08 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Qian, Yi" Subject: Re: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol Thread-Topic: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Services Protocol Thread-Index: AQHVBiARAetDUkNus0Ch6rGjLg1soqZibHWA Date: Thu, 9 May 2019 07:54:07 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C62DE6@SHSMSX104.ccr.corp.intel.com> References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-5-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-5-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 04/16] Vlv2TbltDevicePkg/PpmPolicy: Fix call to MP Servic= es > Protocol >=20 > The NumberOfEnabledProcessors parameter to the MP Services Protocol > service GetNumberOfProcessors() is not optional and is not allowed to be > NULL. Add the CpuEnabledCount local variable and pass it into > GetNumberOfProcessors(). >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Signed-off-by: Michael D Kinney > --- > Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git a/Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c > b/Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c > index 28de8457ce..3583e324e6 100644 > --- a/Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c > +++ b/Vlv2TbltDevicePkg/PpmPolicy/PpmPolicy.c > @@ -1,5 +1,5 @@ > /** > - Copyright (c) 2009 - 2013, Intel Corporation. All rights reserved.
> + Copyright (c) 2009 - 2019, Intel Corporation. All rights > + reserved.
> SPDX-License-Identifier: BSD-2-Clause-Patent >=20 >=20 > @@ -40,6 +40,7 @@ PpmPolicyEntry( > EFI_HANDLE Handle; > EFI_STATUS Status; > UINTN CpuCount; > + UINTN CpuEnabledCount; > UINT8 CPUMobileFeature; >=20 > PCH_STEPPING Stepping; > @@ -63,7 +64,7 @@ PpmPolicyEntry( > // > // Get processor count from MP service. > // > - Status =3D MpService->GetNumberOfProcessors (MpService, &CpuCount, > NULL); > + Status =3D MpService->GetNumberOfProcessors (MpService, &CpuCount, > + &CpuEnabledCount); > ASSERT_EFI_ERROR (Status); >=20 > // > -- > 2.21.0.windows.1