From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.65, mailfrom: zailiang.sun@intel.com)
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by groups.io with SMTP; Thu, 09 May 2019 00:54:24 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:54:23 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,449,1549958400"; 
   d="scan'208";a="169892870"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
  by fmsmga002.fm.intel.com with ESMTP; 09 May 2019 00:54:23 -0700
Received: from fmsmsx163.amr.corp.intel.com (10.18.125.72) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:54:23 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 fmsmsx163.amr.corp.intel.com (10.18.125.72) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:54:23 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000;
 Thu, 9 May 2019 15:54:17 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: Michael D Kinney <mdkinney@mdkinney-desk.amr.corp.intel.com>, "Qian, Yi"
	<yi.qian@intel.com>
Subject: Re: [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build issue
Thread-Topic: [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build
 issue
Thread-Index: AQHVBiASieGDOAj84EeBEuJt8qm5Z6ZibIWA
Date: Thu, 9 May 2019 07:54:17 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C62DFC@SHSMSX104.ccr.corp.intel.com>
References: <20190509043111.15272-1-michael.d.kinney@intel.com>
 <20190509043111.15272-6-michael.d.kinney@intel.com>
In-Reply-To: <20190509043111.15272-6-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, May 9, 2019 12:31 PM
> To: devel@edk2.groups.io
> Cc: Michael D Kinney <mdkinney@mdkinney-desk.amr.corp.intel.com>; Sun,
> Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [Patch 05/16] Vlv2TbltDevicePkg/SmBiosMiscDxe: Fix GCC build
> issue
>=20
> From: Michael D Kinney <mdkinney@mdkinney-desk.amr.corp.intel.com>
>=20
> Fix loop comparison for end of languages.
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../MiscNumberOfInstallableLanguagesFunction.c         | 10 ++++++----
>  1 file changed, 6 insertions(+), 4 deletions(-)
>=20
> diff --git
> a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFu
> nction.c
> b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFu
> nction.c
> index 9fff8d8850..4a96a2c465 100644
> ---
> a/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFu
> nction.c
> +++
> b/Vlv2TbltDevicePkg/SmBiosMiscDxe/MiscNumberOfInstallableLanguagesFu
> nction.c
> @@ -1,10 +1,12 @@
>  /*++
>=20
> -Copyright (c) 2009 - 2014, Intel Corporation. All rights reserved.<BR>
> -
>=20
> +Copyright (c) 2009 - 2019, Intel Corporation. All rights reserved.<BR>
> +
> +
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
> -
>=20
> +
> +
>=20
>=20
>  Module Name:
> @@ -68,7 +70,7 @@ CurrentLanguageMatch (
>      // Find the best matching RFC 4646 language, compute the offset.
>      //
>      CompareLength =3D AsciiStrLen (BestLanguage);
> -    for (MatchLang =3D Languages, (*Offset) =3D 0; MatchLang !=3D '\0'; =
(*Offset)++)
> {
> +    for (MatchLang =3D Languages, (*Offset) =3D 0; *MatchLang !=3D '\0';
> (*Offset)++) {
>        //
>        // Seek to the end of current match language.
>        //
> --
> 2.21.0.windows.1