From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.115, mailfrom: zailiang.sun@intel.com) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by groups.io with SMTP; Thu, 09 May 2019 00:54:41 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:54:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,449,1549958400"; d="scan'208";a="169892926" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga002.fm.intel.com with ESMTP; 09 May 2019 00:54:41 -0700 Received: from shsmsx154.ccr.corp.intel.com (10.239.6.54) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 00:54:40 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX154.ccr.corp.intel.com ([169.254.7.136]) with mapi id 14.03.0415.000; Thu, 9 May 2019 15:54:39 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Qian, Yi" Subject: Re: [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg Thread-Topic: [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg Thread-Index: AQHVBiARNXc/tofevkapR8JMV/0ZY6ZibKJA Date: Thu, 9 May 2019 07:54:38 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C62E44@SHSMSX104.ccr.corp.intel.com> References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-9-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-9-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 08/16] Vlv2TbltDevicePkg: Use CpuDxe from UefiCpuPkg >=20 > Use CpuDxe module from UefiCPuPkg instead of pre-built binary module > MpCpu. >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Signed-off-by: Michael D Kinney > --- > Vlv2TbltDevicePkg/PlatformPkg.fdf | 2 +- > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 2 +- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 8 ++++++-- > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 7 +++++-- > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 10 ++++++++-- > 5 files changed, 21 insertions(+), 8 deletions(-) >=20 > diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf > b/Vlv2TbltDevicePkg/PlatformPkg.fdf > index be05fa136b..c725cdcf31 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf > +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf > @@ -458,7 +458,7 @@ [FV.FVMAIN] > INF > MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHan > dlerRuntimeDxe.inf > INF > MdeModulePkg/Universal/ReportStatusCodeRouter/Smm/ReportStatusCod > eRouterSmm.inf > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > -INF RuleOverride =3D BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/MpCpu.inf > +INF UefiCpuPkg/CpuDxe/CpuDxe.inf > INF $(PLATFORM_PACKAGE)/Metronome/Metronome.inf > INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > !if $(ARCH) =3D=3D IA32 > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > index d3c7409c4b..349fbb2887 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > +++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > @@ -414,7 +414,7 @@ [FV.FVMAIN] > INF > MdeModulePkg/Universal/StatusCodeHandler/RuntimeDxe/StatusCodeHan > dlerRuntimeDxe.inf > INF > MdeModulePkg/Universal/ReportStatusCodeRouter/Smm/ReportStatusCod > eRouterSmm.inf > INF MdeModulePkg/Universal/SecurityStubDxe/SecurityStubDxe.inf > -INF RuleOverride =3D BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/MpCpu.inf > +INF UefiCpuPkg/CpuDxe/CpuDxe.inf > INF $(PLATFORM_PACKAGE)/Metronome/Metronome.inf > INF IntelFrameworkModulePkg/Universal/BdsDxe/BdsDxe.inf > !if $(ARCH) =3D=3D IA32 > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > index eb1a732683..44a5806153 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > @@ -199,7 +199,8 @@ [LibraryClasses.common] > # > MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >=20 > LocalApicLib|UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.in > f > - > CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibN > ull/CpuExceptionHandlerLibNull.inf > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeC > p > + uExceptionHandlerLib.inf > + MpInitLib|UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf >=20 > # > # ICH > @@ -316,7 +317,8 @@ [LibraryClasses.IA32.PEIM, > LibraryClasses.IA32.PEI_CORE, LibraryClasses.IA32.SEC >=20 > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx > tractGuidedSectionLib.inf >=20 > MultiPlatformLib|$(PLATFORM_PACKAGE)/Library/MultiPlatformLib/MultiPl > atformLib.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > - > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecP > e > + iCpuExceptionHandlerLib.inf > + MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf >=20 > !if $(PERFORMANCE_ENABLE) =3D=3D TRUE >=20 > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc > eLib.inf > @@ -1087,6 +1089,7 @@ [Components.X64] > PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf >=20 > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemory > AllocationLib.inf > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecP > e > + iCpuExceptionHandlerLib.inf > !if $(SOURCE_DEBUG_ENABLE) =3D=3D TRUE >=20 > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAg > entLib.inf > !endif > @@ -1304,6 +1307,7 @@ [Components.X64] > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > + UefiCpuPkg/CpuDxe/CpuDxe.inf > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index d1144db9d9..bff0fe21af 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -199,7 +199,8 @@ [LibraryClasses.common] > # > MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >=20 > LocalApicLib|UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.in > f > - > CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibN > ull/CpuExceptionHandlerLibNull.inf > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeC > p > + uExceptionHandlerLib.inf > + MpInitLib|UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf >=20 > # > # ICH > @@ -316,7 +317,8 @@ [LibraryClasses.IA32.PEIM, > LibraryClasses.IA32.PEI_CORE, LibraryClasses.IA32.SEC >=20 > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx > tractGuidedSectionLib.inf >=20 > MultiPlatformLib|$(PLATFORM_PACKAGE)/Library/MultiPlatformLib/MultiPl > atformLib.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > - > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecP > e > + iCpuExceptionHandlerLib.inf > + MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf >=20 > !if $(PERFORMANCE_ENABLE) =3D=3D TRUE >=20 > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc > eLib.inf > @@ -1292,6 +1294,7 @@ [Components.IA32] > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > + UefiCpuPkg/CpuDxe/CpuDxe.inf > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 1784554160..7630b48ea6 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -199,7 +199,8 @@ [LibraryClasses.common] > # > MtrrLib|UefiCpuPkg/Library/MtrrLib/MtrrLib.inf >=20 > LocalApicLib|UefiCpuPkg/Library/BaseXApicX2ApicLib/BaseXApicX2ApicLib.in > f > - > CpuExceptionHandlerLib|MdeModulePkg/Library/CpuExceptionHandlerLibN > ull/CpuExceptionHandlerLibNull.inf > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/DxeC > p > + uExceptionHandlerLib.inf > + MpInitLib|UefiCpuPkg/Library/MpInitLib/DxeMpInitLib.inf >=20 > # > # ICH > @@ -275,6 +276,8 @@ [LibraryClasses.common] > I2cLib|Vlv2TbltDevicePkg/Library/I2CLib/I2CLibNull.inf > !endif > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > + > + > ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellComma > ndL > + ib.inf > + HandleParsingLib|ShellPkg/Library/UefiHandleParsingLib/UefiHandleParsi > + ngLib.inf > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > SortLib|MdeModulePkg/Library/UefiSortLib/UefiSortLib.inf > !if $(FTPM_ENABLE) =3D=3D TRUE || $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE @@= - > 316,7 +319,8 @@ [LibraryClasses.IA32.PEIM, LibraryClasses.IA32.PEI_CORE, > LibraryClasses.IA32.SEC >=20 > ExtractGuidedSectionLib|MdePkg/Library/PeiExtractGuidedSectionLib/PeiEx > tractGuidedSectionLib.inf >=20 > MultiPlatformLib|$(PLATFORM_PACKAGE)/Library/MultiPlatformLib/MultiPl > atformLib.inf > BaseCryptLib|CryptoPkg/Library/BaseCryptLib/PeiCryptLib.inf > - > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecP > e > + iCpuExceptionHandlerLib.inf > + MpInitLib|UefiCpuPkg/Library/MpInitLib/PeiMpInitLib.inf >=20 > !if $(PERFORMANCE_ENABLE) =3D=3D TRUE >=20 > PerformanceLib|MdeModulePkg/Library/PeiPerformanceLib/PeiPerformanc > eLib.inf > @@ -1087,6 +1091,7 @@ [Components.X64] > PcdLib|MdePkg/Library/PeiPcdLib/PeiPcdLib.inf >=20 > MemoryAllocationLib|MdePkg/Library/PeiMemoryAllocationLib/PeiMemory > AllocationLib.inf > HobLib|MdePkg/Library/PeiHobLib/PeiHobLib.inf > + > + > CpuExceptionHandlerLib|UefiCpuPkg/Library/CpuExceptionHandlerLib/SecP > e > + iCpuExceptionHandlerLib.inf > !if $(SOURCE_DEBUG_ENABLE) =3D=3D TRUE >=20 > DebugAgentLib|SourceLevelDebugPkg/Library/DebugAgent/SecPeiDebugAg > entLib.inf > !endif > @@ -1304,6 +1309,7 @@ [Components.X64] > # > MdeModulePkg/Core/PiSmmCore/PiSmmIpl.inf > MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf > + UefiCpuPkg/CpuDxe/CpuDxe.inf > UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf > UefiCpuPkg/CpuIo2Smm/CpuIo2Smm.inf > MdeModulePkg/Universal/LockBox/SmmLockBox/SmmLockBox.inf > -- > 2.21.0.windows.1