From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zailiang.sun@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Thu, 09 May 2019 00:54:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:54:47 -0700 X-ExtLoop1: 1 Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 09 May 2019 00:54:47 -0700 Received: from FMSMSX110.amr.corp.intel.com (10.18.116.10) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 00:54:47 -0700 Received: from shsmsx106.ccr.corp.intel.com (10.239.4.159) by fmsmsx110.amr.corp.intel.com (10.18.116.10) with Microsoft SMTP Server (TLS) id 14.3.408.0; Thu, 9 May 2019 00:54:47 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by SHSMSX106.ccr.corp.intel.com ([169.254.10.213]) with mapi id 14.03.0415.000; Thu, 9 May 2019 15:54:45 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Qian, Yi" Subject: Re: [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module Thread-Topic: [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module Thread-Index: AQHVBiATqctOQQEgMUKId9zU9AYHqqZibKnw Date: Thu, 9 May 2019 07:54:44 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C62E5F@SHSMSX104.ccr.corp.intel.com> References: <20190509043111.15272-1-michael.d.kinney@intel.com> <20190509043111.15272-10-michael.d.kinney@intel.com> In-Reply-To: <20190509043111.15272-10-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, May 9, 2019 12:31 PM > To: devel@edk2.groups.io > Cc: Sun, Zailiang ; Qian, Yi > Subject: [Patch 09/16] Vlv2TbltDevicePkg: Add PchInitSmm module >=20 > Add the PcdInitSmm module that should not have been removed. This > module performs actions at Exit Boot Services to place devices in an OS > compatible state. > Wothout this module, so versions of Linux are not bootable. >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Signed-off-by: Michael D Kinney > --- > Vlv2TbltDevicePkg/PlatformPkg.fdf | 1 + > Vlv2TbltDevicePkg/PlatformPkgGcc.fdf | 1 + > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 3 +++ > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 2 ++ > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 2 ++ > 5 files changed, 9 insertions(+) >=20 > diff --git a/Vlv2TbltDevicePkg/PlatformPkg.fdf > b/Vlv2TbltDevicePkg/PlatformPkg.fdf > index c725cdcf31..098602b9d8 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkg.fdf > +++ b/Vlv2TbltDevicePkg/PlatformPkg.fdf > @@ -517,6 +517,7 @@ [FV.FVMAIN] >=20 > !if $(MINNOW2_FSP_BUILD) =3D=3D FALSE > INF RuleOverride =3D BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/PchInitDxe.inf > +INF RuleOverride =3D BINARY > +$(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE > _ARCHITECT > +URE)/PchInitSmm.inf > !endif > INF RuleOverride =3D BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/PchSmiDispatcher.inf > !if $(PCIESC_ENABLE) =3D=3D TRUE > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > index 349fbb2887..40385794a3 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > +++ b/Vlv2TbltDevicePkg/PlatformPkgGcc.fdf > @@ -473,6 +473,7 @@ [FV.FVMAIN] >=20 > !if $(MINNOW2_FSP_BUILD) =3D=3D FALSE > INF RuleOverride =3D BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/PchInitDxe.inf > +INF RuleOverride =3D BINARY > +$(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE > _ARCHITECT > +URE)/PchInitSmm.inf > !endif > INF RuleOverride =3D BINARY > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/PchSmiDispatcher.inf > !if $(PCIESC_ENABLE) =3D=3D TRUE > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > index 44a5806153..b9faf558b7 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > @@ -1193,6 +1193,8 @@ [Components.X64] > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0xF0000043 > } > + > + > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITEC > + TURE)/PchInitSmm.inf > + >=20 > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/PchSmiDispatcher.inf >=20 > !if $(PCIESC_ENABLE) =3D=3D TRUE > @@ -1449,6 +1451,7 @@ [Components.X64] > } >=20 >=20 > + > !if $(NETWORK_ENABLE) =3D=3D TRUE > !if $(NETWORK_ISCSI_ENABLE) =3D=3D TRUE > NetworkPkg/IScsiDxe/IScsiDxe.inf > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index bff0fe21af..2324794841 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -1180,6 +1180,8 @@ [Components.IA32] > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0xF0000043 > } > + > + > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITEC > + TURE)/PchInitSmm.inf > + >=20 > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/PchSmiDispatcher.inf >=20 > !if $(PCIESC_ENABLE) =3D=3D TRUE > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 7630b48ea6..10d44d5652 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -1195,6 +1195,8 @@ [Components.X64] > > gEfiMdePkgTokenSpaceGuid.PcdDebugPrintErrorLevel|0xF0000043 > } > + > + > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITEC > + TURE)/PchInitSmm.inf > + >=20 > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/$(DXE_ > ARCHITECTURE)/PchSmiDispatcher.inf >=20 > !if $(PCIESC_ENABLE) =3D=3D TRUE > -- > 2.21.0.windows.1