From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.126, mailfrom: zailiang.sun@intel.com)
Received: from mga18.intel.com (mga18.intel.com [134.134.136.126])
 by groups.io with SMTP; Thu, 09 May 2019 00:54:54 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:54:53 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,449,1549958400"; 
   d="scan'208";a="169892967"
Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202])
  by fmsmga002.fm.intel.com with ESMTP; 09 May 2019 00:54:53 -0700
Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by
 fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:54:53 -0700
Received: from shsmsx105.ccr.corp.intel.com (10.239.4.158) by
 FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:54:52 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX105.ccr.corp.intel.com ([169.254.11.10]) with mapi id 14.03.0415.000;
 Thu, 9 May 2019 15:54:51 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to produce BGRT
Thread-Topic: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to
 produce BGRT
Thread-Index: AQHVBiAS11h9cFbQb0Gh9InyPKhAXqZibLCA
Date: Thu, 9 May 2019 07:54:50 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C62E7D@SHSMSX104.ccr.corp.intel.com>
References: <20190509043111.15272-1-michael.d.kinney@intel.com>
 <20190509043111.15272-11-michael.d.kinney@intel.com>
In-Reply-To: <20190509043111.15272-11-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, May 9, 2019 12:31 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [Patch 10/16] Vlv2TbltDevicePkg: Always enable QuietBoot to
> produce BGRT
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../Library/PlatformBdsLib/BdsPlatform.c      | 19 +++++++++----------
>  1 file changed, 9 insertions(+), 10 deletions(-)
>=20
> diff --git a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
> b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
> index e86c6b3e2e..4d5997d6e9 100644
> --- a/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
> +++ b/Vlv2TbltDevicePkg/Library/PlatformBdsLib/BdsPlatform.c
> @@ -1,6 +1,6 @@
>  /** @file
>=20
> -  Copyright (c) 2004  - 2018, Intel Corporation. All rights reserved.<BR=
>
> +  Copyright (c) 2004  - 2019, Intel Corporation. All rights reserved.<BR=
>
>=20
>    SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
> @@ -1702,6 +1702,8 @@ PlatformBdsPolicyBehavior (
>      EsrtManagement =3D NULL;
>    }
>=20
> +  DEBUG ((DEBUG_INFO, "BDS: BootMode=3D%02x\n", BootMode));
> +
>    switch (BootMode) {
>=20
>    case BOOT_WITH_MINIMAL_CONFIGURATION:
> @@ -1778,9 +1780,8 @@ PlatformBdsPolicyBehavior (
>        goto FULL_CONFIGURATION;
>      }
>=20
> -    if (SystemConfiguration.QuietBoot) {
> -      EnableQuietBoot (PcdGetPtr(PcdLogoFile));
> -    } else {
> +    EnableQuietBoot (PcdGetPtr(PcdLogoFile));
> +    if (!SystemConfiguration.QuietBoot) {
>        PlatformBdsDiagnostics (IGNORE, FALSE, BaseMemoryTest);
>      }
>=20
> @@ -1864,8 +1865,7 @@ PlatformBdsPolicyBehavior (
>      // Boot with the specific configuration
>      //
>      PlatformBdsConnectConsole (gPlatformConsole);
> -    PlatformBdsDiagnostics (EXTENSIVE, FALSE, BaseMemoryTest);
> -    EnableQuietBoot (PcdGetPtr(PcdLogoFile));
> +    PlatformBdsDiagnostics (EXTENSIVE, TRUE, BaseMemoryTest);
>=20
>      DEBUG((DEBUG_INFO, "ProcessCapsules Before EndOfDxe......\n"));
>      ProcessCapsules ();
> @@ -1968,10 +1968,9 @@ FULL_CONFIGURATION:
>      // Perform some platform specific connect sequence
>      //
>      PlatformBdsConnectSequence ();
> -    if (SystemConfiguration.QuietBoot) {
> -        EnableQuietBoot (PcdGetPtr(PcdLogoFile));
> -    } else {
> -        PlatformBdsDiagnostics (IGNORE, FALSE, BaseMemoryTest);
> +    EnableQuietBoot (PcdGetPtr(PcdLogoFile));
> +    if (!SystemConfiguration.QuietBoot) {
> +      PlatformBdsDiagnostics (IGNORE, FALSE, BaseMemoryTest);
>      }
>=20
>      //
> --
> 2.21.0.windows.1