From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.20, mailfrom: zailiang.sun@intel.com)
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by groups.io with SMTP; Thu, 09 May 2019 00:55:12 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from fmsmga002.fm.intel.com ([10.253.24.26])
  by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 May 2019 00:55:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.60,449,1549958400"; 
   d="scan'208";a="169893041"
Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204])
  by fmsmga002.fm.intel.com with ESMTP; 09 May 2019 00:55:11 -0700
Received: from FMSMSX109.amr.corp.intel.com (10.18.116.9) by
 FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:55:11 -0700
Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by
 fmsmsx109.amr.corp.intel.com (10.18.116.9) with Microsoft SMTP Server (TLS)
 id 14.3.408.0; Thu, 9 May 2019 00:55:11 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.33]) by
 SHSMSX108.ccr.corp.intel.com ([169.254.8.126]) with mapi id 14.03.0415.000;
 Thu, 9 May 2019 15:55:09 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varstore
Thread-Topic: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI
 varstore
Thread-Index: AQHVBiATmR7nbHuL802PiUsy/LT5xaZibMXA
Date: Thu, 9 May 2019 07:55:08 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C62EC0@SHSMSX104.ccr.corp.intel.com>
References: <20190509043111.15272-1-michael.d.kinney@intel.com>
 <20190509043111.15272-14-michael.d.kinney@intel.com>
In-Reply-To: <20190509043111.15272-14-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, May 9, 2019 12:31 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [Patch 13/16] Vlv2TbltDevicePkg/Capsule: Do not clear UEFI varst=
ore
>=20
> Preserve the UEFI Variable store when a capsule update is performed.  UEF=
I
> Variables are used to store firmware version information for the sample
> devices (Red, Green, Blue).
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  .../Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.c    | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>=20
> diff --git
> a/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.
> c
> b/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.
> c
> index 3d5649164b..a863d69381 100644
> ---
> a/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLib.
> c
> +++
> b/Vlv2TbltDevicePkg/Feature/Capsule/Library/FmpDeviceLib/FmpDeviceLi
> +++ b.c
> @@ -1,8 +1,8 @@
>  /**
>=20
> -Copyright (c) 2016, Microsoft Corporation
> +Copyright (c) 2016, Microsoft Corporation.  All rights reserved.
> +Copyright (c) 2019, Intel Corporation.  All rights reserved.
>=20
> -All rights reserved.
>  SPDX-License-Identifier: BSD-2-Clause-Patent
>=20
>  **/
> @@ -36,8 +36,7 @@ UPDATE_CONFIG_DATA mUpdateConfigData[] =3D {
>    { PlatformFirmwareTypeSystemFirmware,
> FlashAddressTypeRelativeAddress, 0x000C0000, 0x00050000, 0x000C0000 },
>    { PlatformFirmwareTypeSystemFirmware,
> FlashAddressTypeRelativeAddress, 0x00110000, 0x00210000, 0x00110000 },
>    { PlatformFirmwareTypeSystemFirmware,
> FlashAddressTypeRelativeAddress, 0x00320000, 0x00070000, 0x00320000 },
> -  { PlatformFirmwareTypeSystemFirmware,
> FlashAddressTypeRelativeAddress, 0x00390000, 0x00070000, 0x00390000 },
> -  { PlatformFirmwareTypeNvRam,          FlashAddressTypeRelativeAddress,
> 0x00040000, 0x00080000, 0x00040000 }
> +  { PlatformFirmwareTypeSystemFirmware,
> + FlashAddressTypeRelativeAddress, 0x00390000, 0x00070000, 0x00390000 }
>  };
>=20
>  /**
> --
> 2.21.0.windows.1