public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [Patch edk2-platform 0/3] Add NetworkPkg/NetworkPkg.dec as the package dependency
@ 2019-05-20 13:09 Liming Gao
  2019-05-20 13:09 ` [Patch edk2-platform 1/3] Platform/ARM: " Liming Gao
                   ` (2 more replies)
  0 siblings, 3 replies; 10+ messages in thread
From: Liming Gao @ 2019-05-20 13:09 UTC (permalink / raw)
  To: devel

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Liming Gao (3):
  Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency
  Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec as the package
    dependency
  Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec as the package
    dependency

 Platform/ARM/Library/BdsLib/BdsLib.inf                                 | 1 +
 .../Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf  | 1 +
 .../IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf    | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf       | 3 ++-
 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf                          | 1 +
 5 files changed, 6 insertions(+), 1 deletion(-)

-- 
2.13.0.windows.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency
  2019-05-20 13:09 [Patch edk2-platform 0/3] Add NetworkPkg/NetworkPkg.dec as the package dependency Liming Gao
@ 2019-05-20 13:09 ` Liming Gao
  2019-05-20 14:51   ` Leif Lindholm
  2019-05-20 13:09 ` [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec " Liming Gao
  2019-05-20 13:09 ` [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec " Liming Gao
  2 siblings, 1 reply; 10+ messages in thread
From: Liming Gao @ 2019-05-20 13:09 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Platform/ARM/Library/BdsLib/BdsLib.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf b/Platform/ARM/Library/BdsLib/BdsLib.inf
index 12995cf174..6b95ec943b 100644
--- a/Platform/ARM/Library/BdsLib/BdsLib.inf
+++ b/Platform/ARM/Library/BdsLib/BdsLib.inf
@@ -23,6 +23,7 @@
   MdeModulePkg/MdeModulePkg.dec
   MdePkg/MdePkg.dec
   Platform/ARM/ARM.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   ArmLib
-- 
2.13.0.windows.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec as the package dependency
  2019-05-20 13:09 [Patch edk2-platform 0/3] Add NetworkPkg/NetworkPkg.dec as the package dependency Liming Gao
  2019-05-20 13:09 ` [Patch edk2-platform 1/3] Platform/ARM: " Liming Gao
@ 2019-05-20 13:09 ` Liming Gao
  2019-05-20 15:05   ` Sun, Zailiang
                     ` (2 more replies)
  2019-05-20 13:09 ` [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec " Liming Gao
  2 siblings, 3 replies; 10+ messages in thread
From: Liming Gao @ 2019-05-20 13:09 UTC (permalink / raw)
  To: devel; +Cc: Zailiang Sun, Yi Qian

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
---
 .../Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf  | 1 +
 .../IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf    | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf       | 3 ++-
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
index d3bef0fa39..66d11c6cda 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
@@ -48,6 +48,7 @@
   SecurityPkg/SecurityPkg.dec
   SignedCapsulePkg/SignedCapsulePkg.dec
   SourceLevelDebugPkg/SourceLevelDebugPkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   DxeServicesTableLib
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
index e3c8a6fa27..795a9de4b8 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
@@ -44,6 +44,7 @@
   IntelFrameworkPkg/IntelFrameworkPkg.dec
   IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
   ShellPkg/ShellPkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   DevicePathLib
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
index 37e54a92a8..09917eb702 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
@@ -2,7 +2,7 @@
 # Component name for module MiscSubclass
 #
 # FIX ME!
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2019, Intel Corporation. All rights reserved.<BR>
 #                                                                                  
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #                                                                                  
@@ -89,6 +89,7 @@
   MdePkg/MdePkg.dec
   IntelFrameworkPkg/IntelFrameworkPkg.dec
   Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   HiiLib
-- 
2.13.0.windows.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec as the package dependency
  2019-05-20 13:09 [Patch edk2-platform 0/3] Add NetworkPkg/NetworkPkg.dec as the package dependency Liming Gao
  2019-05-20 13:09 ` [Patch edk2-platform 1/3] Platform/ARM: " Liming Gao
  2019-05-20 13:09 ` [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec " Liming Gao
@ 2019-05-20 13:09 ` Liming Gao
  2019-05-20 14:52   ` Leif Lindholm
  2 siblings, 1 reply; 10+ messages in thread
From: Liming Gao @ 2019-05-20 13:09 UTC (permalink / raw)
  To: devel; +Cc: Ard Biesheuvel, Leif Lindholm, Michael D Kinney

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Michael D Kinney <michael.d.kinney@intel.com>
---
 Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf
index 73aa4133b6..ea63f73ded 100644
--- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf
+++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf
@@ -48,6 +48,7 @@
   MdeModulePkg/MdeModulePkg.dec
   ArmPkg/ArmPkg.dec
   Silicon/Marvell/Marvell.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   DmaLib
-- 
2.13.0.windows.1


^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency
  2019-05-20 13:09 ` [Patch edk2-platform 1/3] Platform/ARM: " Liming Gao
@ 2019-05-20 14:51   ` Leif Lindholm
  2019-05-20 14:54     ` Liming Gao
  0 siblings, 1 reply; 10+ messages in thread
From: Leif Lindholm @ 2019-05-20 14:51 UTC (permalink / raw)
  To: Liming Gao; +Cc: devel, Ard Biesheuvel, Michael D Kinney

On Mon, May 20, 2019 at 09:09:47PM +0800, Liming Gao wrote:
> NetLib will be moved from MdeModulePkg and NetworkPkg.
> So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Platform/ARM/Library/BdsLib/BdsLib.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf b/Platform/ARM/Library/BdsLib/BdsLib.inf
> index 12995cf174..6b95ec943b 100644
> --- a/Platform/ARM/Library/BdsLib/BdsLib.inf
> +++ b/Platform/ARM/Library/BdsLib/BdsLib.inf
> @@ -23,6 +23,7 @@
>    MdeModulePkg/MdeModulePkg.dec
>    MdePkg/MdePkg.dec
>    Platform/ARM/ARM.dec
> +  NetworkPkg/NetworkPkg.dec

If you move that insertion up one line to get it alphabetically
sorted:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  
>  [LibraryClasses]
>    ArmLib
> -- 
> 2.13.0.windows.1
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec as the package dependency
  2019-05-20 13:09 ` [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec " Liming Gao
@ 2019-05-20 14:52   ` Leif Lindholm
  0 siblings, 0 replies; 10+ messages in thread
From: Leif Lindholm @ 2019-05-20 14:52 UTC (permalink / raw)
  To: Liming Gao; +Cc: devel, Ard Biesheuvel, Michael D Kinney

On Mon, May 20, 2019 at 09:09:49PM +0800, Liming Gao wrote:
> NetLib will be moved from MdeModulePkg and NetworkPkg.
> So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf
> index 73aa4133b6..ea63f73ded 100644
> --- a/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf
> +++ b/Silicon/Marvell/Drivers/Net/Pp2Dxe/Pp2Dxe.inf
> @@ -48,6 +48,7 @@
>    MdeModulePkg/MdeModulePkg.dec
>    ArmPkg/ArmPkg.dec
>    Silicon/Marvell/Marvell.dec
> +  NetworkPkg/NetworkPkg.dec

If you move this one too up one line:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  
>  [LibraryClasses]
>    DmaLib
> -- 
> 2.13.0.windows.1
> 

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency
  2019-05-20 14:51   ` Leif Lindholm
@ 2019-05-20 14:54     ` Liming Gao
  0 siblings, 0 replies; 10+ messages in thread
From: Liming Gao @ 2019-05-20 14:54 UTC (permalink / raw)
  To: Leif Lindholm; +Cc: devel@edk2.groups.io, Ard Biesheuvel, Kinney, Michael D

Thanks for your quick review. I will update and push. 

> -----Original Message-----
> From: Leif Lindholm [mailto:leif.lindholm@linaro.org]
> Sent: Monday, May 20, 2019 10:51 PM
> To: Gao, Liming <liming.gao@intel.com>
> Cc: devel@edk2.groups.io; Ard Biesheuvel <ard.biesheuvel@linaro.org>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: Re: [Patch edk2-platform 1/3] Platform/ARM: Add NetworkPkg/NetworkPkg.dec as the package dependency
> 
> On Mon, May 20, 2019 at 09:09:47PM +0800, Liming Gao wrote:
> > NetLib will be moved from MdeModulePkg and NetworkPkg.
> > So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> >
> > Signed-off-by: Liming Gao <liming.gao@intel.com>
> > Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > Cc: Leif Lindholm <leif.lindholm@linaro.org>
> > Cc: Michael D Kinney <michael.d.kinney@intel.com>
> > ---
> >  Platform/ARM/Library/BdsLib/BdsLib.inf | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/Platform/ARM/Library/BdsLib/BdsLib.inf b/Platform/ARM/Library/BdsLib/BdsLib.inf
> > index 12995cf174..6b95ec943b 100644
> > --- a/Platform/ARM/Library/BdsLib/BdsLib.inf
> > +++ b/Platform/ARM/Library/BdsLib/BdsLib.inf
> > @@ -23,6 +23,7 @@
> >    MdeModulePkg/MdeModulePkg.dec
> >    MdePkg/MdePkg.dec
> >    Platform/ARM/ARM.dec
> > +  NetworkPkg/NetworkPkg.dec
> 
> If you move that insertion up one line to get it alphabetically
> sorted:
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> 
> >
> >  [LibraryClasses]
> >    ArmLib
> > --
> > 2.13.0.windows.1
> >

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec as the package dependency
  2019-05-20 13:09 ` [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec " Liming Gao
@ 2019-05-20 15:05   ` Sun, Zailiang
  2019-05-21  1:00   ` Qian, Yi
  2019-05-22  3:42   ` Sun, Zailiang
  2 siblings, 0 replies; 10+ messages in thread
From: Sun, Zailiang @ 2019-05-20 15:05 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io; +Cc: Qian, Yi

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, May 20, 2019 9:10 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add
> NetworkPkg.dec as the package dependency
> 
> NetLib will be moved from MdeModulePkg and NetworkPkg.
> So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf  | 1 +
>  .../IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf    |
> 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf       | 3
> ++-
>  3 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.i
> nf
> b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.i
> nf
> index d3bef0fa39..66d11c6cda 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.i
> nf
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBd
> +++ sLib.inf
> @@ -48,6 +48,7 @@
>    SecurityPkg/SecurityPkg.dec
>    SignedCapsulePkg/SignedCapsulePkg.dec
>    SourceLevelDebugPkg/SourceLevelDebugPkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    DxeServicesTableLib
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Li
> brary/GenericBdsLib/GenericBdsLib.inf
> b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Li
> brary/GenericBdsLib/GenericBdsLib.inf
> index e3c8a6fa27..795a9de4b8 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Li
> brary/GenericBdsLib/GenericBdsLib.inf
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/
> +++ Library/GenericBdsLib/GenericBdsLib.inf
> @@ -44,6 +44,7 @@
>    IntelFrameworkPkg/IntelFrameworkPkg.dec
>    IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
>    ShellPkg/ShellPkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    DevicePathLib
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> index 37e54a92a8..09917eb702 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> @@ -2,7 +2,7 @@
>  # Component name for module MiscSubclass  #  # FIX ME!
> -# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2006 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -89,6 +89,7 @@
>    MdePkg/MdePkg.dec
>    IntelFrameworkPkg/IntelFrameworkPkg.dec
>    Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    HiiLib
> --
> 2.13.0.windows.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec as the package dependency
  2019-05-20 13:09 ` [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec " Liming Gao
  2019-05-20 15:05   ` Sun, Zailiang
@ 2019-05-21  1:00   ` Qian, Yi
  2019-05-22  3:42   ` Sun, Zailiang
  2 siblings, 0 replies; 10+ messages in thread
From: Qian, Yi @ 2019-05-21  1:00 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io; +Cc: Sun, Zailiang

Reviewed by Qian Yi<yi.qian@intel.com>

Thanks
Qian Yi

-----Original Message-----
From: Gao, Liming 
Sent: Monday, May 20, 2019 9:10 PM
To: devel@edk2.groups.io
Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
Subject: [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec as the package dependency

NetLib will be moved from MdeModulePkg and NetworkPkg.
So, the module that consumes NetLib need to depend on NetworkPkg.dec.

Signed-off-by: Liming Gao <liming.gao@intel.com>
Cc: Zailiang Sun <zailiang.sun@intel.com>
Cc: Yi Qian <yi.qian@intel.com>
---
 .../Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf  | 1 +
 .../IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf    | 1 +
 Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf       | 3 ++-
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
index d3bef0fa39..66d11c6cda 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBd
+++ sLib.inf
@@ -48,6 +48,7 @@
   SecurityPkg/SecurityPkg.dec
   SignedCapsulePkg/SignedCapsulePkg.dec
   SourceLevelDebugPkg/SourceLevelDebugPkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   DxeServicesTableLib
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
index e3c8a6fa27..795a9de4b8 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf
+++ b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/
+++ Library/GenericBdsLib/GenericBdsLib.inf
@@ -44,6 +44,7 @@
   IntelFrameworkPkg/IntelFrameworkPkg.dec
   IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
   ShellPkg/ShellPkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   DevicePathLib
diff --git a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
index 37e54a92a8..09917eb702 100644
--- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
+++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
@@ -2,7 +2,7 @@
 # Component name for module MiscSubclass  #  # FIX ME!
-# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
+# Copyright (c) 2006 - 2019, Intel Corporation. All rights 
+reserved.<BR>
 #                                                                        
 # SPDX-License-Identifier: BSD-2-Clause-Patent
 #                                                                        
@@ -89,6 +89,7 @@
   MdePkg/MdePkg.dec
   IntelFrameworkPkg/IntelFrameworkPkg.dec
   Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec
+  NetworkPkg/NetworkPkg.dec
 
 [LibraryClasses]
   HiiLib
--
2.13.0.windows.1



-- 
Qian Yi

^ permalink raw reply related	[flat|nested] 10+ messages in thread

* Re: [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec as the package dependency
  2019-05-20 13:09 ` [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec " Liming Gao
  2019-05-20 15:05   ` Sun, Zailiang
  2019-05-21  1:00   ` Qian, Yi
@ 2019-05-22  3:42   ` Sun, Zailiang
  2 siblings, 0 replies; 10+ messages in thread
From: Sun, Zailiang @ 2019-05-22  3:42 UTC (permalink / raw)
  To: Gao, Liming, devel@edk2.groups.io; +Cc: Qian, Yi

Reviewed-by: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Gao, Liming
> Sent: Monday, May 20, 2019 9:10 PM
> To: devel@edk2.groups.io
> Cc: Sun, Zailiang <zailiang.sun@intel.com>; Qian, Yi <yi.qian@intel.com>
> Subject: [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add
> NetworkPkg.dec as the package dependency
> 
> NetLib will be moved from MdeModulePkg and NetworkPkg.
> So, the module that consumes NetLib need to depend on NetworkPkg.dec.
> 
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> ---
>  .../Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.inf  | 1 +
>  .../IntelFrameworkModulePkg/Library/GenericBdsLib/GenericBdsLib.inf    |
> 1 +
>  Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf       | 3
> ++-
>  3 files changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.i
> nf
> b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.i
> nf
> index d3bef0fa39..66d11c6cda 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBdsLib.i
> nf
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/Library/PlatformBdsLib/PlatformBd
> +++ sLib.inf
> @@ -48,6 +48,7 @@
>    SecurityPkg/SecurityPkg.dec
>    SignedCapsulePkg/SignedCapsulePkg.dec
>    SourceLevelDebugPkg/SourceLevelDebugPkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    DxeServicesTableLib
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Li
> brary/GenericBdsLib/GenericBdsLib.inf
> b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Li
> brary/GenericBdsLib/GenericBdsLib.inf
> index e3c8a6fa27..795a9de4b8 100644
> ---
> a/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/Li
> brary/GenericBdsLib/GenericBdsLib.inf
> +++
> b/Platform/Intel/Vlv2TbltDevicePkg/Override/IntelFrameworkModulePkg/
> +++ Library/GenericBdsLib/GenericBdsLib.inf
> @@ -44,6 +44,7 @@
>    IntelFrameworkPkg/IntelFrameworkPkg.dec
>    IntelFrameworkModulePkg/IntelFrameworkModulePkg.dec
>    ShellPkg/ShellPkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    DevicePathLib
> diff --git
> a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> index 37e54a92a8..09917eb702 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe.inf
> @@ -2,7 +2,7 @@
>  # Component name for module MiscSubclass  #  # FIX ME!
> -# Copyright (c) 2006 - 2018, Intel Corporation. All rights reserved.<BR>
> +# Copyright (c) 2006 - 2019, Intel Corporation. All rights
> +reserved.<BR>
>  #
>  # SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -89,6 +89,7 @@
>    MdePkg/MdePkg.dec
>    IntelFrameworkPkg/IntelFrameworkPkg.dec
>    Vlv2DeviceRefCodePkg/Vlv2DeviceRefCodePkg.dec
> +  NetworkPkg/NetworkPkg.dec
> 
>  [LibraryClasses]
>    HiiLib
> --
> 2.13.0.windows.1


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-05-22  3:42 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-20 13:09 [Patch edk2-platform 0/3] Add NetworkPkg/NetworkPkg.dec as the package dependency Liming Gao
2019-05-20 13:09 ` [Patch edk2-platform 1/3] Platform/ARM: " Liming Gao
2019-05-20 14:51   ` Leif Lindholm
2019-05-20 14:54     ` Liming Gao
2019-05-20 13:09 ` [Patch edk2-platform 2/3] Platform/Intel/Vlv2TbltDevicePkg: Add NetworkPkg.dec " Liming Gao
2019-05-20 15:05   ` Sun, Zailiang
2019-05-21  1:00   ` Qian, Yi
2019-05-22  3:42   ` Sun, Zailiang
2019-05-20 13:09 ` [Patch edk2-platform 3/3] Silicon/Marvell: Add NetworkPkg/NetworkPkg.dec " Liming Gao
2019-05-20 14:52   ` Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox