From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.151, mailfrom: zailiang.sun@intel.com) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by groups.io with SMTP; Sun, 30 Jun 2019 21:07:17 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2019 21:07:16 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,437,1557212400"; d="scan'208";a="361696956" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 30 Jun 2019 21:07:16 -0700 Received: from fmsmsx158.amr.corp.intel.com (10.18.116.75) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Jun 2019 21:07:16 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx158.amr.corp.intel.com (10.18.116.75) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Jun 2019 21:07:16 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000; Mon, 1 Jul 2019 12:07:13 +0800 From: "Sun, Zailiang" To: "devel@edk2.groups.io" , "Kinney, Michael D" CC: "Qian, Yi" Subject: Re: [edk2-devel] [edk2-platforms Patch 06/14] Vlv2TbltDevicePkg: Remove use of PS/2 Policy Protocol Thread-Topic: [edk2-devel] [edk2-platforms Patch 06/14] Vlv2TbltDevicePkg: Remove use of PS/2 Policy Protocol Thread-Index: AQHVL7iNU0L9kNC5o02Eg0/HLyKjoaa1JXVQ Date: Mon, 1 Jul 2019 04:07:12 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C904F4@SHSMSX104.ccr.corp.intel.com> References: <20190701025553.18596-1-michael.d.kinney@intel.com> <20190701025553.18596-7-michael.d.kinney@intel.com> In-Reply-To: <20190701025553.18596-7-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Zailiang Sun -----Original Message----- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Mich= ael D Kinney Sent: Monday, July 01, 2019 10:56 AM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [edk2-devel] [edk2-platforms Patch 06/14] Vlv2TbltDevicePkg: Remo= ve use of PS/2 Policy Protocol This platform does not have a PS/2 controller, so remove all references to= the PS/2 Policy Protocol. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c = b/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c index cb280764b3..13d904b834 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/AcpiPlatform/AcpiPlatform.c @@ -37,7 +37,6 @@ Abstract: #include #include #include -#include #include #include #include @@ -772,7 +771,6 @@ AcpiPlatformEntryPoint ( UINTN VarSize; UINTN SysCfgSize; EFI_HANDLE Handle; - EFI_PS2_POLICY_PROTOCOL *Ps2Policy; EFI_PEI_HOB_POINTERS GuidHob; EFI_MP_SERVICES_PROTOCOL *MpService; UINTN MaximumNumberOfCPUs; @@ -1131,19 +1129,6 @@ AcpiPlatformEntryPoint ( // mGlobalNvsArea.Area->WPCN381U =3D GLOBAL_NVS_DEVICE_DISABLE; mGlobalNvsArea.Area->DockedSioPresent =3D GLOBAL_NVS_DEVICE_DISABLE; - - // - // Get Ps2 policy to set. Will be use if present. - // - Status =3D gBS->LocateProtocol ( - &gEfiPs2PolicyProtocolGuid, - NULL, - (VOID **)&Ps2Policy - ); - if (!EFI_ERROR (Status)) { - Status =3D Ps2Policy->Ps2InitHardware (ImageHandle); - } - mGlobalNvsArea.Area->SDIOMode =3D mSystemConfiguration.LpssSdioMode; =20 Handle =3D NULL; -- 2.21.0.windows.1