From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.88, mailfrom: zailiang.sun@intel.com) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by groups.io with SMTP; Sun, 30 Jun 2019 21:08:47 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 30 Jun 2019 21:08:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,437,1557212400"; d="scan'208";a="361697347" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga005.fm.intel.com with ESMTP; 30 Jun 2019 21:08:46 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Jun 2019 21:08:46 -0700 Received: from shsmsx108.ccr.corp.intel.com (10.239.4.97) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.439.0; Sun, 30 Jun 2019 21:08:46 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX108.ccr.corp.intel.com ([169.254.8.174]) with mapi id 14.03.0439.000; Mon, 1 Jul 2019 12:08:44 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: "Qian, Yi" Subject: Re: [edk2-platforms Patch 14/14] Vlv2TbltDevicePkg/PlatformInitPei: Update MemoryTypeInformation Thread-Topic: [edk2-platforms Patch 14/14] Vlv2TbltDevicePkg/PlatformInitPei: Update MemoryTypeInformation Thread-Index: AQHVL7imkQOdJi31OkyKpyjO2N7djaa1JeOg Date: Mon, 1 Jul 2019 04:08:43 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C905D0@SHSMSX104.ccr.corp.intel.com> References: <20190701025553.18596-1-michael.d.kinney@intel.com> <20190701025553.18596-15-michael.d.kinney@intel.com> In-Reply-To: <20190701025553.18596-15-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Zailiang Sun -----Original Message----- From: Kinney, Michael D=20 Sent: Monday, July 01, 2019 10:56 AM To: devel@edk2.groups.io Cc: Sun, Zailiang ; Qian, Yi Subject: [edk2-platforms Patch 14/14] Vlv2TbltDevicePkg/PlatformInitPei: Up= date MemoryTypeInformation Reduce extra reboots when UEFI Shell is run followed by an OS boot. The extra reboot is due to use of EfiLoaderCode that exceeds the MemoryType= Information bin size. EfiLoaderCode should not be tracked. Remove all memory types that should not be tracked, and update the remainin= g bin sizes based on observed memory usage on an X64 DEBUG profile. Cc: Zailiang Sun Cc: Yi Qian Signed-off-by: Michael D Kinney --- .../PlatformInitPei/MemoryPeim.c | 21 +++++-------------- 1 file changed, 5 insertions(+), 16 deletions(-) diff --git a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/MemoryPeim.c = b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/MemoryPeim.c index e6189b7713..64b606637a 100644 --- a/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/MemoryPeim.c +++ b/Platform/Intel/Vlv2TbltDevicePkg/PlatformInitPei/MemoryPeim.c @@ -1,11 +1,9 @@ /** @file =20 - Copyright (c) 2004 - 2016, Intel Corporation. All rights reserved.
- = =20 + Copyright (c) 2004 - 2019, Intel Corporation. All rights=20 + reserved.
+ SPDX-License-Identifier: BSD-2-Clause-Patent =20 - = =20 - Module Name: =20 =20 @@ -40,19 +38,10 @@ Abstract: =20 EFI_MEMORY_TYPE_INFORMATION mDefaultMemoryTypeInformation[] =3D { { EfiACPIReclaimMemory, 0x40 }, // 0x40 pages =3D 256k for ASL - { EfiACPIMemoryNVS, 0x100 }, // 0x100 pages =3D 1 MB for S3= , SMM, HII, etc - { EfiReservedMemoryType, 0x600 }, // 48k for BIOS Reserved - { EfiMemoryMappedIO, 0 }, - { EfiMemoryMappedIOPortSpace, 0 }, - { EfiPalCode, 0 }, - { EfiRuntimeServicesCode, 0x200 }, + { EfiACPIMemoryNVS, 0x40 }, // 0x40 pages =3D 256k MB for = S3, SMM, HII, etc + { EfiReservedMemoryType, 0x80 }, // 512k for BIOS Reserved + { EfiRuntimeServicesCode, 0x100 }, { EfiRuntimeServicesData, 0x100 }, - { EfiLoaderCode, 0x100 }, - { EfiLoaderData, 0x100 }, - { EfiBootServicesCode, 0x800 }, - { EfiBootServicesData, 0x2500}, - { EfiConventionalMemory, 0 }, - { EfiUnusableMemory, 0 }, { EfiMaxMemoryType, 0 } }; =20 -- 2.21.0.windows.1