From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: intel.com, ip: 192.55.52.93, mailfrom: zailiang.sun@intel.com)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by groups.io with SMTP; Wed, 10 Jul 2019 21:46:52 -0700
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga007.jf.intel.com ([10.7.209.58])
  by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 21:46:51 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; 
   d="scan'208";a="156709086"
Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203])
  by orsmga007.jf.intel.com with ESMTP; 10 Jul 2019 21:46:51 -0700
Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by
 FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 10 Jul 2019 21:46:51 -0700
Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by
 FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS)
 id 14.3.439.0; Wed, 10 Jul 2019 21:46:35 -0700
Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by
 SHSMSX151.ccr.corp.intel.com ([169.254.3.55]) with mapi id 14.03.0439.000;
 Thu, 11 Jul 2019 12:46:34 +0800
From: "Sun, Zailiang" <zailiang.sun@intel.com>
To: "Kinney, Michael D" <michael.d.kinney@intel.com>, "devel@edk2.groups.io"
	<devel@edk2.groups.io>
CC: Gary Lin <glin@suse.com>, "Qian, Yi" <yi.qian@intel.com>
Subject: Re: [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Add "set -e" to exit on error
Thread-Topic: [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh:
 Add "set -e" to exit on error
Thread-Index: AQHVN1Jy+P5c6wTVE0+EmC1upFzm2qbE2HWA
Date: Thu, 11 Jul 2019 04:46:33 +0000
Message-ID: <7CB7EF03E15B5D48981329A508747A9850C95D11@SHSMSX104.ccr.corp.intel.com>
References: <20190710190516.6012-1-michael.d.kinney@intel.com>
 <20190710190516.6012-2-michael.d.kinney@intel.com>
In-Reply-To: <20190710190516.6012-2-michael.d.kinney@intel.com>
Accept-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.239.127.40]
MIME-Version: 1.0
Return-Path: zailiang.sun@intel.com
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable

Reviewed-By: Zailiang Sun <zailiang.sun@intel.com>

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Thursday, July 11, 2019 3:05 AM
> To: devel@edk2.groups.io
> Cc: Gary Lin <glin@suse.com>; Sun, Zailiang <zailiang.sun@intel.com>; Qia=
n,
> Yi <yi.qian@intel.com>
> Subject: [edk2-platforms Patch 01/28] Vlv2TbltDevicePkg/Build_IFWI.sh: Ad=
d
> "set -e" to exit on error
>=20
> From: Gary Lin <glin@suse.com>
>=20
> Cc: Zailiang Sun <zailiang.sun@intel.com>
> Cc: Yi Qian <yi.qian@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Signed-off-by: Gary Lin <glin@suse.com>
> ---
>  Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> index 4a11a1cba9..7063b7470d 100644
> --- a/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> +++ b/Platform/Intel/Vlv2TbltDevicePkg/Build_IFWI.sh
> @@ -19,6 +19,8 @@ function Usage ( ) {
>    exit 0
>  }
>=20
> +set -e
> +
>  ## Assign initial values
>  exitCode=3D0
>  Build_Flags=3D
> --
> 2.21.0.windows.1