From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: intel.com, ip: 134.134.136.24, mailfrom: zailiang.sun@intel.com) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by groups.io with SMTP; Wed, 10 Jul 2019 21:47:33 -0700 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga008.fm.intel.com ([10.253.24.58]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 10 Jul 2019 21:47:33 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.63,476,1557212400"; d="scan'208";a="166281443" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga008.fm.intel.com with ESMTP; 10 Jul 2019 21:47:33 -0700 Received: from fmsmsx112.amr.corp.intel.com (10.18.116.6) by fmsmsx107.amr.corp.intel.com (10.18.124.205) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 21:47:33 -0700 Received: from shsmsx107.ccr.corp.intel.com (10.239.4.96) by FMSMSX112.amr.corp.intel.com (10.18.116.6) with Microsoft SMTP Server (TLS) id 14.3.439.0; Wed, 10 Jul 2019 21:47:32 -0700 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.110]) by SHSMSX107.ccr.corp.intel.com ([169.254.9.162]) with mapi id 14.03.0439.000; Thu, 11 Jul 2019 12:47:31 +0800 From: "Sun, Zailiang" To: "Kinney, Michael D" , "devel@edk2.groups.io" CC: Gary Lin , "Qian, Yi" Subject: Re: [edk2-platforms Patch 04/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update the gcc version detection Thread-Topic: [edk2-platforms Patch 04/28] Vlv2TbltDevicePkg/bld_vlv.sh: Update the gcc version detection Thread-Index: AQHVN1JynaOC3gtALUuPome7ZlL+aqbE2NOg Date: Thu, 11 Jul 2019 04:47:30 +0000 Message-ID: <7CB7EF03E15B5D48981329A508747A9850C95D53@SHSMSX104.ccr.corp.intel.com> References: <20190710190516.6012-1-michael.d.kinney@intel.com> <20190710190516.6012-5-michael.d.kinney@intel.com> In-Reply-To: <20190710190516.6012-5-michael.d.kinney@intel.com> Accept-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Return-Path: zailiang.sun@intel.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-By: Zailiang Sun > -----Original Message----- > From: Kinney, Michael D > Sent: Thursday, July 11, 2019 3:05 AM > To: devel@edk2.groups.io > Cc: Gary Lin ; Sun, Zailiang ; Qia= n, > Yi > Subject: [edk2-platforms Patch 04/28] Vlv2TbltDevicePkg/bld_vlv.sh: Updat= e > the gcc version detection >=20 > From: Gary Lin >=20 > Borrow the logic from OvmfPkg/build.sh >=20 > Cc: Zailiang Sun > Cc: Yi Qian > Cc: Michael D Kinney > Signed-off-by: Gary Lin > --- > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 19 +++++++++++++------ > 1 file changed, 13 insertions(+), 6 deletions(-) >=20 > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > index bca112db2b..d312063428 100755 > --- a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > +++ b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > @@ -170,12 +170,19 @@ sed -i '/^MAX_CONCURRENT_THREAD_NUMBER/d' > Conf/target.txt >=20 > gcc_version=3D$(gcc -v 2>&1 | tail -1 | awk '{print $3}') case $gcc_ver= sion in > - 4.9.*|4.1[0-9].*|5.*.*|6.*.*) > - TARGET_TOOLS=3DGCC49 > - ;; > - *) > - TARGET_TOOLS=3DGCC48 > - ;; > + [1-3].*|4.[0-7].*) > + echo MNW2 requires GCC4.8 or later > + exit 1 > + ;; > + 4.8.*) > + TARGET_TOOLS=3DGCC48 > + ;; > + 4.9.*|6.[0-2].*) > + TARGET_TOOLS=3DGCC49 > + ;; > + *) > + TARGET_TOOLS=3DGCC5 > + ;; > esac >=20 > ACTIVE_PLATFORM=3D$PLATFORM_PACKAGE/PlatformPkgGcc"$Arch".dsc > -- > 2.21.0.windows.1